Skip to content

Commit c61f829

Browse files
committed
Merge branch '6.4' into 7.1
* 6.4: Fix typos in end_to_end.rst Remove unnecessary type checking for the method from SentMessageEvent
2 parents fabff4d + 6634a89 commit c61f829

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

mailer.rst

-4
Original file line numberDiff line numberDiff line change
@@ -1679,14 +1679,10 @@ which is useful for debugging errors::
16791679

16801680
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
16811681
use Symfony\Component\Mailer\Event\SentMessageEvent;
1682-
use Symfony\Component\Mailer\SentMessage;
16831682

16841683
public function onMessage(SentMessageEvent $event): void
16851684
{
16861685
$message = $event->getMessage();
1687-
if (!$message instanceof SentMessage) {
1688-
return;
1689-
}
16901686

16911687
// do something with the message
16921688
}

testing/end_to_end.rst

+7-8
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ to install ChromeDriver and geckodriver locally:
4949
5050
$ vendor/bin/bdi detect drivers
5151
52-
Panther will detect and use automatically drivers stored in the ``drivers/`` directory
52+
Panther will detect and automatically use drivers stored in the ``drivers/`` directory
5353
of your project when installing them manually. You can download `ChromeDriver`_
54-
for Chromium or Chromeand `GeckoDriver`_ for Firefox and put them anywhere in
54+
for Chromium or Chrome and `GeckoDriver`_ for Firefox and put them anywhere in
5555
your ``PATH`` or in the ``drivers/`` directory of your project.
5656

5757
Alternatively, you can use the package manager of your operating system
@@ -132,7 +132,7 @@ Creating a TestCase
132132
~~~~~~~~~~~~~~~~~~~
133133

134134
The ``PantherTestCase`` class allows you to write end-to-end tests. It
135-
automatically starts your app using the built-in PHP web server and let
135+
automatically starts your app using the built-in PHP web server and lets
136136
you crawl it using Panther. To provide all the testing tools you're used
137137
to, it extends `PHPUnit`_'s ``TestCase``.
138138

@@ -264,8 +264,7 @@ future::
264264
}
265265
}
266266

267-
You can then run this test by using PHPUnit, like you would do for any other
268-
test:
267+
You can then run this test using PHPUnit, like you would for any other test:
269268

270269
.. code-block:: terminal
271270
@@ -498,13 +497,13 @@ Having a Multi-domain Application
498497
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
499498

500499
It happens that your PHP/Symfony application might serve several different
501-
domain names. As Panther saves the Client in memory between tests to improve
500+
domain names. As Panther saves the client in memory between tests to improve
502501
performance, you will have to run your tests in separate
503502
processes if you write several tests using Panther for different domain names.
504503

505504
To do so, you can use the native ``@runInSeparateProcess`` PHPUnit annotation.
506505
Here is an example using the ``external_base_uri`` option to determine the
507-
domain name used by the Client when using separate processes::
506+
domain name used by the client when using separate processes::
508507

509508
// tests/FirstDomainTest.php
510509
namespace App\Tests;
@@ -792,7 +791,7 @@ The following features are not currently supported:
792791
* Selecting invalid choices in select
793792

794793
Also, there is a known issue if you are using Bootstrap 5. It implements a
795-
scrolling effect, which tends to mislead Panther. To fix this, we advise you to
794+
scrolling effect which tends to mislead Panther. To fix this, we advise you to
796795
deactivate this effect by setting the Bootstrap 5 ``$enable-smooth-scroll``
797796
variable to ``false`` in your style file:
798797

0 commit comments

Comments
 (0)