Fix quotes in exception messages

fabpot · fabpot · commit 2b5a266b4e9b · 2020-03-16T09:31:04.000+01:00
diff --git a/Encoder/XmlEncoder.php b/Encoder/XmlEncoder.php
@@ -412,7 +412,7 @@ private function buildXml(\DOMNode $parentNode, $data, $xmlRootNodeName = null)
 
         if (\is_object($data)) {
             if (null === $this->serializer) {
-                throw new BadMethodCallException(sprintf('The serializer needs to be set to allow %s() to be used with object data.', __METHOD__));
+                throw new BadMethodCallException(sprintf('The serializer needs to be set to allow "%s()" to be used with object data.', __METHOD__));
             }
 
             $data = $this->serializer->normalize($data, $this->format, $this->context);
@@ -490,7 +490,7 @@ private function selectNodeType(\DOMNode $node, $val)
             $this->buildXml($node, $val);
         } elseif (\is_object($val)) {
             if (null === $this->serializer) {
-                throw new BadMethodCallException(sprintf('The serializer needs to be set to allow %s() to be used with object data.', __METHOD__));
+                throw new BadMethodCallException(sprintf('The serializer needs to be set to allow "%s()" to be used with object data.', __METHOD__));
             }
 
             return $this->selectNodeType($node, $this->serializer->normalize($val, $this->format, $this->context));
diff --git a/Mapping/Loader/FileLoader.php b/Mapping/Loader/FileLoader.php
@@ -30,11 +30,11 @@ abstract class FileLoader implements LoaderInterface
     public function __construct($file)
     {
         if (!is_file($file)) {
-            throw new MappingException(sprintf('The mapping file %s does not exist.', $file));
+            throw new MappingException(sprintf('The mapping file "%s" does not exist.', $file));
         }
 
         if (!is_readable($file)) {
-            throw new MappingException(sprintf('The mapping file %s is not readable.', $file));
+            throw new MappingException(sprintf('The mapping file "%s" is not readable.', $file));
         }
 
         $this->file = $file;
diff --git a/Mapping/Loader/LoaderChain.php b/Mapping/Loader/LoaderChain.php
@@ -40,7 +40,7 @@ public function __construct(array $loaders)
     {
         foreach ($loaders as $loader) {
             if (!$loader instanceof LoaderInterface) {
-                throw new MappingException(sprintf('Class %s is expected to implement LoaderInterface.', \get_class($loader)));
+                throw new MappingException(sprintf('Class "%s" is expected to implement LoaderInterface.', \get_class($loader)));
             }
         }
 
diff --git a/Normalizer/AbstractNormalizer.php b/Normalizer/AbstractNormalizer.php
@@ -340,7 +340,7 @@ protected function instantiateObject(array &$data, $class, array &$context, \Ref
                 if (method_exists($constructorParameter, 'isVariadic') && $constructorParameter->isVariadic()) {
                     if ($allowed && !$ignored && (isset($data[$key]) || \array_key_exists($key, $data))) {
                         if (!\is_array($data[$paramName])) {
-                            throw new RuntimeException(sprintf('Cannot create an instance of %s from serialized data because the variadic parameter %s can only accept an array.', $class, $constructorParameter->name));
+                            throw new RuntimeException(sprintf('Cannot create an instance of "%s" from serialized data because the variadic parameter "%s" can only accept an array.', $class, $constructorParameter->name));
                         }
 
                         $variadicParameters = [];
@@ -366,7 +366,7 @@ protected function instantiateObject(array &$data, $class, array &$context, \Ref
                 } elseif ($constructorParameter->isDefaultValueAvailable()) {
                     $params[] = $constructorParameter->getDefaultValue();
                 } else {
-                    throw new RuntimeException(sprintf('Cannot create an instance of %s from serialized data because its constructor requires parameter "%s" to be present.', $class, $constructorParameter->name));
+                    throw new RuntimeException(sprintf('Cannot create an instance of "%s" from serialized data because its constructor requires parameter "%s" to be present.', $class, $constructorParameter->name));
                 }
             }
 
@@ -388,7 +388,7 @@ protected function denormalizeParameter(\ReflectionClass $class, \ReflectionPara
         try {
             if (null !== $parameter->getClass()) {
                 if (!$this->serializer instanceof DenormalizerInterface) {
-                    throw new LogicException(sprintf('Cannot create an instance of %s from serialized data because the serializer inject in "%s" is not a denormalizer.', $parameter->getClass(), static::class));
+                    throw new LogicException(sprintf('Cannot create an instance of "%s" from serialized data because the serializer inject in "%s" is not a denormalizer.', $parameter->getClass(), static::class));
                 }
                 $parameterClass = $parameter->getClass()->getName();
 
diff --git a/Normalizer/ArrayDenormalizer.php b/Normalizer/ArrayDenormalizer.php
@@ -69,7 +69,7 @@ public function denormalize($data, $type, $format = null, array $context = [])
     public function supportsDenormalization($data, $type, $format = null/*, array $context = []*/)
     {
         if (null === $this->serializer) {
-            throw new BadMethodCallException(sprintf('The serializer needs to be set to allow %s() to be used.', __METHOD__));
+            throw new BadMethodCallException(sprintf('The serializer needs to be set to allow "%s()" to be used.', __METHOD__));
         }
 
         $context = \func_num_args() > 3 ? func_get_arg(3) : [];
diff --git a/Normalizer/DateIntervalNormalizer.php b/Normalizer/DateIntervalNormalizer.php
@@ -67,7 +67,7 @@ public function supportsNormalization($data, $format = null)
     public function denormalize($data, $type, $format = null, array $context = [])
     {
         if (!\is_string($data)) {
-            throw new InvalidArgumentException(sprintf('Data expected to be a string, %s given.', \gettype($data)));
+            throw new InvalidArgumentException(sprintf('Data expected to be a string, "%s" given.', \gettype($data)));
         }
 
         if (!$this->isISO8601($data)) {
diff --git a/Serializer.php b/Serializer.php
@@ -109,7 +109,7 @@ public function __construct(array $normalizers = [], array $encoders = [])
     final public function serialize($data, $format, array $context = [])
     {
         if (!$this->supportsEncoding($format, $context)) {
-            throw new NotEncodableValueException(sprintf('Serialization for the format %s is not supported.', $format));
+            throw new NotEncodableValueException(sprintf('Serialization for the format "%s" is not supported.', $format));
         }
 
         if ($this->encoder->needsNormalization($format, $context)) {
@@ -125,7 +125,7 @@ final public function serialize($data, $format, array $context = [])
     final public function deserialize($data, $type, $format, array $context = [])
     {
         if (!$this->supportsDecoding($format, $context)) {
-            throw new NotEncodableValueException(sprintf('Deserialization for the format %s is not supported.', $format));
+            throw new NotEncodableValueException(sprintf('Deserialization for the format "%s" is not supported.', $format));
         }
 
         $data = $this->decode($data, $format, $context);
@@ -161,7 +161,7 @@ public function normalize($data, $format = null, array $context = [])
                 throw new LogicException('You must register at least one normalizer to be able to normalize objects.');
             }
 
-            throw new NotNormalizableValueException(sprintf('Could not normalize object of type %s, no supporting normalizer found.', \get_class($data)));
+            throw new NotNormalizableValueException(sprintf('Could not normalize object of type "%s", no supporting normalizer found.', \get_class($data)));
         }
 
         throw new NotNormalizableValueException(sprintf('An unexpected value could not be normalized: %s.', !\is_resource($data) ? var_export($data, true) : sprintf('%s resource', get_resource_type($data))));
@@ -182,7 +182,7 @@ public function denormalize($data, $type, $format = null, array $context = [])
             return $normalizer->denormalize($data, $type, $format, $context);
         }
 
-        throw new NotNormalizableValueException(sprintf('Could not denormalize object of type %s, no supporting normalizer found.', $type));
+        throw new NotNormalizableValueException(sprintf('Could not denormalize object of type "%s", no supporting normalizer found.', $type));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -412,7 +412,7 @@ private function buildXml(\DOMNode $parentNode, $data, $xmlRootNodeName = null)`
`412`	`412`
`413`	`413`	`if (\is_object($data)) {`
`414`	`414`	`if (null === $this->serializer) {`
`415`		`- throw new BadMethodCallException(sprintf('The serializer needs to be set to allow %s() to be used with object data.', __METHOD__));`
	`415`	`+ throw new BadMethodCallException(sprintf('The serializer needs to be set to allow "%s()" to be used with object data.', __METHOD__));`
`416`	`416`	`}`
`417`	`417`
`418`	`418`	`$data = $this->serializer->normalize($data, $this->format, $this->context);`
`@@ -490,7 +490,7 @@ private function selectNodeType(\DOMNode $node, $val)`
`490`	`490`	`$this->buildXml($node, $val);`
`491`	`491`	`} elseif (\is_object($val)) {`
`492`	`492`	`if (null === $this->serializer) {`
`493`		`- throw new BadMethodCallException(sprintf('The serializer needs to be set to allow %s() to be used with object data.', __METHOD__));`
	`493`	`+ throw new BadMethodCallException(sprintf('The serializer needs to be set to allow "%s()" to be used with object data.', __METHOD__));`
`494`	`494`	`}`
`495`	`495`
`496`	`496`	`return $this->selectNodeType($node, $this->serializer->normalize($val, $this->format, $this->context));`
Original file line number	Diff line number	Diff line change
`@@ -30,11 +30,11 @@ abstract class FileLoader implements LoaderInterface`
`30`	`30`	`public function __construct($file)`
`31`	`31`	`{`
`32`	`32`	`if (!is_file($file)) {`
`33`		`- throw new MappingException(sprintf('The mapping file %s does not exist.', $file));`
	`33`	`+ throw new MappingException(sprintf('The mapping file "%s" does not exist.', $file));`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`if (!is_readable($file)) {`
`37`		`- throw new MappingException(sprintf('The mapping file %s is not readable.', $file));`
	`37`	`+ throw new MappingException(sprintf('The mapping file "%s" is not readable.', $file));`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`$this->file = $file;`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function __construct(array $loaders)`
`40`	`40`	`{`
`41`	`41`	`foreach ($loaders as $loader) {`
`42`	`42`	`if (!$loader instanceof LoaderInterface) {`
`43`		`- throw new MappingException(sprintf('Class %s is expected to implement LoaderInterface.', \get_class($loader)));`
	`43`	`+ throw new MappingException(sprintf('Class "%s" is expected to implement LoaderInterface.', \get_class($loader)));`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,7 @@ protected function instantiateObject(array &$data, $class, array &$context, \Ref`
`340`	`340`	`if (method_exists($constructorParameter, 'isVariadic') && $constructorParameter->isVariadic()) {`
`341`	`341`	`if ($allowed && !$ignored && (isset($data[$key]) \|\| \array_key_exists($key, $data))) {`
`342`	`342`	`if (!\is_array($data[$paramName])) {`
`343`		`- throw new RuntimeException(sprintf('Cannot create an instance of %s from serialized data because the variadic parameter %s can only accept an array.', $class, $constructorParameter->name));`
	`343`	`+ throw new RuntimeException(sprintf('Cannot create an instance of "%s" from serialized data because the variadic parameter "%s" can only accept an array.', $class, $constructorParameter->name));`
`344`	`344`	`}`
`345`	`345`
`346`	`346`	`$variadicParameters = [];`
`@@ -366,7 +366,7 @@ protected function instantiateObject(array &$data, $class, array &$context, \Ref`
`366`	`366`	`} elseif ($constructorParameter->isDefaultValueAvailable()) {`
`367`	`367`	`$params[] = $constructorParameter->getDefaultValue();`
`368`	`368`	`} else {`
`369`		`- throw new RuntimeException(sprintf('Cannot create an instance of %s from serialized data because its constructor requires parameter "%s" to be present.', $class, $constructorParameter->name));`
	`369`	`+ throw new RuntimeException(sprintf('Cannot create an instance of "%s" from serialized data because its constructor requires parameter "%s" to be present.', $class, $constructorParameter->name));`
`370`	`370`	`}`
`371`	`371`	`}`
`372`	`372`
`@@ -388,7 +388,7 @@ protected function denormalizeParameter(\ReflectionClass $class, \ReflectionPara`
`388`	`388`	`try {`
`389`	`389`	`if (null !== $parameter->getClass()) {`
`390`	`390`	`if (!$this->serializer instanceof DenormalizerInterface) {`
`391`		`- throw new LogicException(sprintf('Cannot create an instance of %s from serialized data because the serializer inject in "%s" is not a denormalizer.', $parameter->getClass(), static::class));`
	`391`	`+ throw new LogicException(sprintf('Cannot create an instance of "%s" from serialized data because the serializer inject in "%s" is not a denormalizer.', $parameter->getClass(), static::class));`
`392`	`392`	`}`
`393`	`393`	`$parameterClass = $parameter->getClass()->getName();`
`394`	`394`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function denormalize($data, $type, $format = null, array $context = [])`
`69`	`69`	`public function supportsDenormalization($data, $type, $format = null/, array $context = []/)`
`70`	`70`	`{`
`71`	`71`	`if (null === $this->serializer) {`
`72`		`- throw new BadMethodCallException(sprintf('The serializer needs to be set to allow %s() to be used.', __METHOD__));`
	`72`	`+ throw new BadMethodCallException(sprintf('The serializer needs to be set to allow "%s()" to be used.', __METHOD__));`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`$context = \func_num_args() > 3 ? func_get_arg(3) : [];`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function supportsNormalization($data, $format = null)`
`67`	`67`	`public function denormalize($data, $type, $format = null, array $context = [])`
`68`	`68`	`{`
`69`	`69`	`if (!\is_string($data)) {`
`70`		`- throw new InvalidArgumentException(sprintf('Data expected to be a string, %s given.', \gettype($data)));`
	`70`	`+ throw new InvalidArgumentException(sprintf('Data expected to be a string, "%s" given.', \gettype($data)));`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`if (!$this->isISO8601($data)) {`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public function __construct(array $normalizers = [], array $encoders = [])`
`109`	`109`	`final public function serialize($data, $format, array $context = [])`
`110`	`110`	`{`
`111`	`111`	`if (!$this->supportsEncoding($format, $context)) {`
`112`		`- throw new NotEncodableValueException(sprintf('Serialization for the format %s is not supported.', $format));`
	`112`	`+ throw new NotEncodableValueException(sprintf('Serialization for the format "%s" is not supported.', $format));`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`if ($this->encoder->needsNormalization($format, $context)) {`
`@@ -125,7 +125,7 @@ final public function serialize($data, $format, array $context = [])`
`125`	`125`	`final public function deserialize($data, $type, $format, array $context = [])`
`126`	`126`	`{`
`127`	`127`	`if (!$this->supportsDecoding($format, $context)) {`
`128`		`- throw new NotEncodableValueException(sprintf('Deserialization for the format %s is not supported.', $format));`
	`128`	`+ throw new NotEncodableValueException(sprintf('Deserialization for the format "%s" is not supported.', $format));`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`$data = $this->decode($data, $format, $context);`
`@@ -161,7 +161,7 @@ public function normalize($data, $format = null, array $context = [])`
`161`	`161`	`throw new LogicException('You must register at least one normalizer to be able to normalize objects.');`
`162`	`162`	`}`
`163`	`163`
`164`		`- throw new NotNormalizableValueException(sprintf('Could not normalize object of type %s, no supporting normalizer found.', \get_class($data)));`
	`164`	`+ throw new NotNormalizableValueException(sprintf('Could not normalize object of type "%s", no supporting normalizer found.', \get_class($data)));`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`throw new NotNormalizableValueException(sprintf('An unexpected value could not be normalized: %s.', !\is_resource($data) ? var_export($data, true) : sprintf('%s resource', get_resource_type($data))));`
`@@ -182,7 +182,7 @@ public function denormalize($data, $type, $format = null, array $context = [])`
`182`	`182`	`return $normalizer->denormalize($data, $type, $format, $context);`
`183`	`183`	`}`
`184`	`184`
`185`		`- throw new NotNormalizableValueException(sprintf('Could not denormalize object of type %s, no supporting normalizer found.', $type));`
	`185`	`+ throw new NotNormalizableValueException(sprintf('Could not denormalize object of type "%s", no supporting normalizer found.', $type));`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`/**`