Enable "native_constant_invocation" CS rule

Author: nicolas-grekas

DeprecationErrorHandler.php

@@ -109,7 +109,7 @@ public static function register($mode = 0)
             'remaining vendor' => array(),
         );
         $deprecationHandler = function ($type, $msg, $file, $line, $context = array()) use (&$deprecations, $getMode, $UtilPrefix, $inVendors) {
-            if ((E_USER_DEPRECATED !== $type && E_DEPRECATED !== $type && (E_WARNING !== $type || false === strpos($msg, '" targeting switch is equivalent to "break'))) || DeprecationErrorHandler::MODE_DISABLED === $mode = $getMode()) {
+            if ((\E_USER_DEPRECATED !== $type && \E_DEPRECATED !== $type && (\E_WARNING !== $type || false === strpos($msg, '" targeting switch is equivalent to "break'))) || DeprecationErrorHandler::MODE_DISABLED === $mode = $getMode()) {
                 return \call_user_func(DeprecationErrorHandler::getPhpUnitErrorHandler(), $type, $msg, $file, $line, $context);
             }
 
@@ -285,7 +285,7 @@ public static function collectDeprecations($outputFile)
     {
         $deprecations = array();
         $previousErrorHandler = set_error_handler(function ($type, $msg, $file, $line, $context = array()) use (&$deprecations, &$previousErrorHandler) {
-            if (E_USER_DEPRECATED !== $type && E_DEPRECATED !== $type && (E_WARNING !== $type || false === strpos($msg, '" targeting switch is equivalent to "break'))) {
+            if (\E_USER_DEPRECATED !== $type && \E_DEPRECATED !== $type && (\E_WARNING !== $type || false === strpos($msg, '" targeting switch is equivalent to "break'))) {
                 if ($previousErrorHandler) {
                     return $previousErrorHandler($type, $msg, $file, $line, $context);
                 }
@@ -314,7 +314,7 @@ public static function getPhpUnitErrorHandler()
             return (class_exists('PHPUnit_Util_ErrorHandler', false) ? 'PHPUnit_Util_' : 'PHPUnit\Util\\').'ErrorHandler::handleError';
         }
 
-        foreach (debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT | DEBUG_BACKTRACE_IGNORE_ARGS) as $frame) {
+        foreach (debug_backtrace(\DEBUG_BACKTRACE_PROVIDE_OBJECT | \DEBUG_BACKTRACE_IGNORE_ARGS) as $frame) {
             if (isset($frame['object']) && $frame['object'] instanceof TestResult) {
                 return new ErrorHandler(
                     $frame['object']->getConvertDeprecationsToExceptions(),
@@ -348,21 +348,21 @@ private static function hasColorSupport()
 
         if (\DIRECTORY_SEPARATOR === '\\') {
             return (\function_exists('sapi_windows_vt100_support')
-                && sapi_windows_vt100_support(STDOUT))
+                && sapi_windows_vt100_support(\STDOUT))
                 || false !== getenv('ANSICON')
                 || 'ON' === getenv('ConEmuANSI')
                 || 'xterm' === getenv('TERM');
         }
 
         if (\function_exists('stream_isatty')) {
-            return stream_isatty(STDOUT);
+            return stream_isatty(\STDOUT);
         }
 
         if (\function_exists('posix_isatty')) {
-            return posix_isatty(STDOUT);
+            return posix_isatty(\STDOUT);
         }
 
-        $stat = fstat(STDOUT);
+        $stat = fstat(\STDOUT);
         // Check if formatted mode is S_IFCHR
         return $stat ? 0020000 === ($stat['mode'] & 0170000) : false;
     }

Tests/DnsMockTest.php

@@ -141,8 +141,8 @@ public function testDnsGetRecord()
 
         $this->assertFalse(DnsMock::dns_get_record('foobar.com'));
         $this->assertSame($records, DnsMock::dns_get_record('example.com'));
-        $this->assertSame($records, DnsMock::dns_get_record('example.com', DNS_ALL));
-        $this->assertSame($records, DnsMock::dns_get_record('example.com', DNS_A | DNS_PTR));
-        $this->assertSame(array($ptr), DnsMock::dns_get_record('example.com', DNS_PTR));
+        $this->assertSame($records, DnsMock::dns_get_record('example.com', \DNS_ALL));
+        $this->assertSame($records, DnsMock::dns_get_record('example.com', \DNS_A | \DNS_PTR));
+        $this->assertSame(array($ptr), DnsMock::dns_get_record('example.com', \DNS_PTR));
     }
 }

Tests/ExpectedDeprecationAnnotationTest.php

@@ -24,7 +24,7 @@ final class ExpectedDeprecationAnnotationTest extends TestCase
      */
     public function testOne()
     {
-        @trigger_error('foo', E_USER_DEPRECATED);
+        @trigger_error('foo', \E_USER_DEPRECATED);
     }
 
     /**
@@ -37,7 +37,7 @@ public function testOne()
      */
     public function testMany()
     {
-        @trigger_error('foo', E_USER_DEPRECATED);
-        @trigger_error('bar', E_USER_DEPRECATED);
+        @trigger_error('foo', \E_USER_DEPRECATED);
+        @trigger_error('bar', \E_USER_DEPRECATED);
     }
 }

Tests/ProcessIsolationTest.php

@@ -18,7 +18,7 @@ class ProcessIsolationTest extends TestCase
      */
     public function testIsolation()
     {
-        @trigger_error('Test abc', E_USER_DEPRECATED);
+        @trigger_error('Test abc', \E_USER_DEPRECATED);
         $this->addToAssertionCount(1);
     }
 
@@ -28,6 +28,6 @@ public function testCallingOtherErrorHandler()
         $this->expectException($class);
         $this->expectExceptionMessage('Test that PHPUnit\'s error handler fires.');
 
-        trigger_error('Test that PHPUnit\'s error handler fires.', E_USER_WARNING);
+        trigger_error('Test that PHPUnit\'s error handler fires.', \E_USER_WARNING);
     }
 }

bootstrap.php

@@ -25,7 +25,7 @@
 }
 
 // Enforce a consistent locale
-setlocale(LC_ALL, 'C');
+setlocale(\LC_ALL, 'C');
 
 if (!class_exists('Doctrine\Common\Annotations\AnnotationRegistry', false) && class_exists('Doctrine\Common\Annotations\AnnotationRegistry')) {
     if (method_exists('Doctrine\Common\Annotations\AnnotationRegistry', 'registerUniqueLoader')) {