You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #50885 [Finder] Fix children condition in ExcludeDirectoryFilterIterator (mvorisek)
This PR was merged into the 5.4 branch.
Discussion
----------
[Finder] Fix children condition in ExcludeDirectoryFilterIterator
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | no
| License | MIT
| Doc PR | no
see https://github.com/php/php-src/blob/6091603b5350c1ca0e792a6da604e25e2a0121c8/ext/spl/spl_directory.h#L113
Original `isDir` follow symlinks, so this PR has no effect, but it avoids expensive `isDir` call and makes the condition more correct.
Commits
-------
621f75f969 fix children cond
0 commit comments