Fixes from feedback

Author: weaverryan

src/BuildResult.php

@@ -15,14 +15,14 @@
 
 class BuildResult
 {
-    private $errors;
     private $builder;
+    private $errors;
     private $jsonResults = [];
 
-    public function __construct(array $errors, Builder $builder)
+    public function __construct(Builder $builder)
     {
-        $this->errors = $errors;
         $this->builder = $builder;
+        $this->errors = $builder->getErrorManager()->getErrors();
     }
 
     public function appendError(string $errorMessage): void
@@ -45,7 +45,7 @@ public function getErrors(): array
         return $this->errors;
     }
 
-    public function getMetas(): Metas
+    public function getMetadata(): Metas
     {
         return $this->builder->getMetas();
     }
@@ -54,18 +54,14 @@ public function getMetas(): Metas
      * Returns the "master document": the first file whose toctree is parsed.
      *
      * Unless customized, this is "index" (i.e. file index.rst).
-     *
-     * @return string
      */
     public function getMasterDocumentFilename(): string
     {
         return $this->builder->getIndexName();
     }
 
     /**
-     * Returns the JSON data generated for each file, keyed by the source filename.
-     *
-     * @return array[]
+     * Returns the JSON array data generated for each file, keyed by the source filename.
      */
     public function getJsonResults(): array
     {

src/DocBuilder.php

@@ -25,10 +25,7 @@ public function build(BuildConfig $config): BuildResult
         $builder = new Builder(KernelFactory::createKernel($config));
         $builder->build($config->getContentDir(), $config->getOutputDir());
 
-        $buildResult = new BuildResult(
-            $builder->getErrorManager()->getErrors(),
-            $builder
-        );
+        $buildResult = new BuildResult($builder);
 
         $missingFilesChecker = new MissingFilesChecker($config);
         $missingFiles = $missingFilesChecker->getMissingFiles();
@@ -41,7 +38,7 @@ public function build(BuildConfig $config): BuildResult
             $filesystem->dumpFile($config->getOutputDir().'/build_errors.txt', implode("\n", $buildResult->getErrors()));
         }
 
-        $metas = $buildResult->getMetas();
+        $metas = $buildResult->getMetadata();
         if ($config->getSubdirectoryToBuild()) {
             $htmlForPdfGenerator = new HtmlForPdfGenerator($metas, $config);
             $htmlForPdfGenerator->generateHtmlForPdf();

src/Generator/JsonGenerator.php

@@ -76,11 +76,6 @@ public function generateJson(string $masterDocument = 'index'): array
                 'toc' => $this->generateToc($metaEntry, current($metaEntry->getTitles())[1]),
                 'next' => $next,
                 'prev' => $prev,
-                'rellinks' => [
-                    // probably these shouldn't be straight copies of next/prev
-                    $next,
-                    $prev,
-                ],
                 'body' => $crawler->filter('body')->html(),
             ];
 

tests/fixtures/source/json/fields.rst

@@ -1,5 +1,5 @@
 Fields
 ======
 
-I love fields: big open prairies, grass fields, corn fields... reall,
+I love fields: big open prairies, grass fields, corn fields... really,
 any type of field, I'm a fan.