Support more associations (#107)

Nyholm · web-flow · commit ecf5677ecd57 · 2020-11-07T13:17:35.000+01:00
diff --git a/src/Subscriber/WelcomeFirstTimeContributorSubscriber.php b/src/Subscriber/WelcomeFirstTimeContributorSubscriber.php
@@ -26,7 +26,8 @@ public function onPullRequest(GitHubEvent $event)
             return;
         }
 
-        if ('NONE' !== ($data['pull_request']['author_association'] ?? '')) {
+        $association = $data['pull_request']['author_association'] ?? '';
+        if (!in_array($association, ['NONE', 'FIRST_TIMER', 'FIRST_TIME_CONTRIBUTOR'])) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,8 @@ public function onPullRequest(GitHubEvent $event)`
`26`	`26`	`return;`
`27`	`27`	`}`
`28`	`28`
`29`		`- if ('NONE' !== ($data['pull_request']['author_association'] ?? '')) {`
	`29`	`+ $association = $data['pull_request']['author_association'] ?? '';`
	`30`	`+ if (!in_array($association, ['NONE', 'FIRST_TIMER', 'FIRST_TIME_CONTRIBUTOR'])) {`
`30`	`31`	`return;`
`31`	`32`	`}`
`32`	`33`