Make sure symfony-docs also ignore target_branch === current version (#101)

* Make sure symfony-docs also ignore target_branch === current version

* Fixed typo

Author: Nyholm

config/services.yaml

@@ -21,7 +21,7 @@ parameters:
                 - 'App\Subscriber\NeedsReviewNewPRSubscriber'
                 - 'App\Subscriber\BugLabelNewIssueSubscriber'
                 - 'App\Subscriber\AutoLabelFromContentSubscriber'
-                - 'App\Subscriber\MilestoneNewPRSubscriber'
+                - 'subscriber.symfony_docs.milestone'
             secret: '%env(SYMFONY_DOCS_SECRET)%'
 
         # used in a functional test
@@ -78,3 +78,8 @@ services:
         arguments: [ '%repositories%' ]
 
     App\Repository\Provider\RepositoryProviderInterface: '@App\Repository\Provider\InMemoryRepositoryProvider'
+
+    subscriber.symfony_docs.milestone:
+        class: App\Subscriber\MilestoneNewPRSubscriber
+        arguments:
+            $ignoreCurrentVersion: true

src/Service/SymfonyVersionProvider.php

@@ -0,0 +1,48 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Service;
+
+use Symfony\Contracts\Cache\CacheInterface;
+use Symfony\Contracts\Cache\ItemInterface;
+use Symfony\Contracts\HttpClient\HttpClientInterface;
+
+class SymfonyVersionProvider
+{
+    /**
+     * @var HttpClientInterface
+     */
+    private $httpClient;
+
+    /**
+     * @var CacheInterface
+     */
+    private $cache;
+
+    public function __construct(HttpClientInterface $httpClient, CacheInterface $cache)
+    {
+        $this->httpClient = $httpClient;
+        $this->cache = $cache;
+    }
+
+    public function getCurrentVersion()
+    {
+        $httpClient = $this->httpClient;
+
+        return $this->cache->get('symfony_version', function (ItemInterface $item) use ($httpClient) {
+            $defaultValue = '99.99';
+            try {
+                $response = $httpClient->request('GET', 'https://symfony.com/releases.json');
+                $data = $response->toArray(true);
+                $version = $data['latest_stable_version'] ?? $defaultValue;
+            } catch (\Throwable $e) {
+                $version = $defaultValue;
+            }
+
+            $item->expiresAfter($version === $defaultValue ? 300 : 604800);
+
+            return $version;
+        });
+    }
+}

src/Subscriber/MilestoneNewPRSubscriber.php

@@ -5,6 +5,7 @@
 use App\Event\GitHubEvent;
 use App\GitHubEvents;
 use App\Issues\GitHub\MilestonesApi;
+use App\Service\SymfonyVersionProvider;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 
 /**
@@ -13,10 +14,14 @@
 class MilestoneNewPRSubscriber implements EventSubscriberInterface
 {
     private $milestonesApi;
+    private $symfonyVersionProvider;
+    private $ignoreCurrentVersion;
 
-    public function __construct(MilestonesApi $milestonesApi)
+    public function __construct(MilestonesApi $milestonesApi, SymfonyVersionProvider $symfonyVersionProvider, $ignoreCurrentVersion = false)
     {
         $this->milestonesApi = $milestonesApi;
+        $this->symfonyVersionProvider = $symfonyVersionProvider;
+        $this->ignoreCurrentVersion = $ignoreCurrentVersion;
     }
 
     /**
@@ -35,6 +40,10 @@ public function onPullRequest(GitHubEvent $event)
             return;
         }
 
+        if ($this->ignoreCurrentVersion && $targetBranch === $this->symfonyVersionProvider->getCurrentVersion()) {
+            return;
+        }
+
         if (!$this->milestonesApi->exists($repository, $targetBranch)) {
             return;
         }

tests/Subscriber/MilestoneNewPRSubscriberTest.php

@@ -6,6 +6,7 @@
 use App\GitHubEvents;
 use App\Issues\GitHub\MilestonesApi;
 use App\Repository\Repository;
+use App\Service\SymfonyVersionProvider;
 use App\Subscriber\MilestoneNewPRSubscriber;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\EventDispatcher\EventDispatcher;
@@ -26,7 +27,12 @@ class MilestoneNewPRSubscriberTest extends TestCase
     protected function setUp()
     {
         $this->milestonesApi = $this->createMock(MilestonesApi::class);
-        $this->subscriber = new MilestoneNewPRSubscriber($this->milestonesApi);
+        $symfonyVersionProvider = $this->getMockBuilder(SymfonyVersionProvider::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['getCurrentVersion'])
+            ->getMock();
+        $symfonyVersionProvider->method('getCurrentVersion')->willReturn('5.1');
+        $this->subscriber = new MilestoneNewPRSubscriber($this->milestonesApi, $symfonyVersionProvider);
         $this->repository = new Repository('nyholm', 'symfony', null);
 
         $this->dispatcher = new EventDispatcher();