Use the account public key to retrieve account metadata for better performance

[Wayonb]

When address is use as the account id(/metadata/account/

), rest has to resolve the address to a public key. This look up is an extra DB query before actually getting the metadata for the account which can be prevented by just sending rest the account's public key.

This is for all the account meta calls.

https://github.com/nemtech/symbol-sdk-typescript-javascript/blob/bf0ba0a6ebc0a4d49b3d7747b48751110c0dbbb3/src/infrastructure/MetadataRepository.ts#L36

[rg911]

This is the definition provided by openAPI, I guess we can change it to public key. @Vektrat ?

[Vektrat]

every endpoint that accepts account works like this... with the updates we are making now we will be removing this because it has some issues:

• extra call as mentioned
• can't always find the resource in the blockchain
• in terms of implementation we are not happy with a variable/param/resource that has two different meanings/types

[Wayonb]

The current implementation can accept either public key or address as the accountid. You can make the change now or later. I guess since there will be new endpoints this can wait.

https://github.com/nemtech/catapult-rest/blob/ccb30c1b727f02a613a7d68e98ff01aa397a75bb/rest/src/plugins/metadata/metadataRoutes.js#L85