Fixed #470

- Added s-part in transaction hash

Author: rg911

src/model/transaction/Transaction.ts

@@ -138,11 +138,11 @@ export abstract class Transaction {
             TransactionType.AGGREGATE_COMPLETE,
         ].find((type: TransactionType) => entityType === type) !== undefined;
 
-        // 1) take "R" part of a signature (first 32 bytes)
-        const signatureR: Uint8Array = transactionBytes.slice(8, 8 + 32);
+        // 1) add full signature
+        const signature: Uint8Array = transactionBytes.slice(8, 8 + 64);
 
         // 2) add public key to match sign/verify behavior (32 bytes)
-        const pubKeyIdx: number = signatureR.length;
+        const pubKeyIdx: number = signature.length;
         const publicKey: Uint8Array = transactionBytes.slice(8 + 64, 8 + 64 + 32);
 
         // 3) add generationHash (32 bytes)
@@ -162,12 +162,12 @@ export abstract class Transaction {
         // 5) concatenate binary hash parts
         // layout: `signature_R || signerPublicKey || generationHash || EntityDataBuffer`
         const entityHashBytes: Uint8Array = new Uint8Array(
-            signatureR.length
+            signature.length
           + publicKey.length
           + generationHash.length
           + transactionBody.length,
         );
-        entityHashBytes.set(signatureR, 0);
+        entityHashBytes.set(signature, 0);
         entityHashBytes.set(publicKey, pubKeyIdx);
         entityHashBytes.set(generationHash, generationHashIdx);
         entityHashBytes.set(transactionBody, transactionBodyIdx);

test/model/transaction/Transaction.spec.ts

@@ -255,7 +255,7 @@ describe('Transaction', () => {
         );
 
         // expected values
-        const knownHash_sha3 = '709373248659274C5933BEA2920942D6C7B48B9C2DA4BAEE233510E71495931F';
+        const knownHash_sha3 = 'F0F5A62A0863D45E832B50EFF4E2F68157268A5D1674EC1068D82EC5F88D950B';
         const generationHashBytes = Array.from(Convert.hexToUint8('988C4CDCE4D188013C13DE7914C7FD4D626169EF256722F61C52EFBE06BD5A2C'));
         const generationHashBytes_mt = Array.from(Convert.hexToUint8('17FA4747F5014B50413CCF968749604D728D7065DC504291EEE556899A534CBB'));