Skip to content

Commit a6c7dcd

Browse files
rg911haryu703
andauthored
0.23.1 release (#756)
* fix import path (#748) (#749) Co-authored-by: haryu703 <[email protected]> * Added from / to height in receipt search (#750) * Notification multisig (#752) * - Subscribe multisig account from cosigner subscription - Fixed #751 * Lint fix * 0.23.1 release (#755) * 0.23.1 release node * updated versions Co-authored-by: haryu703 <[email protected]>
1 parent 63e8a82 commit a6c7dcd

15 files changed

+277
-60
lines changed

CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,18 @@ All notable changes to this project will be documented in this file.
44

55
The changelog format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
66

7+
## [0.23.1] - 02-Feb-2021
8+
9+
**Milestone**: Catapult-server main(0.10.0.6)
10+
Package | Version | Link
11+
---|---|---
12+
SDK Core| v0.23.1 | [symbol-sdk](https://www.npmjs.com/package/symbol-sdk)
13+
Catbuffer | v0.1.1 | [catbuffer-typescript](https://www.npmjs.com/package/catbuffer-typescript)
14+
Client Library | v0.11.1 | [symbol-openapi-typescript-fetch-client](https://www.npmjs.com/package/symbol-openapi-typescript-fetch-client)
15+
16+
- Added `FromHeight` and `ToHeight` filters in `Receipt` search endpoint.
17+
- Added optional parameter in websocket listener channels to automatically subscribe multisig account for cosigners.
18+
719
## [0.23.0] - 14-Jan-2021
820

921
**Milestone**: Catapult-server main(0.10.0.5)

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,9 @@ The Symbol SDK for TypeScript / JavaScript allows you to develop web, mobile, an
99

1010
## Important Notes
1111

12-
### _Catapult-Server_ Network Compatibility ([email protected].4)
12+
### _Catapult-Server_ Network Compatibility ([email protected].6)
1313

14-
Due to a network upgrade with [catapult-server](https://github.com/nemtech/catapult-server/releases/tag/v0.10.0.4) version, **it is recommended to use this package's 0.23.0 version and upwards to use this package with Fushicho versioned networks**.
15-
16-
The upgrade to this package's [version v0.23.0](https://github.com/nemtech/symbol-sdk-typescript-javascript/releases/tag/v0.23.0) is mandatory for the latest **_Catapult-Server_ compatibility**.
14+
Symbol network pre-launch [catapult-server](https://github.com/nemtech/catapult-server/releases/tag/v0.10.0.6), **it is recommended to use this package's 0.23.1 version and upwards for the upcoming pre-release versions and final release**.
1715

1816
Find the complete release notes [here](CHANGELOG.md).
1917

e2e/infrastructure/Listener.spec.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,24 @@ describe('Listener', () => {
376376
});
377377
});
378378

379+
describe('Aggregate Bonded Transactions - multisig other cosigner', () => {
380+
it('aggregateBondedTransactionsAdded', (done) => {
381+
const signedAggregatedTx = createSignedAggregatedBondTransaction(multisigAccount, account, account2.address);
382+
createHashLockTransactionAndAnnounce(signedAggregatedTx, account, helper.networkCurrency);
383+
helper.listener.aggregateBondedAdded(account2.address).subscribe(() => {
384+
done();
385+
});
386+
helper.listener.confirmed(unresolvedAddress).subscribe(() => {
387+
transactionRepository.announceAggregateBonded(signedAggregatedTx);
388+
});
389+
helper.listener.status(unresolvedAddress).subscribe((error) => {
390+
console.log('Error:', error);
391+
assert(false);
392+
done();
393+
});
394+
});
395+
});
396+
379397
describe('MultisigAccountModificationTransaction - Restore multisig Accounts', () => {
380398
it('Restore Multisig Account', () => {
381399
const removeCosigner1 = MultisigAccountModificationTransaction.create(

e2e/infrastructure/TransactionHttp.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ describe('TransactionHttp', () => {
102102
let transactionRepository: TransactionRepository;
103103
let transactionStatusRepository: TransactionStatusRepository;
104104
let votingKey: string;
105-
let votingKeyV1: string;
106105

107106
const remoteAccount = Account.generateNewAccount(helper.networkType);
108107

@@ -117,7 +116,6 @@ describe('TransactionHttp', () => {
117116
generationHash = helper.generationHash;
118117
networkType = helper.networkType;
119118
votingKey = Convert.uint8ToHex(Crypto.randomBytes(32));
120-
votingKeyV1 = Convert.uint8ToHex(Crypto.randomBytes(48));
121119
namespaceRepository = helper.repositoryFactory.createNamespaceRepository();
122120
transactionRepository = helper.repositoryFactory.createTransactionRepository();
123121
transactionStatusRepository = helper.repositoryFactory.createTransactionStatusRepository();

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
"ripemd160": "^2.0.2",
114114
"rxjs": "^6.6.3",
115115
"rxjs-compat": "^6.6.3",
116-
"symbol-openapi-typescript-fetch-client": "0.11.1",
116+
"symbol-openapi-typescript-fetch-client": "0.11.2",
117117
"tweetnacl": "^1.0.3",
118118
"ws": "^7.3.1"
119119
},

src/infrastructure/IListener.ts

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,11 @@ export interface IListener {
7474
*
7575
* @param unresolvedAddress unresolved address we listen when a transaction is in confirmed state
7676
* @param transactionHash transactionHash for filtering multiple transactions
77+
* @param subscribeMultisig When `true` cosigner's multisig account will also be subscribed to the channel
7778
* @return an observable stream of Transaction with state confirmed
7879
*/
7980

80-
confirmed(unresolvedAddress: UnresolvedAddress, transactionHash?: string): Observable<Transaction>;
81+
confirmed(unresolvedAddress: UnresolvedAddress, transactionHash?: string, subscribeMultisig?: boolean): Observable<Transaction>;
8182

8283
/**
8384
* Returns an observable stream of Transaction for a specific address.
@@ -86,9 +87,10 @@ export interface IListener {
8687
*
8788
* @param unresolvedAddress unresolved address we listen when a transaction is in unconfirmed state
8889
* @param transactionHash transactionHash for filtering multiple transactions
90+
* @param subscribeMultisig When `true` cosigner's multisig account will also be subscribed to the channel
8991
* @return an observable stream of Transaction with state unconfirmed
9092
*/
91-
unconfirmedAdded(unresolvedAddress: UnresolvedAddress, transactionHash?: string): Observable<Transaction>;
93+
unconfirmedAdded(unresolvedAddress: UnresolvedAddress, transactionHash?: string, subscribeMultisig?: boolean): Observable<Transaction>;
9294

9395
/**
9496
* Returns an observable stream of Transaction Hashes for specific address.
@@ -97,9 +99,10 @@ export interface IListener {
9799
*
98100
* @param unresolvedAddress unresolved address we listen when a transaction is removed from unconfirmed state
99101
* @param transactionHash the transaction hash filter.
102+
* @param subscribeMultisig When `true` cosigner's multisig account will also be subscribed to the channel
100103
* @return an observable stream of Strings with the transaction hash
101104
*/
102-
unconfirmedRemoved(unresolvedAddress: UnresolvedAddress, transactionHash?: string): Observable<string>;
105+
unconfirmedRemoved(unresolvedAddress: UnresolvedAddress, transactionHash?: string, subscribeMultisig?: boolean): Observable<string>;
103106

104107
/**
105108
* Return an observable of {@link AggregateTransaction} for specific address.
@@ -108,9 +111,14 @@ export interface IListener {
108111
*
109112
* @param unresolvedAddress unresolved address we listen when a transaction with missing signatures state
110113
* @param transactionHash transactionHash for filtering multiple transactions
114+
* @param subscribeMultisig When `true` cosigner's multisig account will also be subscribed to the channel
111115
* @return an observable stream of AggregateTransaction with missing signatures state
112116
*/
113-
aggregateBondedAdded(unresolvedAddress: UnresolvedAddress, transactionHash?: string): Observable<AggregateTransaction>;
117+
aggregateBondedAdded(
118+
unresolvedAddress: UnresolvedAddress,
119+
transactionHash?: string,
120+
subscribeMultisig?: boolean,
121+
): Observable<AggregateTransaction>;
114122

115123
/**
116124
* Returns an observable stream of Transaction Hashes for specific address.
@@ -119,9 +127,10 @@ export interface IListener {
119127
*
120128
* @param unresolvedAddress unresolved address we listen when a transaction is confirmed or rejected
121129
* @param transactionHash the transaction hash filter.
130+
* @param subscribeMultisig When `true` cosigner's multisig account will also be subscribed to the channel
122131
* @return an observable stream of Strings with the transaction hash
123132
*/
124-
aggregateBondedRemoved(unresolvedAddress: UnresolvedAddress, transactionHash?: string): Observable<string>;
133+
aggregateBondedRemoved(unresolvedAddress: UnresolvedAddress, transactionHash?: string, subscribeMultisig?: boolean): Observable<string>;
125134

126135
/**
127136
* Returns an observable stream of {@link TransactionStatusError} for specific address.
@@ -140,7 +149,8 @@ export interface IListener {
140149
* it emits a new message with the cosignatory signed transaction in the even stream.
141150
*
142151
* @param unresolvedAddress unresolved address we listen when a cosignatory is added to some transaction address sent
152+
* @param subscribeMultisig When `true` cosigner's multisig account will also be subscribed to the channel
143153
* @return an observable stream of {@link CosignatureSignedTransaction}
144154
*/
145-
cosignatureAdded(unresolvedAddress: UnresolvedAddress): Observable<CosignatureSignedTransaction>;
155+
cosignatureAdded(unresolvedAddress: UnresolvedAddress, subscribeMultisig?: boolean): Observable<CosignatureSignedTransaction>;
146156
}

0 commit comments

Comments
 (0)