Skip to content

Commit 251a00a

Browse files
authored
Fixed #614 (#615)
- Added missing chain properties - Updated openAPI fetch client version
1 parent 7a8ffe6 commit 251a00a

File tree

6 files changed

+19
-4
lines changed

6 files changed

+19
-4
lines changed

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
"ripemd160": "^2.0.2",
100100
"rxjs": "^6.5.3",
101101
"rxjs-compat": "^6.5.3",
102-
"symbol-openapi-typescript-fetch-client": "0.9.3-1",
102+
"symbol-openapi-typescript-fetch-client": "0.9.4",
103103
"tweetnacl": "^1.0.3",
104104
"utf8": "^3.0.0",
105105
"ws": "^7.2.3"

src/infrastructure/NetworkHttp.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,9 @@ export class NetworkHttp extends Http implements NetworkRepository {
165165
dto.chain.minHarvesterBalance,
166166
dto.chain.maxHarvesterBalance,
167167
dto.chain.minVoterBalance,
168+
dto.chain.maxVotingKeysPerAccount,
169+
dto.chain.minVotingKeyLifetime,
170+
dto.chain.maxVotingKeyLifetime,
168171
dto.chain.harvestBeneficiaryPercentage,
169172
dto.chain.harvestNetworkPercentage,
170173
dto.chain.harvestNetworkFeeSinkAddress,

src/model/network/ChainProperties.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ export class ChainProperties {
3838
* @param minHarvesterBalance - Minimum number of harvesting mosaic atomic units needed for an account to be eligible for harvesting.
3939
* @param maxHarvesterBalance - Maximum number of harvesting mosaic atomic units needed for an account to be eligible for harvesting.
4040
* @param minVoterBalance - Minimum number of harvesting mosaic atomic units needed for an account to be eligible for voting.
41+
* @param maxVotingKeysPerAccount - Maximum number of voting keys that can be registered at once per account.
42+
* @param minVotingKeyLifetime - Minimum number of finalization rounds for which voting key can be registered.
43+
* @param maxVotingKeyLifetime - Maximum number of finalization rounds for which voting key can be registered.
4144
* @param harvestBeneficiaryPercentage - Percentage of the harvested fee that is collected by the beneficiary account.
4245
* @param harvestNetworkPercentage - Percentage of the harvested fee that is collected by network.
4346
* @param harvestNetworkFeeSinkAddress - The harvest network fee sink address.
@@ -65,6 +68,9 @@ export class ChainProperties {
6568
public readonly minHarvesterBalance?: string,
6669
public readonly maxHarvesterBalance?: string,
6770
public readonly minVoterBalance?: string,
71+
public readonly maxVotingKeysPerAccount?: string,
72+
public readonly minVotingKeyLifetime?: string,
73+
public readonly maxVotingKeyLifetime?: string,
6874
public readonly harvestBeneficiaryPercentage?: string,
6975
public readonly harvestNetworkPercentage?: string,
7076
public readonly harvestNetworkFeeSinkAddress?: string,

test/infrastructure/NetworkHttp.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,9 @@ describe('NetworkHttp', () => {
145145
totalChainImportance: "15'000'000",
146146
minHarvesterBalance: '500',
147147
minVoterBalance: '500',
148+
maxVotingKeysPerAccount: '3',
149+
minVotingKeyLifetime: '72',
150+
maxVotingKeyLifetime: '26280',
148151
maxHarvesterBalance: "50'000'000'000'000",
149152
harvestBeneficiaryPercentage: '10',
150153
harvestNetworkPercentage: '5',

test/resource/TestResources.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ export const getDummyNetworkProperties = (): any => {
2828
"minHarvesterBalance": "500",
2929
"maxHarvesterBalance": "50'000'000'000'000",
3030
"minVoterBalance": "50'000",
31+
"maxVotingKeysPerAccount": "3",
32+
"minVotingKeyLifetime": "72",
33+
"maxVotingKeyLifetime": "26280",
3134
"harvestBeneficiaryPercentage": "10",
3235
"harvestNetworkPercentage": "5",
3336
"harvestNetworkFeeSinkAddress": "TDGY4DD2U4YQQGERFMDQYHPYS6M7LHIF6XUCJ4Q",

0 commit comments

Comments
 (0)