experiments with IntelliJ 2017.1.3

Author: sylvainlaurent

README.md

@@ -224,4 +224,7 @@ External annotations support | :white_check_mark: using .eea files | :white_che
 External annotations provided for common libraries | :red_circle: community effort with [lastnpe.org](http://lastnpe.org)| :white_check_mark: JDK, Guava | :white_check_mark: JDK
 IDE support to create external annotations | :white_check_mark: | :warning: using command line tools | :white_check_mark:
 Treat all types as @Nonnull by default, unless annotated wih @Nullable | :white_check_mark: using @NonNullByDefault for each package, allows to define the scope: field, parameters, return, generic types, etc... | :white_check_mark: by default, customizable with @DefaultQualifier | :white_check_mark: IDE setting :question: global?
-@Polynull support | :red_circle: | :white_check_mark: using [@PolyNull](https://checkerframework.org/manual/#qualifier-polymorphism) | :white_check_mark: using [@Contract](https://www.jetbrains.com/help/idea/2017.1/contract-annotations.html), for instance @Contract("!null->!null;null->null")
+@Polynull support | :red_circle: | :white_check_mark: using [@PolyNull](https://checkerframework.org/manual/#qualifier-polymorphism) | :white_check_mark: using [@Contract](https://www.jetbrains.com/help/idea/2017.1/contract-annotations.html), for instance @Contract("!null->!null;null->null")
+Method contract support (e.g. handle ``if(StringUtils.hasText(str)) {str...}`` | :red_circle: | :question: | :white_check_mark: using @Contract
+Automatic inference of nullability constraints in external libraries | :red_circle: | :red_circle: | :white_check_mark: for @NonNull and some @Contract. [Disabled for @Nullable due to too many false positives](https://youtrack.jetbrains.com/issue/IDEA-130063)
+Treat main, test or generated sources differently | :warning: not in IDE, unless ignoring all non-fatal errors for a source folder| :white_check_mark: | :white_check_mark:

ide-settings/eclipse-with-npe-analysis/org.eclipse.jdt.core.prefs

@@ -60,7 +60,7 @@ org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error
 org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning
 org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
 org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
-org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=warning
+org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=error
 org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore
 org.eclipse.jdt.core.compiler.problem.potentialNullReference=error
 org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore

src/main/java/packageNotAnnotated/IntelliJNullabilityTest.java

@@ -0,0 +1,60 @@
+package packageNotAnnotated;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.eclipse.jdt.annotation.NonNull;
+import org.eclipse.jdt.annotation.Nullable;
+
+/**
+ * Created by slaurent on 16.05.17.
+ */
+public class IntelliJNullabilityTest {
+
+    public static void test() {
+        MyClass<String> my = new MyClass<>();
+
+        my.echo(null);
+
+        MyNonNullGenericClass<@NonNull String> toto = new MyNonNullGenericClass<>();
+        System.out.println(toto);
+
+        // IntelliJ bug : should complain
+        MyNonNullGenericClass<@Nullable String> titi = new MyNonNullGenericClass<>();
+        System.out.println(titi);
+
+        MyNullableGenericClass<String> t1 = new MyNullableGenericClass<>();
+        MyNullableGenericClass<@NonNull String> t2 = new MyNullableGenericClass<>();
+        MyNullableGenericClass<@Nullable String> t3 = new MyNullableGenericClass<>();
+
+    }
+
+    public static <T extends @Nullable CharSequence> void typeArgumentNonNullExplicit(T t) {
+        System.out.println(t.hashCode());
+        MyClass<T> my = new MyClass<>();
+
+        my.echo(null);
+
+    }
+
+    static class MyClass<E> {
+        private List<E> objs = new ArrayList<>();
+
+        public void echo(E e) {
+            objs.add(e);
+
+            @NonNull
+            List<@NonNull String> list = new ArrayList<>();
+            list.add(null); // null warning here
+        }
+
+    }
+
+    static class MyNonNullGenericClass<@NonNull T extends @NonNull Object> {
+
+    }
+
+    static class MyNullableGenericClass<@Nullable T extends @Nullable Object> {
+
+    }
+}