wip eclipse 4.7

Author: sylvainlaurent

src/main/java/packageNotAnnotated/IntelliJNullabilityTest.java

@@ -19,7 +19,7 @@ public static void test() {
         MyNonNullGenericClass<@NonNull String> toto = new MyNonNullGenericClass<>();
         System.out.println(toto);
 
-        // IntelliJ bug : should complain
+        // should complain
         MyNonNullGenericClass<@Nullable String> titi = new MyNonNullGenericClass<>();
         System.out.println(titi);
 

src/main/java/test/EverythingNonNullByDefault.java

@@ -69,9 +69,7 @@ public static <T> T typeArgument(List<T> l) {
     @NonNullByDefault({ PARAMETER, RETURN_TYPE, FIELD, TYPE_BOUND, TYPE_ARGUMENT, TYPE_PARAMETER })
     public static <T> T typeArgumentNonNull(List<T> l) {
         l.add(null);
-        // #Eclipse 4.6.3 bug?# we should have no error because
-        // @NonNullByDefault with TYPE_PARAMETER should treat T as @Nonnull and
-        // therefore l.get(0) too
+
         l.get(0).toString();
         return l.get(0);
     }
@@ -118,7 +116,7 @@ public static void apply() {
         if (o.city != null) {
             o.setName("foo");
             // now "syntactic null analysis for fields" is not applied because
-            // there was a satement between the test for nullability of the
+            // there was a statement between the test for nullability of the
             // field and its usage. Eclipse has no means to know that setName()
             // did not modify the city field
             o.city.toString();

src/main/java/test/UseSpringWithExternalAnnotations.java

@@ -1,7 +1,11 @@
 package test;
 
+import static org.eclipse.jdt.annotation.DefaultLocation.TYPE_PARAMETER;
+
 import java.util.Collection;
+import java.util.List;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.springframework.util.CollectionUtils;
 
 public class UseSpringWithExternalAnnotations {
@@ -10,4 +14,18 @@ public void useSpring() {
         Collection<String> strs = null;
         CollectionUtils.isEmpty(strs);
     }
+
+    @NonNullByDefault({ TYPE_PARAMETER })
+    public static <T> void typeArgumentNonNull(List<T> l) {
+        l.get(0);
+        l.get(0).toString();
+    }
+
+    class X {
+        @NonNullByDefault(TYPE_PARAMETER)
+        <T> T identity(T t) {
+            return null;
+        }
+    }
+
 }