Merge pull request #82009 from ktoso/wip-fix-computed-variables-arm64-protocol-dist

Author: ktoso

lib/IRGen/GenMeta.cpp

@@ -273,10 +273,11 @@ static Flags getMethodDescriptorFlags(ValueDecl *fn) {
       return {Flags::Kind::ModifyCoroutine, false};
     case AccessorKind::Modify2:
       return {Flags::Kind::ModifyCoroutine, true};
+    case AccessorKind::DistributedGet:
+      return {Flags::Kind::Getter, false};
 #define OPAQUE_ACCESSOR(ID, KEYWORD)
 #define ACCESSOR(ID) \
     case AccessorKind::ID:
-    case AccessorKind::DistributedGet:
 #include "swift/AST/AccessorKinds.def"
       llvm_unreachable("these accessors never appear in protocols or v-tables");
     }
@@ -1069,13 +1070,6 @@ namespace {
       }
 
       for (auto &entry : pi.getWitnessEntries()) {
-        if (entry.isFunction() &&
-            entry.getFunction().getDecl()->isDistributedGetAccessor()) {
-          // We avoid emitting _distributed_get accessors, as they cannot be
-          // referred to anyway
-          continue;
-        }
-
         if (Resilient) {
           if (entry.isFunction()) {
             // Define the method descriptor.

test/Distributed/Runtime/distributed_actor_localSystem_distributedProtocol.swift

@@ -3,6 +3,11 @@
 // RUN: %target-codesign %t/a.out
 // RUN: %target-run %t/a.out | %FileCheck %s --color
 
+// Run again with library evolution:
+// RUN: %target-build-swift -module-name main -j2 -parse-as-library -enable-library-evolution -I %t %s -plugin-path %swift-plugin-dir -o %t/evo.out
+// RUN: %target-codesign %t/evo.out
+// RUN: %target-run %t/evo.out | %FileCheck %s --color
+
 // REQUIRES: executable_test
 // REQUIRES: concurrency
 // REQUIRES: distributed
@@ -14,9 +19,6 @@
 // rdar://90373022
 // UNSUPPORTED: OS=watchos
 
-// rdar://125628060
-// UNSUPPORTED: CPU=arm64e
- 
 import Distributed
 
 @Resolvable

test/Distributed/Runtime/distributed_actor_localSystem_distributedProtocol_variable.swift

@@ -3,6 +3,11 @@
 // RUN: %target-codesign %t/a.out
 // RUN: %target-run %t/a.out | %FileCheck %s --color
 
+// Run again with library evolution:
+// RUN: %target-build-swift -module-name main -j2 -parse-as-library -enable-library-evolution -I %t %s -plugin-path %swift-plugin-dir -o %t/evo.out
+// RUN: %target-codesign %t/evo.out
+// RUN: %target-run %t/evo.out | %FileCheck %s --color
+
 // REQUIRES: executable_test
 // REQUIRES: concurrency
 // REQUIRES: distributed
@@ -14,9 +19,6 @@
 // rdar://90373022
 // UNSUPPORTED: OS=watchos
 
-// rdar://125628060
-// UNSUPPORTED: CPU=arm64e
- 
 import Distributed
 
 @Resolvable

test/Distributed/Runtime/distributed_actor_localSystem_generic_system.swift

@@ -3,6 +3,11 @@
 // RUN: %target-codesign %t/a.out
 // RUN: %target-run %t/a.out | %FileCheck %s --color
 
+// Run again with library evolution:
+// RUN: %target-build-swift -module-name main -j2 -parse-as-library -enable-library-evolution -I %t %s -plugin-path %swift-plugin-dir -o %t/evo.out
+// RUN: %target-codesign %t/evo.out
+// RUN: %target-run %t/evo.out | %FileCheck %s --color
+
 // REQUIRES: executable_test
 // REQUIRES: concurrency
 // REQUIRES: distributed

test/Distributed/Runtime/distributed_actor_localSystem_manual_conformance.swift

@@ -3,6 +3,11 @@
 // RUN: %target-codesign %t/a.out
 // RUN: %target-run %t/a.out | %FileCheck %s --color
 
+// Run again with library evolution:
+// RUN: %target-build-swift -module-name main -j2 -parse-as-library -enable-library-evolution -I %t %s -plugin-path %swift-plugin-dir -o %t/evo.out
+// RUN: %target-codesign %t/evo.out
+// RUN: %target-run %t/evo.out | %FileCheck %s --color
+
 // REQUIRES: executable_test
 // REQUIRES: concurrency
 // REQUIRES: distributed
@@ -14,9 +19,6 @@
 // rdar://90373022
 // UNSUPPORTED: OS=watchos
 
-// rdar://125628060
-// UNSUPPORTED: CPU=arm64e
-
 import Distributed
 
 @available(SwiftStdlib 6.0, *)