Update port to macPort for Code Review suggestion

Author: Kyle-Ye

Documentation/Usage.md

@@ -160,7 +160,7 @@ print(options)
 ```
 
 To `import Clibgit`, the package manager requires that the libgit2 library has
-been installed by a system packager (eg. `apt`, `brew`, `port`, `yum`, `nuget`, etc.). The
+been installed by a system packager (eg. `apt`, `brew`, `macPort`, `yum`, `nuget`, etc.). The
 following files from the libgit2 system-package are of interest:
 
     /usr/local/lib/libgit2.dylib      # .so on Linux

Sources/PackageDescription/PackageDescription.docc/Curation/SystemPackageProvider.md

@@ -5,6 +5,6 @@
 ### Providing Hints to Users of System Packages
 
 - ``brew(_:)``
-- ``port(_:)``
+- ``macPort(_:)``
 - ``apt(_:)``
 - ``yum(_:)``

Sources/PackageDescription/PackageDescription.swift

@@ -379,7 +379,7 @@ public enum SystemPackageProvider {
     case brewItem([String])
     /// Packages installable by the MacPorts package manager.
     @available(_PackageDescription, introduced: 999.0)
-    case portItem([String])
+    case macPortItem([String])
     /// Packages installable by the apt-get package manager.
     case aptItem([String])
     /// Packages installable by the Yellowdog Updated, Modified (YUM) package manager.
@@ -405,8 +405,9 @@ public enum SystemPackageProvider {
     /// - Parameter packages: The list of package names.
     ///
     /// - Returns: A package provider.
-    public static func port(_ packages: [String]) -> SystemPackageProvider {
-        return .portItem(packages)
+    @available(_PackageDescription, introduced: 999.0)
+    public static func macPort(_ packages: [String]) -> SystemPackageProvider {
+        return .macPortItem(packages)
     }
 
     /// Creates a system package provider with a list of installable packages

Sources/PackageDescription/PackageDescriptionSerialization.swift

@@ -261,7 +261,7 @@ enum Serialization {
 
     enum SystemPackageProvider: Codable {
         case brew([String])
-        case port([String])
+        case macPort([String])
         case apt([String])
         case yum([String])
         case nuget([String])

Sources/PackageDescription/PackageDescriptionSerializationConversion.swift

@@ -387,7 +387,7 @@ extension Serialization.SystemPackageProvider {
     init(_ provider: PackageDescription.SystemPackageProvider) {
         switch provider {
         case .brewItem(let values): self = .brew(values)
-        case .portItem(let values): self = .port(values)
+        case .macPortItem(let values): self = .macPort(values)
         case .aptItem(let values): self = .apt(values)
         case .yumItem(let values): self = .yum(values)
         case .nugetItem(let values): self = .nuget(values)

Sources/PackageLoading/ManifestJSONParser.swift

@@ -259,8 +259,8 @@ extension SystemPackageProviderDescription {
         switch provider {
         case .brew(let values):
             self = .brew(values)
-        case .port(let values):
-            self = .port(values)
+        case .macPort(let values):
+            self = .macPort(values)
         case .apt(let values):
             self = .apt(values)
         case .yum(let values):

Sources/PackageLoading/Target+PkgConfig.swift

@@ -148,7 +148,7 @@ extension SystemPackageProviderDescription {
         switch self {
         case .brew(let packages):
             return "    brew install \(packages.joined(separator: " "))\n"
-        case .port(let packages):
+        case .macPort(let packages):
             return "    port install \(packages.joined(separator: " "))\n"
         case .apt(let packages):
             return "    apt-get install \(packages.joined(separator: " "))\n"
@@ -167,7 +167,7 @@ extension SystemPackageProviderDescription {
             if case .darwin = platform {
                 return true
             }
-        case .port:
+        case .macPort:
             if case .darwin = platform {
                 return true
             }
@@ -215,7 +215,7 @@ extension SystemPackageProviderDescription {
                 }
             }
             return try packages.map({ try AbsolutePath(validating: brewPrefix).appending(components: "opt", $0, "lib", "pkgconfig") })
-        case .port:
+        case .macPort:
             return [try AbsolutePath(validating: "/opt/local/lib/pkgconfig")]
         case .apt:
             return []

Sources/PackageModel/Manifest/SystemPackageProviderDescription.swift

@@ -13,15 +13,15 @@
 /// Represents system package providers.
 public enum SystemPackageProviderDescription: Equatable, Codable, Sendable {
     case brew([String])
-    case port([String])
+    case macPort([String])
     case apt([String])
     case yum([String])
     case nuget([String])
 }
 
 extension SystemPackageProviderDescription {
     private enum CodingKeys: String, CodingKey {
-        case brew, port, apt, yum, nuget
+        case brew, macPort, apt, yum, nuget
     }
 
     public func encode(to encoder: Encoder) throws {
@@ -30,8 +30,8 @@ extension SystemPackageProviderDescription {
         case let .brew(a1):
             var unkeyedContainer = container.nestedUnkeyedContainer(forKey: .brew)
             try unkeyedContainer.encode(a1)
-        case let .port(a1):
-            var unkeyedContainer = container.nestedUnkeyedContainer(forKey: .port)
+        case let .macPort(a1):
+            var unkeyedContainer = container.nestedUnkeyedContainer(forKey: .macPort)
             try unkeyedContainer.encode(a1)
         case let .apt(a1):
             var unkeyedContainer = container.nestedUnkeyedContainer(forKey: .apt)
@@ -55,10 +55,10 @@ extension SystemPackageProviderDescription {
             var unkeyedValues = try values.nestedUnkeyedContainer(forKey: key)
             let a1 = try unkeyedValues.decode([String].self)
             self = .brew(a1)
-        case .port:
+        case .macPort:
             var unkeyedValues = try values.nestedUnkeyedContainer(forKey: key)
             let a1 = try unkeyedValues.decode([String].self)
-            self = .port(a1)
+            self = .macPort(a1)
         case .apt:
             var unkeyedValues = try values.nestedUnkeyedContainer(forKey: key)
             let a1 = try unkeyedValues.decode([String].self)

Sources/PackageModel/ManifestSourceGeneration.swift

@@ -404,9 +404,9 @@ fileprivate extension SourceCodeFragment {
         case .brew(let names):
             let params = [SourceCodeFragment(strings: names)]
             self.init(enum: "brew", subnodes: params)
-        case .port(let names):
+        case .macPort(let names):
             let params = [SourceCodeFragment(strings: names)]
-            self.init(enum: "port", subnodes: params)
+            self.init(enum: "macPort", subnodes: params)
         case .apt(let names):
             let params = [SourceCodeFragment(strings: names)]
             self.init(enum: "apt", subnodes: params)

Tests/BuildTests/BuildPlanTests.swift

@@ -2891,7 +2891,7 @@ final class BuildPlanTests: XCTestCase {
                             pkgConfig: "BTarget",
                             providers: [
                                 .brew(["BTarget"]),
-                                .port(["BTarget"]),
+                                .macPort(["BTarget"]),
                                 .apt(["BTarget"]),
                                 .yum(["BTarget"]),
                             ]