Skip to content

Commit cd51c11

Browse files
authored
Merge pull request #85 from tomerd/fix-formatting
improve RPM spec formatting
2 parents 9cdc903 + 4663d92 commit cd51c11

File tree

5 files changed

+155
-194
lines changed

5 files changed

+155
-194
lines changed

platforms/Linux/RPM/Centos/7/swiftlang.spec

+1-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ Source31: https://github.com/apple/swift-format/archive/swift-%{swift_vers
4444
Source32: https://github.com/apple/swift-lmdb/archive/swift-%{swift_version}.tar.gz#/swift-lmdb.tar.gz
4545
Source33: https://github.com/apple/swift-markdown/archive/swift-%{swift_version}.tar.gz#/swift-markdown.tar.gz
4646

47-
4847
Patch0: patches/hwasan_symbolize.patch
4948

5049
BuildRequires: autoconf
@@ -64,9 +63,9 @@ BuildRequires: ninja-build
6463
BuildRequires: openssl-devel
6564
BuildRequires: pexpect
6665
BuildRequires: python-devel
67-
BuildRequires: python3-devel
6866
BuildRequires: python-pygments
6967
BuildRequires: python-six
68+
BuildRequires: python3-devel
7069
BuildRequires: python36-pexpect
7170
BuildRequires: python36-six
7271
BuildRequires: PyYAML

platforms/Linux/RPM/Centos/8/swiftlang.spec

+3-3
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,16 @@ BuildRequires: libxml2-devel
6262
BuildRequires: make
6363
BuildRequires: ncurses-devel
6464
BuildRequires: pcre-devel
65+
BuildRequires: platform-python-devel
6566
BuildRequires: python2
6667
BuildRequires: python2-devel
6768
BuildRequires: python2-six
6869
BuildRequires: python3
69-
BuildRequires: python3-six
7070
BuildRequires: python3-pexpect
71-
BuildRequires: platform-python-devel
71+
BuildRequires: python3-six
72+
BuildRequires: rsync
7273
BuildRequires: sqlite-devel
7374
BuildRequires: swig
74-
BuildRequires: rsync
7575
BuildRequires: tar
7676
BuildRequires: which
7777

platforms/Linux/RPM/Fedora/34/swiftlang.spec

+49-62
Original file line numberDiff line numberDiff line change
@@ -59,114 +59,105 @@ Source32: https://github.com/apple/swift-lmdb/archive/swift-%{swift_versio
5959
Source33: https://github.com/apple/swift-markdown/archive/swift-%{swift_version}.tar.gz#/swift-markdown.tar.gz
6060

6161
Patch0: nocyclades.patch
62-
Patch1: unusedvariable.patch
63-
62+
Patch1: unusedvariable.patch
63+
6464
BuildRequires: clang
65-
BuildRequires: swig
66-
BuildRequires: rsync
67-
BuildRequires: python3
68-
BuildRequires: python3-devel
69-
BuildRequires: python3-setuptools
70-
BuildRequires: python3-distro
7165
BuildRequires: libbsd-devel
72-
BuildRequires: libxml2-devel
73-
BuildRequires: libsqlite3x-devel
74-
BuildRequires: libdispatch-devel
7566
BuildRequires: libcurl-devel
76-
BuildRequires: libuuid-devel
67+
BuildRequires: libdispatch-devel
7768
BuildRequires: libedit-devel
7869
BuildRequires: libicu-devel
70+
BuildRequires: libsqlite3x-devel
71+
BuildRequires: libuuid-devel
72+
BuildRequires: libxml2-devel
7973
BuildRequires: perl-podlators
74+
BuildRequires: python3
75+
BuildRequires: python3-devel
76+
BuildRequires: python3-distro
77+
BuildRequires: python3-setuptools
8078
BuildRequires: python3-six
81-
BuildRequires: /usr/bin/pathfix.py
82-
BuildRequires: cmake
79+
BuildRequires: rsync
80+
BuildRequires: swig
8381
%if ! 0%{?el8}
8482
BuildRequires: python-unversioned-command
8583
%endif
84+
BuildRequires: /usr/bin/pathfix.py
8685

87-
Requires: glibc-devel
8886
Requires: binutils-gold
8987
Requires: gcc
90-
Requires: ncurses-devel
88+
Requires: glibc-devel
9189
Requires: ncurses-compat-libs
90+
Requires: ncurses-devel
9291

93-
ExclusiveArch: x86_64 aarch64
92+
ExclusiveArch: x86_64 aarch64
9493

9594
Provides: swiftlang = %{version}-%{release}
9695

9796
%description
98-
Swift is a general-purpose programming language built using
99-
a modern approach to safety, performance, and software design
97+
Swift is a general-purpose programming language built using
98+
a modern approach to safety, performance, and software design
10099
patterns.
101100

102-
The goal of the Swift project is to create the best available
103-
language for uses ranging from systems programming, to mobile
104-
and desktop apps, scaling up to cloud services. Most
105-
importantly, Swift is designed to make writing and maintaining
106-
correct programs easier for the developer.
107-
101+
The goal of the Swift project is to create the best available
102+
language for uses ranging from systems programming, to mobile
103+
and desktop apps, scaling up to cloud services. Most
104+
importantly, Swift is designed to make writing and maintaining
105+
correct programs easier for the developer.
108106

109107
%prep
110108
%setup -q -c -n %{swift_source_location} -a 0 -a 1 -a 2 -a 3 -a 4 -a 5 -a 6 -a 7 -a 8 -a 9 -a 10 -a 11 -a 12 -a 13 -a 14 -a 15 -a 16 -a 17 -a 18 -a 19 -a 20 -a 21 -a 22 -a 23 -a 24 -a 25 -a 26 -a 27 -a 28 -a 29 -a 30 -a 31 -a 32 -a 33
111109
# The Swift build script requires directories to be named
112110
# in a specific way so renaming the source directories is
113111
# necessary
114-
mv swift-cmark-swift-%{swift_version} cmark
115-
mv swift-corelibs-foundation-swift-%{swift_version} swift-corelibs-foundation
116-
mv swift-corelibs-libdispatch-swift-%{swift_version} swift-corelibs-libdispatch
117-
mv swift-corelibs-xctest-swift-%{swift_version} swift-corelibs-xctest
118-
mv swift-integration-tests-swift-%{swift_version} swift-integration-tests
119-
mv swift-llbuild-swift-%{swift_version} llbuild
120-
mv swift-package-manager-swift-%{swift_version} swiftpm
121-
mv swift-swift-%{swift_version} swift
122-
mv swift-xcode-playground-support-swift-%{swift_version} swift-xcode-playground-support
123-
mv sourcekit-lsp-swift-%{swift_version} sourcekit-lsp
112+
mv CMake-%{cmake_version} cmake
113+
mv icu-release-%{icu_version} icu
124114
mv indexstore-db-swift-%{swift_version} indexstore-db
125115
mv llvm-project-swift-%{swift_version} llvm-project
126-
mv swift-syntax-swift-%{swift_version} swift-syntax
127-
mv swift-tools-support-core-swift-%{swift_version} swift-tools-support-core
128-
mv swift-argument-parser-%{swift_argument_parser_version} swift-argument-parser
129-
mv swift-driver-swift-%{swift_version} swift-driver
130-
mv swift-crypto-%{swift_crypto_version} swift-crypto
131116
mv ninja-%{ninja_version} ninja
132-
mv CMake-%{cmake_version} cmake
117+
mv ninja-%{ninja_version} ninja
118+
mv sourcekit-lsp-swift-%{swift_version} sourcekit-lsp
119+
mv swift-argument-parser-%{swift_argument_parser_version} swift-argument-parser
133120
mv swift-atomics-%{swift_atomics_version} swift-atomics
121+
mv swift-cmark-swift-%{swift_version} cmark
134122
mv swift-cmark-swift-%{swift_version}-gfm swift-cmark-gfm
135-
mv swift-docc-swift-%{swift_version} swift-docc
123+
mv swift-collections-%{swift_collections_version} swift-collections
124+
mv swift-corelibs-foundation-swift-%{swift_version} swift-corelibs-foundation
125+
mv swift-corelibs-libdispatch-swift-%{swift_version} swift-corelibs-libdispatch
126+
mv swift-corelibs-xctest-swift-%{swift_version} swift-corelibs-xctest
127+
mv swift-crypto-%{swift_crypto_version} swift-crypto
136128
mv swift-docc-render-artifact-swift-%{swift_version} swift-docc-render-artifact
129+
mv swift-docc-swift-%{swift_version} swift-docc
137130
mv swift-docc-symbolkit-swift-%{swift_version} swift-docc-symbolkit
138-
mv swift-collections-%{swift_collections_version} swift-collections
139-
mv swift-numerics-%{swift_numerics_version} swift-numerics
140-
mv swift-system-%{swift_system_version} swift-system
141-
mv swift-nio-%{swift_nio_version} swift-nio
142-
mv swift-nio-ssl-%{swift_nio_ssl_version} swift-nio-ssl
131+
mv swift-driver-swift-%{swift_version} swift-driver
143132
mv swift-format-swift-%{swift_version} swift-format
133+
mv swift-integration-tests-swift-%{swift_version} swift-integration-tests
134+
mv swift-llbuild-swift-%{swift_version} llbuild
144135
mv swift-lmdb-swift-%{swift_version} swift-lmdb
145136
mv swift-markdown-swift-%{swift_version} swift-markdown
146-
147-
# ICU
148-
mv icu-release-%{icu_version} icu
149-
150-
# Yams
137+
mv swift-nio-%{swift_nio_version} swift-nio
138+
mv swift-nio-ssl-%{swift_nio_ssl_version} swift-nio-ssl
139+
mv swift-numerics-%{swift_numerics_version} swift-numerics
140+
mv swift-package-manager-swift-%{swift_version} swiftpm
141+
mv swift-swift-%{swift_version} swift
142+
mv swift-syntax-swift-%{swift_version} swift-syntax
143+
mv swift-system-%{swift_system_version} swift-system
144+
mv swift-tools-support-core-swift-%{swift_version} swift-tools-support-core
145+
mv swift-xcode-playground-support-swift-%{swift_version} swift-xcode-playground-support
151146
mv Yams-%{yams_version} yams
152147

153-
# Ninja
154-
mv ninja-%{ninja_version} ninja
155-
156148
# Remove Cyclades as it has been removed from the Linux kernel
157149
%patch0 -p0
158150

159151
# Temp patch to test libdispatch issue with clang 13
160152
%patch1 -p0
161153

162-
# Fix python to python3
154+
# Fix python to python3
163155
pathfix.py -pni "%{__python3} %{py3_shbang_opts}" swift/utils/api_checker/swift-api-checker.py
164156
pathfix.py -pni "%{__python3} %{py3_shbang_opts}" llvm-project/compiler-rt/lib/hwasan/scripts/hwasan_symbolize
165157

166-
167158
%build
168159
export VERBOSE=1
169-
# Before Fedora 34, we may not have /usr/bin/python, so we
160+
# Before Fedora 34, we may not have /usr/bin/python, so we
170161
# roll our own because the build script expects there to be one.
171162
%if 0%{?fedora} < 34 || 0%{?el8}
172163
mkdir $PWD/binforpython
@@ -177,7 +168,6 @@ export PATH=$PWD/binforpython:$PATH
177168
# Here we go!
178169
swift/utils/build-script --preset=buildbot_linux,no_assertions,no_test install_destdir=%{_builddir} installable_package=%{_builddir}/swift-%{version}-%{linux_version}.tar.gz
179170

180-
181171
%install
182172
mkdir -p %{buildroot}%{_libexecdir}/swift/%{package_version}
183173
cp -r %{_builddir}/usr/* %{buildroot}%{_libexecdir}/swift/%{package_version}
@@ -192,7 +182,6 @@ cp %{_builddir}/usr/share/man/man1/swift.1 %{buildroot}%{_mandir}/man1/swift.1
192182
# how the Swift binaries use RPATH
193183
export QA_SKIP_RPATHS=1
194184

195-
196185
%files
197186
%license swift/LICENSE.txt
198187
%{_bindir}/swift
@@ -201,9 +190,7 @@ export QA_SKIP_RPATHS=1
201190
%{_mandir}/man1/swift.1.gz
202191
%{_libexecdir}/swift/
203192

204-
205193
%post -p /sbin/ldconfig
206194
%postun -p /sbin/ldconfig
207195

208-
209196
%changelog

0 commit comments

Comments
 (0)