Skip to content

Commit 84addf9

Browse files
authored
Merge pull request #2864 from jamieQ/patch-2
[SE-0486]: minor typo fixes/edits
2 parents 126eb66 + 7411297 commit 84addf9

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

proposals/0486-adoption-tooling-for-swift-features.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ using `-print-diagnostic-groups` and used to associate messages with features.
162162

163163
### `swift package migrate` command
164164

165-
To enable seemless migration experience for Swift packages, I'd like to propose a new Swift Package Manager command - `swift package migrate` to complement the Swift compiler-side changes.
165+
To enable seamless migration experience for Swift packages, I'd like to propose a new Swift Package Manager command - `swift package migrate` to complement the Swift compiler-side changes.
166166

167167
The command would accept one or more features that have migration mode enabled and optionally a set of targets to migrate, if no targets are specified the whole package is going to be migrated to use new features.
168168

@@ -211,11 +211,11 @@ enable the feature(s) if both of the previous actions are successful:
211211
In the "whole package" mode, every target is going to be updated to include
212212
new feature flag(s). This is supported by the same functionality as `swift package add-setting` command.
213213

214-
If it's, for some reason, impossible to add the setting the diagnostic message would suggest what to add and where i.e. `...; please add 'ExistentialAny' feature to `MyTarget` target manually`.
214+
If it's, for some reason, impossible to add the setting the diagnostic message would suggest what to add and where i.e. `...; please add 'ExistentialAny' feature to 'MyTarget' target manually`.
215215

216216
#### Impact on Interface
217217

218-
This proposal introduces a new command but does that does not interfere with existing commands. It follows the same pattern as `swift build` and `swift test` in a consistent manner.
218+
This proposal introduces a new command but does not interfere with existing commands. It follows the same pattern as `swift build` and `swift test` in a consistent manner.
219219

220220
## Source compatibility
221221

@@ -278,20 +278,20 @@ is essential for future tools built around migration mode:
278278

279279
### A distinct `-migrate` option
280280

281-
This direction has a questionably balanced set of advantanges and downsides.
281+
This direction has a questionably balanced set of advantages and downsides.
282282
On one hand, it would provide an adequate foundation for invoking migration
283283
for a language mode in addition to individual features.
284284
On the other hand, an independent option is less discoverable, has a steeper
285285
learning curve, and makes the necessary relationships between it and the
286286
existing `-enable-*-feature` options harder to infer.
287287
Perhaps more notably, a bespoke option by itself would not scale to any future
288-
modes, setting what might be an unfortunate example for further decentralizion
288+
modes, setting what might be an unfortunate example for further decentralization
289289
of language feature control.
290290

291291
### API for package manifests
292292

293293
The decision around surfacing migration mode in the `PackageDescription`
294-
library depends on whether there is a concensus on the value of enabling it as
294+
library depends on whether there is a consensus on the value of enabling it as
295295
a persistent setting as opposed to an automated procedure in the long run.
296296

297297
Here is how an API change could look like for the proposed solution:
@@ -347,7 +347,7 @@ The next candidates in line per discussions are ***adopt***, ***audit***,
347347

348348
### `swift package migrate` vs. `swift migrate`
349349

350-
Rather than have migrate as a subcommand (ie. `swift package migrate`), another option is add another top level command, ie. `swift migrate`.
350+
Rather than have migrate as a subcommand (ie. `swift package migrate`), another option is to add another top level command, ie. `swift migrate`.
351351

352352
As the command applies to the current package, we feel a `swift package` sub-command fits better than a new top-level command. This also aligns with the recently added package refactorings (eg. `add-target`).
353353

0 commit comments

Comments
 (0)