Skip to content

Commit 272e818

Browse files
authored
Merge pull request #223 from apple/eng/PR-SR-4039
queue_specific_queue is missing its do_push vtable entry
2 parents fcc1924 + b4b5cc6 commit 272e818

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/init.c

+5-3
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,7 @@ DISPATCH_VTABLE_SUBCLASS_INSTANCE(queue_root, queue,
398398
.do_kind = "global-queue",
399399
.do_dispose = _dispatch_pthread_root_queue_dispose,
400400
.do_push = _dispatch_root_queue_push,
401+
.do_invoke = NULL,
401402
.do_wakeup = _dispatch_root_queue_wakeup,
402403
.do_debug = dispatch_queue_debug,
403404
);
@@ -406,8 +407,8 @@ DISPATCH_VTABLE_SUBCLASS_INSTANCE(queue_main, queue,
406407
.do_type = DISPATCH_QUEUE_SERIAL_TYPE,
407408
.do_kind = "main-queue",
408409
.do_dispose = _dispatch_queue_dispose,
409-
.do_invoke = _dispatch_queue_invoke,
410410
.do_push = _dispatch_queue_push,
411+
.do_invoke = _dispatch_queue_invoke,
411412
.do_wakeup = _dispatch_main_queue_wakeup,
412413
.do_debug = dispatch_queue_debug,
413414
);
@@ -416,17 +417,17 @@ DISPATCH_VTABLE_SUBCLASS_INSTANCE(queue_runloop, queue,
416417
.do_type = DISPATCH_QUEUE_RUNLOOP_TYPE,
417418
.do_kind = "runloop-queue",
418419
.do_dispose = _dispatch_runloop_queue_dispose,
419-
.do_invoke = _dispatch_queue_invoke,
420420
.do_push = _dispatch_queue_push,
421+
.do_invoke = _dispatch_queue_invoke,
421422
.do_wakeup = _dispatch_runloop_queue_wakeup,
422423
.do_debug = dispatch_queue_debug,
423424
);
424425

425426
DISPATCH_VTABLE_SUBCLASS_INSTANCE(queue_mgr, queue,
426427
.do_type = DISPATCH_QUEUE_MGR_TYPE,
427428
.do_kind = "mgr-queue",
428-
.do_invoke = _dispatch_mgr_thread,
429429
.do_push = _dispatch_queue_push,
430+
.do_invoke = _dispatch_mgr_thread,
430431
.do_wakeup = _dispatch_mgr_queue_wakeup,
431432
.do_debug = dispatch_queue_debug,
432433
);
@@ -435,6 +436,7 @@ DISPATCH_VTABLE_INSTANCE(queue_specific_queue,
435436
.do_type = DISPATCH_QUEUE_SPECIFIC_TYPE,
436437
.do_kind = "queue-context",
437438
.do_dispose = _dispatch_queue_specific_queue_dispose,
439+
.do_push = (void *)_dispatch_queue_push,
438440
.do_invoke = (void *)_dispatch_queue_invoke,
439441
.do_wakeup = (void *)_dispatch_queue_wakeup,
440442
.do_debug = (void *)dispatch_queue_debug,

tests/Makefile.am

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ UNRELIABLE_TESTS= \
4141
dispatch_drift \
4242
dispatch_readsync \
4343
dispatch_cascade \
44-
dispatch_context_for_key \
4544
dispatch_io
4645

4746
if EXTENDED_TEST_SUITE
@@ -60,6 +59,7 @@ TESTS= \
6059
dispatch_group \
6160
dispatch_overcommit \
6261
dispatch_plusplus \
62+
dispatch_context_for_key \
6363
dispatch_after \
6464
dispatch_timer \
6565
dispatch_timer_short \

0 commit comments

Comments
 (0)