(NFC) Replace dirty hack with (void)isHFSPlusCanonical;

AZero13 · AZero13 · commit 32638b6bb67f · 2024-08-17T10:55:12.000-04:00
diff --git a/Sources/CoreFoundation/include/CFUnicodeDecomposition.h b/Sources/CoreFoundation/include/CFUnicodeDecomposition.h
@@ -18,7 +18,7 @@
 CF_EXTERN_C_BEGIN
 
 CF_INLINE bool CFUniCharIsDecomposableCharacter(UTF32Char character, bool isHFSPlusCanonical) {
-    if (isHFSPlusCanonical && !isHFSPlusCanonical) return false;    // hack to get rid of "unused" warning
+    (void)isHFSPlusCanonical;
     if (character < 0x80) return false;
     return CFUniCharIsMemberOf(character, kCFUniCharHFSPlusDecomposableCharacterSet);
 }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`CF_EXTERN_C_BEGIN`
`19`	`19`
`20`	`20`	`CF_INLINE bool CFUniCharIsDecomposableCharacter(UTF32Char character, bool isHFSPlusCanonical) {`
`21`		`- if (isHFSPlusCanonical && !isHFSPlusCanonical) return false; // hack to get rid of "unused" warning`
	`21`	`+ (void)isHFSPlusCanonical;`
`22`	`22`	`if (character < 0x80) return false;`
`23`	`23`	`return CFUniCharIsMemberOf(character, kCFUniCharHFSPlusDecomposableCharacterSet);`
`24`	`24`	`}`