Skip to content

Commit 63fa050

Browse files
committed
Log the request methods when logging a request's reply
This should make it easier to find a request response when searching for the response method.
1 parent bb699c9 commit 63fa050

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

Sources/LanguageServerProtocolExtensions/LocalConnection.swift

+2
Original file line numberDiff line numberDiff line change
@@ -138,13 +138,15 @@ package final class LocalConnection: Connection, Sendable {
138138
logger.info(
139139
"""
140140
Received reply for request \(id, privacy: .public) from \(self.name, privacy: .public)
141+
\(Request.method, privacy: .public)
141142
\(response.forLogging)
142143
"""
143144
)
144145
case .failure(let error):
145146
logger.error(
146147
"""
147148
Received error for request \(id, privacy: .public) from \(self.name, privacy: .public)
149+
\(Request.method, privacy: .public)
148150
\(error.forLogging)
149151
"""
150152
)

Sources/LanguageServerProtocolExtensions/QueueBasedMessageHandler.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ extension QueueBasedMessageHandler {
192192
)
193193
.makeSignposter()
194194
let signpostID = signposter.makeSignpostID()
195-
let state = signposter.beginInterval("Notification", id: signpostID, "\(type(of: notification))")
195+
let state = signposter.beginInterval("Notification", id: signpostID, "\(type(of: notification).method)")
196196
messageHandlingQueue.async(metadata: DependencyTracker(notification)) {
197197
signposter.emitEvent("Start handling", id: signpostID)
198198
await self.handle(notification: notification)
@@ -209,7 +209,7 @@ extension QueueBasedMessageHandler {
209209
let signposter = Logger(subsystem: LoggingScope.subsystem, category: messageHandlingHelper.signpostLoggingCategory)
210210
.makeSignposter()
211211
let signpostID = signposter.makeSignpostID()
212-
let state = signposter.beginInterval("Request", id: signpostID, "\(Request.self)")
212+
let state = signposter.beginInterval("Request", id: signpostID, "\(Request.method)")
213213

214214
self.didReceive(request: request, id: id)
215215

Sources/LanguageServerProtocolJSONRPC/JSONRPCConnection.swift

+2
Original file line numberDiff line numberDiff line change
@@ -708,13 +708,15 @@ public final class JSONRPCConnection: Connection {
708708
logger.info(
709709
"""
710710
Received reply for request \(id, privacy: .public) from \(self.name, privacy: .public)
711+
\(Request.method, privacy: .public)
711712
\(response.forLogging)
712713
"""
713714
)
714715
case .failure(let error):
715716
logger.error(
716717
"""
717718
Received error for request \(id, privacy: .public) from \(self.name, privacy: .public)
719+
\(Request.method, privacy: .public)
718720
\(error.forLogging)
719721
"""
720722
)

0 commit comments

Comments
 (0)