From dacfc12f819e259f80d3c487273c993f162e5bd2 Mon Sep 17 00:00:00 2001 From: Advay Patil Date: Sat, 28 Dec 2024 23:26:05 -0800 Subject: [PATCH] Fix issue in validating report statuses --- server/report/views.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/server/report/views.py b/server/report/views.py index f0b3c58..7dc8409 100644 --- a/server/report/views.py +++ b/server/report/views.py @@ -186,13 +186,17 @@ def patch(self, request, report_id): {"error": "status is required"}, status=status.HTTP_400_BAD_REQUEST ) - if request.data["status"] not in Report.STATUS_CHOICES: + updated_status = request.data["status"] + + if not any( + updated_status in valid_choice for valid_choice in Report.STATUS_CHOICES + ): return Response( {"error": "Invalid status provided"}, status=status.HTTP_400_BAD_REQUEST ) report = report[0] - report.status = request.data["status"] + report.status = updated_status report.save() return Response(