Skip to content

ES private field check #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Danue1 opened this issue Sep 28, 2021 · 5 comments
Closed

ES private field check #2311

Danue1 opened this issue Sep 28, 2021 · 5 comments
Labels

Comments

@Danue1
Copy link

Danue1 commented Sep 28, 2021

Describe the bug
ES private field check failed.

Input code

class Foo {
  static foo(foo) {
    return #foo in foo;
  }

  #foo = 'foo';
}

Config
default

Expected behavior
When lhs of "in" operator is a private identifier.

If there is a corresponding private field in the class definition, there is no error and it should be transpiled as it is.
If the corresponding private field does not exist in the class definition, an error should be raised that the corresponding private field in the class definition must exist.

Version
The version of @swc/core: 1.2.91

@Danue1 Danue1 added the C-bug label Sep 28, 2021
@Danue1
Copy link
Author

Danue1 commented Sep 28, 2021

I know the maintainers are busy.
If I get a guide on how to approach it, I'll try PR. Is it possible?
Although I am making a small financial support to swc, I also wanted to make a technical contribution.

@kdy1
Copy link
Member

kdy1 commented Sep 28, 2021

This is already implemented by #2079, but not published yet.

@Danue1
Copy link
Author

Danue1 commented Sep 28, 2021

good.
It's already been done...
I respect that speed.

@Danue1
Copy link
Author

Danue1 commented Sep 28, 2021

It's almost resolved, so I'll close the issue now.

@Danue1 Danue1 closed this as completed Sep 28, 2021
@swc-bot
Copy link
Collaborator

swc-bot commented Oct 21, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants