Pattern property setter will always throw an exception on valid property names

Author: reflexxion

src/Property/PatternPropertySetter.php

@@ -33,7 +33,7 @@ public function __construct(PhpConstant $patternConst, PhpAnyType $type)
         $this->setResult(PhpStdType::tSelf());
         $this->setBody(
             new PlaceholderString(<<<PHP
-if (preg_match(:helper::toPregPattern(self::{$patternConst->getName()}), \$name)) {
+if (!preg_match(:helper::toPregPattern(self::{$patternConst->getName()}), \$name)) {
     throw new StringException('Pattern mismatch', :stringException::PATTERN_MISMATCH);
 }
 \$this->addPatternPropertyName(self::{$patternConst->getName()}, \$name);

tests/src/PHPUnit/JsonSchema/AdvancedTest.php

@@ -477,7 +477,7 @@ public function getXValues()
      */
     public function setXValue($name, $value)
     {
-        if (preg_match(Swaggest\JsonSchema\Helper::toPregPattern(self::X_PROPERTY_PATTERN), $name)) {
+        if (!preg_match(Swaggest\JsonSchema\Helper::toPregPattern(self::X_PROPERTY_PATTERN), $name)) {
             throw new StringException('Pattern mismatch', Swaggest\JsonSchema\Exception\StringException::PATTERN_MISMATCH);
         }
         $this->addPatternPropertyName(self::X_PROPERTY_PATTERN, $name);
@@ -512,7 +512,7 @@ public function getZedValues()
      */
     public function setZedValue($name, $value)
     {
-        if (preg_match(Swaggest\JsonSchema\Helper::toPregPattern(self::ZED_PROPERTY_PATTERN), $name)) {
+        if (!preg_match(Swaggest\JsonSchema\Helper::toPregPattern(self::ZED_PROPERTY_PATTERN), $name)) {
             throw new StringException('Pattern mismatch', Swaggest\JsonSchema\Exception\StringException::PATTERN_MISMATCH);
         }
         $this->addPatternPropertyName(self::ZED_PROPERTY_PATTERN, $name);

tests/src/PHPUnit/JsonSchema/FeatureTest.php

@@ -3,6 +3,7 @@
 namespace Swaggest\PhpCodeBuilder\Tests\PHPUnit\JsonSchema;
 
 
+use Swaggest\JsonSchema\Exception\StringException;
 use Swaggest\JsonSchema\Schema;
 use Swaggest\PhpCodeBuilder\App\PhpApp;
 use Swaggest\PhpCodeBuilder\JsonSchema\ClassHookCallback;
@@ -88,6 +89,10 @@ public function testGeneratedEntity()
         $e = Entity::import($data);
         $this->assertEquals(['x-sample' => 1], $e->getXValues());
         $this->assertEquals(['z-sample' => true], $e->getZValues());
+        $e->setXValue('x-sample', 2);
+        $this->assertEquals(['x-sample' => 2], $e->getXValues());
+        $e->setXValue('x-sample-3', 3);
+        $this->assertEquals(['x-sample' => 2, 'x-sample-3' => 3], $e->getXValues());
 
         $this->assertEquals(['foo1' => 'bar1', 'foo2' => 'bar2'], $e->getAdditionalPropertyValues());
 
@@ -98,6 +103,8 @@ public function testGeneratedEntity()
         $e->{'x-sample'} = 1;
         $e->{'z-sample'} = "one";
 
+        $this->expectException(StringException::class);
+        $e->setXValue('invalid-name', 'invalid');
 
     }