Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather widget prints undefined from time to time #183

Open
stickyPiston opened this issue Jan 16, 2025 · 4 comments
Open

Weather widget prints undefined from time to time #183

stickyPiston opened this issue Jan 16, 2025 · 4 comments
Labels

Comments

@stickyPiston
Copy link
Member

On production, the weather widget sometimes displays undefined, and sometimes displays the temperature. Ideally, we want to cache the results from the weather api, if it fails to fetch.

@SamStaijen
Copy link
Member

Great idea, however, what would we do if we keep failing the fetch? I would assume we would want to get notified. Maybe make old (failover) data italic, and new (regular) data none?

sarcastic, hyperoptimistic, solution solution: "This sounds like a fun job for Prometheus/Zabbix"

@KoenDR06
Copy link
Contributor

KoenDR06 commented Feb 3, 2025

Hmm, strange. I wouldn't know why that happens, I'll look into it during the next commit session.

I think Sam's idea is a good one, where we make the text italic, or some other small indicator that something's gone wrong.

@peppidesu
Copy link
Contributor

Now that #186 is merged, i suggest we just do the following:

  • Do a number of retries before failing
  • Return a fallback response with isSuccess = false on failure

@peppidesu
Copy link
Contributor

peppidesu commented Feb 11, 2025

We should probably just add request fallbacks in general, after coming across #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants