-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather widget prints undefined from time to time #183
Comments
Great idea, however, what would we do if we keep failing the fetch? I would assume we would want to get notified. Maybe make old (failover) data sarcastic, hyperoptimistic, solution solution: "This sounds like a fun job for Prometheus/Zabbix" |
Hmm, strange. I wouldn't know why that happens, I'll look into it during the next commit session. I think Sam's idea is a good one, where we make the text italic, or some other small indicator that something's gone wrong. |
Now that #186 is merged, i suggest we just do the following:
|
We should probably just add request fallbacks in general, after coming across #160 |
On production, the weather widget sometimes displays undefined, and sometimes displays the temperature. Ideally, we want to cache the results from the weather api, if it fails to fetch.
The text was updated successfully, but these errors were encountered: