Templates: Fix the return value of get_the_author_posts_link().

pento · pento · commit 67d619bdd164 · 2019-01-16T05:54:49.000Z
When the `$authordata` global isn't defined, return an empty string, rather than `void`. Props mukesh27, subrataemfluence. Fixes #45597. Built from https://develop.svn.wordpress.org/trunk@44616 git-svn-id: http://core.svn.wordpress.org/trunk@44447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
diff --git a/wp-includes/author-template.php b/wp-includes/author-template.php
@@ -288,12 +288,12 @@ function the_author_posts() {
  *
  * @global object $authordata The current author's DB object.
  *
- * @return string An HTML link to the author page.
+ * @return string An HTML link to the author page, or an empty string if $authordata isn't defined.
  */
 function get_the_author_posts_link() {
 	global $authordata;
 	if ( ! is_object( $authordata ) ) {
-		return;
+		return '';
 	}
 
 	$link = sprintf(
diff --git a/wp-includes/version.php b/wp-includes/version.php
@@ -13,7 +13,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '5.1-beta1-44615';
+$wp_version = '5.1-beta1-44616';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.

Original file line number	Diff line number	Diff line change
`@@ -288,12 +288,12 @@ function the_author_posts() {`
`288`	`288`	`*`
`289`	`289`	`* @global object $authordata The current author's DB object.`
`290`	`290`	`*`
`291`		`- * @return string An HTML link to the author page.`
	`291`	`+ * @return string An HTML link to the author page, or an empty string if $authordata isn't defined.`
`292`	`292`	`*/`
`293`	`293`	`function get_the_author_posts_link() {`
`294`	`294`	`global $authordata;`
`295`	`295`	`if ( ! is_object( $authordata ) ) {`
`296`		`- return;`
	`296`	`+ return '';`
`297`	`297`	`}`
`298`	`298`
`299`	`299`	`$link = sprintf(`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`*`
`14`	`14`	`* @global string $wp_version`
`15`	`15`	`*/`
`16`		`-$wp_version = '5.1-beta1-44615';`
	`16`	`+$wp_version = '5.1-beta1-44616';`
`17`	`17`
`18`	`18`	`/**`
`19`	`19`	`* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.`