remove packaging script (#50)

Rich-Harris · web-flow · commit 5b33d7aee4f0 · 2024-06-25T15:09:13.000-04:00
* remove packaging script

* match site-kit

* fix a bunch of type errors that were somehow hidden until now????
diff --git a/apps/svelte.dev/package.json b/apps/svelte.dev/package.json
@@ -79,7 +79,7 @@
 		"shiki": "^1.6.4",
 		"shiki-twoslash": "^3.1.2",
 		"svelte": "5.0.0-next.160",
-		"svelte-check": "^3.8.0",
+		"svelte-check": "^3.8.2",
 		"svelte-preprocess": "^5.1.4",
 		"tiny-glob": "^0.2.9",
 		"typescript": "^5.4.5",
diff --git a/apps/svelte.dev/src/routes/(authed)/repl/[id]/+page.svelte b/apps/svelte.dev/src/routes/(authed)/repl/[id]/+page.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
 	import { browser } from '$app/environment';
 	import { afterNavigate, goto, replaceState } from '$app/navigation';
-	import Repl from '@sveltejs/repl';
+	import { Repl } from '@sveltejs/repl';
 	import { theme } from '@sveltejs/site-kit/stores';
 	import { onMount } from 'svelte';
 	import { mapbox_setup } from '../../../../config.js';
diff --git a/apps/svelte.dev/src/routes/(authed)/repl/[id]/AppControls.svelte b/apps/svelte.dev/src/routes/(authed)/repl/[id]/AppControls.svelte
@@ -6,9 +6,10 @@
 	import downloadBlob from './downloadBlob.js';
 	import { enter } from '$lib/utils/events';
 	import { isMac } from '$lib/utils/compat.js';
-	import Repl from '@sveltejs/repl';
+	import { Repl } from '@sveltejs/repl';
 	import { get_app_context } from '../../app-context';
 	import type { Gist, User } from '$lib/db/types';
+	import type { File } from '@sveltejs/repl';
 
 	interface Props {
 		user: User | null;
@@ -52,7 +53,7 @@
 	async function fork(intentWasSave: boolean) {
 		saving = true;
 
-		const { files } = repl.toJSON();
+		const { files } = repl.toJSON() as { files: File[] };
 
 		try {
 			const r = await fetch(`/repl/create.json`, {
@@ -118,7 +119,7 @@
 		try {
 			// Send all files back to API
 			// ~> Any missing files are considered deleted!
-			const { files } = repl.toJSON();
+			const { files } = repl.toJSON() as { files: File[] };
 
 			const r = await fetch(`/repl/save/${gist.id}.json`, {
 				method: 'PUT',
@@ -159,7 +160,10 @@
 	async function download() {
 		downloading = true;
 
-		const { files: components, imports } = repl.toJSON();
+		const { files: components, imports } = repl.toJSON() as {
+			files: any[];
+			imports: string[];
+		};
 
 		const files = (await (await fetch('/svelte-app.json')).json()) as Array<{
 			path: string;
diff --git a/apps/svelte.dev/src/routes/(authed)/repl/[id]/embed/+page.svelte b/apps/svelte.dev/src/routes/(authed)/repl/[id]/embed/+page.svelte
@@ -2,7 +2,7 @@
 	import { browser } from '$app/environment';
 	import { afterNavigate } from '$app/navigation';
 	import { theme } from '@sveltejs/site-kit/stores';
-	import Repl from '@sveltejs/repl';
+	import { Repl } from '@sveltejs/repl';
 	import { mapbox_setup } from '../../../../../config.js';
 	import { onMount } from 'svelte';
 
diff --git a/apps/svelte.dev/src/routes/_components/Example.svelte b/apps/svelte.dev/src/routes/_components/Example.svelte
@@ -1,12 +1,12 @@
 <script>
 	import IntersectionObserver from '$lib/components/IntersectionObserver.svelte';
 	import { process_example } from '$lib/utils/examples';
-	import Repl from '@sveltejs/repl';
+	import { Repl } from '@sveltejs/repl';
 	import { theme } from '@sveltejs/site-kit/stores';
 
 	export let id;
 
-	/** @type {import('@sveltejs/repl').default} */
+	/** @type {Repl} */
 	let repl;
 
 	$: {
diff --git a/packages/repl/package.json b/packages/repl/package.json
@@ -5,8 +5,7 @@
 		"dev": "vite dev",
 		"build": "vite build && npm run package",
 		"preview": "vite preview",
-		"package": "svelte-kit sync && svelte-package && publint",
-		"package:watch": "svelte-kit sync && svelte-package --watch",
+		"package": "svelte-kit sync",
 		"prepublishOnly": "npm run package",
 		"check": "svelte-kit sync && svelte-check",
 		"lint": "prettier --check .",
@@ -24,13 +23,12 @@
 	"homepage": "https://github.com/sveltejs/svelte.dev/tree/main/packages/repl/#readme",
 	"exports": {
 		".": {
-			"types": "./dist/Repl.svelte.d.ts",
-			"svelte": "./dist/Repl.svelte"
+			"svelte": "./src/lib/index.ts",
+			"default": "./src/lib/index.ts"
 		},
 		"./theme": {
-			"types": "./dist/theme.d.ts",
-			"svelte": "./dist/theme.js",
-			"default": "./dist/theme.js"
+			"svelte": "./src/lib/theme.ts",
+			"default": "./src/lib/theme.ts"
 		}
 	},
 	"files": [
@@ -50,7 +48,7 @@
 		"prettier": "^3.3.2",
 		"prettier-plugin-svelte": "^3.2.4",
 		"publint": "^0.1.9",
-		"svelte-check": "^3.8.0",
+		"svelte-check": "^3.8.2",
 		"tslib": "^2.4.1",
 		"typescript": "^5.0.0",
 		"vite": "^5.0.11"
diff --git a/packages/repl/src/lib/CodeMirror.svelte b/packages/repl/src/lib/CodeMirror.svelte
@@ -11,10 +11,10 @@
 	import { javascriptLanguage } from '@codemirror/lang-javascript';
 	import { createEventDispatcher, tick } from 'svelte';
 	import { writable } from 'svelte/store';
-	import { get_repl_context } from '$lib/context.js';
+	import { get_repl_context } from './context';
 	import Message from './Message.svelte';
-	import { svelteTheme } from './theme.js';
-	import { autocomplete } from './autocomplete.js';
+	import { svelteTheme } from './theme';
+	import { autocomplete } from './autocomplete';
 	import type { LintSource } from '@codemirror/lint';
 	import type { Extension } from '@codemirror/state';
 	import { CompletionContext } from '@codemirror/autocomplete';
@@ -207,11 +207,11 @@
 	const { files, selected } = get_repl_context();
 
 	const svelte_rune_completions = svelteLanguage.data.of({
-		autocomplete: (context: CompletionContext) => autocomplete(context, $selected, $files)
+		autocomplete: (context: CompletionContext) => autocomplete(context, $selected!, $files)
 	});
 
 	const js_rune_completions = javascriptLanguage.data.of({
-		autocomplete: (context: CompletionContext) => autocomplete(context, $selected, $files)
+		autocomplete: (context: CompletionContext) => autocomplete(context, $selected!, $files)
 	});
 </script>
 
diff --git a/packages/repl/src/lib/Input/ComponentSelector.svelte b/packages/repl/src/lib/Input/ComponentSelector.svelte
@@ -1,18 +1,18 @@
 <script lang="ts">
-	import { get_repl_context } from '$lib/context.js';
-	import { get_full_filename } from '$lib/utils.js';
+	import { get_repl_context } from '../context';
+	import { get_full_filename } from '../utils';
 	import { createEventDispatcher, tick } from 'svelte';
 	import RunesInfo from './RunesInfo.svelte';
 	import Migrate from './Migrate.svelte';
-	import type { File } from '$lib/types';
+	import type { File } from '../types';
 
 	export let show_modified: boolean;
 	export let runes: boolean;
 
 	const dispatch: ReturnType<
 		typeof createEventDispatcher<{
-			remove: { files: import('$lib/types').File[]; diff: import('$lib/types').File };
-			add: { files: import('$lib/types').File[]; diff: import('$lib/types').File };
+			remove: { files: File[]; diff: File };
+			add: { files: File[]; diff: File };
 		}>
 	> = createEventDispatcher();
 
diff --git a/packages/repl/src/lib/Input/Migrate.svelte b/packages/repl/src/lib/Input/Migrate.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import { get_repl_context } from '$lib/context.js';
+	import { get_repl_context } from '../context';
 
 	const { migrate } = get_repl_context();
 </script>
diff --git a/packages/repl/src/lib/Input/ModuleEditor.svelte b/packages/repl/src/lib/Input/ModuleEditor.svelte
@@ -1,9 +1,9 @@
 <script lang="ts">
-	import { get_repl_context } from '$lib/context.js';
+	import { get_repl_context } from '../context';
 	import CodeMirror from '../CodeMirror.svelte';
 	import type { CompileError, Warning } from 'svelte/compiler';
 
-	export let error: CompileError;
+	export let error: CompileError | undefined;
 	export let warnings: Warning[];
 	export let vim: boolean;
 
@@ -23,8 +23,8 @@
 					return [
 						{
 							severity: 'error',
-							from: error.position[0],
-							to: error.position[1],
+							from: error.position![0],
+							to: error.position![1],
 							message: error.message,
 							renderMessage: () => {
 								// TODO expose error codes, so we can link to docs in future
@@ -42,8 +42,8 @@
 				if (warnings) {
 					return warnings.map((warning) => ({
 						severity: 'warning',
-						from: warning.start.character,
-						to: warning.end.character,
+						from: warning.start!.character,
+						to: warning.end!.character,
 						message: warning.message,
 						renderMessage: () => {
 							const span = document.createElement('span');
diff --git a/packages/repl/src/lib/Input/RunesInfo.svelte b/packages/repl/src/lib/Input/RunesInfo.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import { get_repl_context } from '$lib/context.js';
+	import { get_repl_context } from '../context';
 
 	let { runes }: { runes: boolean } = $props();
 
diff --git a/packages/repl/src/lib/Message.svelte b/packages/repl/src/lib/Message.svelte
@@ -4,7 +4,7 @@
 	import type { MessageDetails } from './types.js';
 
 	export let kind: 'info' | 'warning' | 'error' = 'info';
-	export let details: MessageDetails | undefined = undefined;
+	export let details: any | undefined = undefined;
 	export let filename: string | undefined = undefined;
 	export let truncate = false;
 
diff --git a/packages/repl/src/lib/Output/AstNode.svelte b/packages/repl/src/lib/Output/AstNode.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import { get_repl_context } from '$lib/context.js';
+	import { get_repl_context } from '../context';
 	import { tick } from 'svelte';
 	import type { CompileResult } from 'svelte/compiler';
 
diff --git a/packages/repl/src/lib/Output/Compiler.ts b/packages/repl/src/lib/Output/Compiler.ts
@@ -1,7 +1,7 @@
-import type { File } from '$lib/types';
+import type { File } from '../types';
 import type { CompileOptions } from 'svelte/compiler';
 import Worker from '../workers/compiler/index.js?worker';
-import type { CompilerOutput, MigrateOutput } from '$lib/workers/workers';
+import type { CompilerOutput, MigrateOutput } from '../workers/workers';
 
 const workers = new Map();
 
diff --git a/packages/repl/src/lib/Output/CompilerOptions.svelte b/packages/repl/src/lib/Output/CompilerOptions.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import { get_repl_context } from '$lib/context.js';
+	import { get_repl_context } from '../context';
 	import Checkbox from '../Checkbox.svelte';
 
 	const { compile_options } = get_repl_context();
@@ -20,7 +20,7 @@
 	<!-- svelte-ignore a11y_label_has_associated_control (TODO this warning should probably be disabled if there's a component)-->
 	<label class="option">
 		<span class="key">dev:</span>
-		<Checkbox bind:checked={$compile_options.dev} />
+		<Checkbox bind:checked={$compile_options.dev!} />
 		<span class="boolean">{$compile_options.dev}</span>,
 	</label>
 	});
diff --git a/packages/repl/src/lib/Output/Output.svelte b/packages/repl/src/lib/Output/Output.svelte
@@ -1,16 +1,16 @@
 <script lang="ts">
-	import { get_repl_context } from '$lib/context.js';
+	import { get_repl_context } from '../context';
 	import { marked } from 'marked';
 	import CodeMirror from '../CodeMirror.svelte';
 	import AstView from './AstView.svelte';
 	import CompilerOptions from './CompilerOptions.svelte';
 	import PaneWithPanel from './PaneWithPanel.svelte';
 	import Viewer from './Viewer.svelte';
-	import type { File, MessageDetails } from '$lib/types';
-	import type { CompilerOutput } from '$lib/workers/workers';
+	import type { File, MessageDetails } from '../types';
+	import type { CompilerOutput } from '../workers/workers';
 
 	export let status: string | null;
-	export let runtimeError: MessageDetails | null = null;
+	export let runtimeError: Error | null = null;
 	export let embedded = false;
 	export let relaxed = false;
 	export let injectedJS: string;
diff --git a/packages/repl/src/lib/Output/Viewer.svelte b/packages/repl/src/lib/Output/Viewer.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import { get_repl_context } from '$lib/context.js';
+	import { get_repl_context } from '../context';
 	import { BROWSER } from 'esm-env';
 	import { onMount } from 'svelte';
 	import Message from '../Message.svelte';
@@ -10,10 +10,10 @@
 	import srcdoc from './srcdoc/index.html?raw';
 	import ErrorOverlay from './ErrorOverlay.svelte';
 	import type { CompileError } from 'svelte/compiler';
-	import type { Bundle, MessageDetails } from '$lib/types';
+	import type { Bundle } from '../types';
 	import type { Log } from './console/console';
 
-	export let error: MessageDetails | null;
+	export let error: Error | null;
 	export let status: string | null;
 	export let relaxed = false;
 	export let injectedJS = '';
diff --git a/packages/repl/src/lib/Output/get-location-from-stack.ts b/packages/repl/src/lib/Output/get-location-from-stack.ts
@@ -1,7 +1,8 @@
-import type { StartOrEnd } from '$lib/types';
-import { decode, type SourceMapMappings } from '@jridgewell/sourcemap-codec';
+import { decode } from '@jridgewell/sourcemap-codec';
+import type { StartOrEnd } from '../types';
+import type { SourceMap } from '@rollup/browser';
 
-export default function getLocationFromStack(stack: string, map: SourceMapMappings) {
+export default function getLocationFromStack(stack: string, map: SourceMap) {
 	if (!stack) return;
 	const last = stack.split('\n')[1];
 	const match = /<anonymous>:(\d+):(\d+)\)$/.exec(last);
@@ -14,7 +15,7 @@ export default function getLocationFromStack(stack: string, map: SourceMapMappin
 	return trace({ line, column }, map);
 }
 
-function trace(loc: Omit<StartOrEnd, 'character'>, map) {
+function trace(loc: Omit<StartOrEnd, 'character'>, map: SourceMap) {
 	const mappings = decode(map.mappings);
 	const segments = mappings[loc.line - 1];
 
diff --git a/packages/repl/src/lib/index.ts b/packages/repl/src/lib/index.ts
@@ -0,0 +1,2 @@
+export { default as Repl } from './Repl.svelte';
+export type { File } from './types';
diff --git a/packages/repl/src/lib/workers/bundler/index.ts b/packages/repl/src/lib/workers/bundler/index.ts
@@ -1,16 +1,16 @@
-import '../patch_window.js';
-import { sleep } from '$lib/utils';
+import '../patch_window';
+import { sleep } from '../../utils';
 import { rollup } from '@rollup/browser';
 import { DEV } from 'esm-env';
 import * as resolve from 'resolve.exports';
-import commonjs from './plugins/commonjs.js';
-import glsl from './plugins/glsl.js';
-import json from './plugins/json.js';
-import replace from './plugins/replace.js';
-import loop_protect from './plugins/loop-protect.js';
+import commonjs from './plugins/commonjs';
+import glsl from './plugins/glsl';
+import json from './plugins/json';
+import replace from './plugins/replace';
+import loop_protect from './plugins/loop-protect';
 import type { Plugin, TransformResult } from '@rollup/browser';
-import type { BundleMessageData } from '../workers.js';
-import type { File, Warning } from '$lib/types.js';
+import type { BundleMessageData } from '../workers';
+import type { File, Warning } from '../../types';
 import type { CompileResult } from 'svelte/compiler';
 
 let packages_url: string;
@@ -435,7 +435,7 @@ async function bundle({ uid, files }: { uid: number; files: File[] }) {
 		console.log(`running Svelte compiler version %c${svelte.VERSION}`, 'font-weight: bold');
 	}
 
-	const lookup: Map<string, import('$lib/types').File> = new Map();
+	const lookup: Map<string, File> = new Map();
 
 	lookup.set('./__entry.js', {
 		name: '__entry',
diff --git a/packages/repl/svelte.config.js b/packages/repl/svelte.config.js
@@ -3,10 +3,6 @@ import { vitePreprocess } from '@sveltejs/vite-plugin-svelte';
 
 /** @type {import('@sveltejs/kit').Config} */
 const config = {
-	// Consult https://kit.svelte.dev/docs/integrations#preprocessors
-	// for more information about preprocessors
-	preprocess: vitePreprocess(),
-
 	kit: {
 		// adapter-auto only supports some environments, see https://kit.svelte.dev/docs/adapter-auto for a list.
 		// If your environment is not supported, or you settled on a specific environment, switch out the adapter.
diff --git a/packages/site-kit/package.json b/packages/site-kit/package.json
@@ -35,7 +35,7 @@
 		"prettier-plugin-svelte": "^3.2.4",
 		"shiki-twoslash": "^3.1.2",
 		"svelte": "^5.0.0-next.160",
-		"svelte-check": "^3.8.0",
+		"svelte-check": "^3.8.2",
 		"typescript": "^5.4.5",
 		"vite": "^5.2.11"
 	},
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
