(feat) svelte-check diagnostic-sources (#542)

#541
Decide which sources to use for diagnostics

Author: dummdidumm

packages/language-server/src/index.ts

@@ -1,3 +1,3 @@
 export * from './server';
 export { offsetAt } from './lib/documents';
-export { SvelteCheck, SvelteCheckOptions } from './svelte-check';
+export { SvelteCheck, SvelteCheckOptions, SvelteCheckDiagnosticSource } from './svelte-check';

packages/language-server/src/svelte-check.ts

@@ -1,12 +1,15 @@
 import { Document, DocumentManager } from './lib/documents';
 import { LSConfigManager } from './ls-config';
-import { CSSPlugin, HTMLPlugin, PluginHost, SveltePlugin, TypeScriptPlugin } from './plugins';
+import { CSSPlugin, PluginHost, SveltePlugin, TypeScriptPlugin } from './plugins';
 import { Diagnostic } from 'vscode-languageserver';
 import { Logger } from './logger';
 import { urlToPath, pathToUrl } from './utils';
 
+export type SvelteCheckDiagnosticSource = 'js' | 'css' | 'svelte';
+
 export interface SvelteCheckOptions {
     compilerWarnings?: Record<string, 'ignore' | 'error'>;
+    diagnosticSources?: SvelteCheckDiagnosticSource[];
 }
 
 /**
@@ -31,12 +34,24 @@ export class SvelteCheck {
                 compilerWarnings: options.compilerWarnings,
             },
         });
-        this.pluginHost.register(new SveltePlugin(this.configManager, {}));
-        this.pluginHost.register(new HTMLPlugin(this.docManager, this.configManager));
-        this.pluginHost.register(new CSSPlugin(this.docManager, this.configManager));
-        this.pluginHost.register(
-            new TypeScriptPlugin(this.docManager, this.configManager, [pathToUrl(workspacePath)]),
-        );
+        // No HTMLPlugin, it does not provide diagnostics
+        if (shouldRegister('svelte')) {
+            this.pluginHost.register(new SveltePlugin(this.configManager, {}));
+        }
+        if (shouldRegister('css')) {
+            this.pluginHost.register(new CSSPlugin(this.docManager, this.configManager));
+        }
+        if (shouldRegister('js')) {
+            this.pluginHost.register(
+                new TypeScriptPlugin(this.docManager, this.configManager, [
+                    pathToUrl(workspacePath),
+                ]),
+            );
+        }
+
+        function shouldRegister(source: SvelteCheckDiagnosticSource) {
+            return !options.diagnosticSources || options.diagnosticSources.includes(source);
+        }
     }
 
     /**

packages/svelte-check/README.md

@@ -62,6 +62,8 @@ Usage:
 
 `--compiler-warnings <code1:error|ignore,code2:error|ignore>` A list of Svelte compiler warning codes. Each entry defines whether that warning should be ignored or treated as an error. Warnings are comma-separated, between warning code and error level is a colon; all inside quotes. Example: --compiler-warnings "css-unused-selector:ignore,unused-export-let:error"
 
+`--diagnostic-sources <js,svelte,css>` A list of diagnostic sources which should run diagnostics on your code. Possible values are `js` (includes TS), `svelte`, `css`. Comma-separated, inside quotes. By default all are active. Example: --diagnostic-sources "js,svelte"
+
 ### More docs, preprocessor setup and troubleshooting
 
 [See here](/docs/README.md).

packages/svelte-check/src/index.ts

@@ -137,6 +137,9 @@ function instantiateWriter(myArgs: argv.ParsedArgs): Writer {
 function getOptions(myArgs: argv.ParsedArgs): SvelteCheckOptions {
     return {
         compilerWarnings: stringToObj(myArgs['compiler-warnings']),
+        diagnosticSources: <any>(
+            myArgs['diagnostic-sources']?.split(',')?.map((s: string) => s.trim())
+        ),
     };
 
     function stringToObj(str = '') {