Skip to content

Commit 7e697e8

Browse files
dummdidummSimon
and
Simon
authored
[fix] Adjust type imports to satisfy TS NodeNext moduleResolution (#5360)
Discovered through comment in #2040 This is necessary so people can use this new resolution mode and still get proper typings for things like $app/stores This isn't all that's needed though: - Vite 3 is needed so we get their exports map which makes vite/client resolve correctly - Svelte bump needed to properly expose CompileOptions. It's imported from a path which isn't accessible when adhering to export maps Co-authored-by: Simon <[email protected]>
1 parent b16fe9d commit 7e697e8

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

.changeset/healthy-wasps-poke.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/kit': patch
3+
---
4+
5+
Adjust type imports to satisfy TS NodeNext moduleResolution

packages/kit/types/index.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/// <reference types="svelte" />
22
/// <reference types="vite/client" />
33

4-
import './ambient';
4+
import './ambient.js';
55

66
import { CompileOptions } from 'svelte/types/compiler/interfaces';
77
import {
@@ -17,8 +17,8 @@ import {
1717
ResponseHeaders,
1818
RouteDefinition,
1919
TrailingSlash
20-
} from './private';
21-
import { SSRNodeLoader, SSRRoute, ValidatedConfig } from './internal';
20+
} from './private.js';
21+
import { SSRNodeLoader, SSRRoute, ValidatedConfig } from './internal.js';
2222

2323
export interface Adapter {
2424
name: string;

packages/kit/types/internal.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ import {
1212
ResolveOptions,
1313
Server,
1414
SSRManifest
15-
} from './index';
15+
} from './index.js';
1616
import {
1717
HttpMethod,
1818
JSONObject,
1919
MaybePromise,
2020
RequestOptions,
2121
ResponseHeaders,
2222
TrailingSlash
23-
} from './private';
23+
} from './private.js';
2424

2525
export interface ServerModule {
2626
Server: typeof InternalServer;

0 commit comments

Comments
 (0)