Skip to content

Commit aaba61f

Browse files
authored
fix: flat config would cause an error with non-svelte files (#711)
1 parent 76eeea3 commit aaba61f

File tree

6 files changed

+28
-7
lines changed

6 files changed

+28
-7
lines changed

.changeset/soft-suns-brush.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"eslint-plugin-svelte": patch
3+
---
4+
5+
fix: flat config would cause an error with non-svelte files

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@
115115
"@types/prismjs": "^1.26.3",
116116
"@types/semver": "^7.5.8",
117117
"@types/stylus": "^0.48.42",
118-
"@typescript-eslint/eslint-plugin": "^7.1.1",
119-
"@typescript-eslint/parser": "^7.1.1",
118+
"@typescript-eslint/eslint-plugin": "^7.3.0",
119+
"@typescript-eslint/parser": "^7.3.0",
120120
"@typescript/vfs": "^1.5.0",
121121
"acorn": "^8.11.3",
122122
"assert": "^2.1.0",

src/configs/flat/base.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@
44
import type { ESLint } from 'eslint';
55
export default [
66
{
7-
files: ['*.svelte', '**/*.svelte'],
87
plugins: {
98
get svelte(): ESLint.Plugin {
109
// eslint-disable-next-line @typescript-eslint/no-require-imports -- ignore
1110
return require('../../index');
1211
}
13-
},
12+
}
13+
},
14+
{
15+
files: ['*.svelte', '**/*.svelte'],
1416
languageOptions: {
1517
// eslint-disable-next-line @typescript-eslint/no-require-imports -- ignore
1618
parser: require('svelte-eslint-parser')

src/meta.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// IMPORTANT!
22
// This file has been automatically generated,
33
// in order to update its content execute "pnpm run update"
4-
export const name = 'eslint-plugin-svelte' as const;
5-
export const version = '2.36.0-next.11' as const;
4+
export const name = 'eslint-plugin-svelte';
5+
export const version = '2.36.0-next.11';

tests/src/configs/recommended.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,17 @@ describe('`all` config', () => {
5454
}
5555
]
5656
);
57+
58+
const resultWithJs = await linter.lintText(';', { filePath: 'test.js' });
59+
const messagesWithJs = resultWithJs[0].messages;
60+
61+
assert.deepStrictEqual(
62+
messagesWithJs.map((m) => ({
63+
ruleId: m.ruleId,
64+
line: m.line,
65+
message: m.message
66+
})),
67+
[]
68+
);
5769
});
5870
});

tools/update-rulesets.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,13 +110,15 @@ const baseContent = `/*
110110
import type { ESLint } from 'eslint';
111111
export default [
112112
{
113-
files: ["*.svelte", "**/*.svelte"],
114113
plugins: {
115114
get svelte(): ESLint.Plugin {
116115
// eslint-disable-next-line @typescript-eslint/no-require-imports -- ignore
117116
return require("../../index")
118117
}
119118
},
119+
},
120+
{
121+
files: ["*.svelte", "**/*.svelte"],
120122
languageOptions: {
121123
// eslint-disable-next-line @typescript-eslint/no-require-imports -- ignore
122124
parser: require('svelte-eslint-parser'),

0 commit comments

Comments
 (0)