chore: get rid of @sveltejs/ast-tooling (#534)

Co-authored-by: AdrianGonz97 <[email protected]>

Author: manuel3108

packages/ast-tooling/README.md

@@ -9,4 +9,4 @@ export type * from './addon/options.ts';
 export type * from './addon/config.ts';
 export type * from './addon/workspace.ts';
 
-export { Walker } from '@sveltejs/ast-tooling';
+export { Walker } from './tooling/index.ts';

packages/ast-tooling/package.json

@@ -41,15 +41,23 @@
 			"default": "./dist/parsers.js"
 		}
 	},
-	"dependencies": {
-		"@sveltejs/ast-tooling": "workspace:*"
-	},
 	"devDependencies": {
+		"@sveltejs/acorn-typescript": "^1.0.1",
 		"@sveltejs/clack-prompts": "workspace:*",
+		"@types/estree": "^1.0.6",
+		"acorn": "^8.14.0",
 		"decircular": "^1.0.0",
 		"dedent": "^1.5.3",
+		"dom-serializer": "^2.0.0",
+		"domhandler": "^5.0.3",
+		"domutils": "^3.1.0",
+		"esrap": "^1.4.5",
+		"htmlparser2": "^9.1.0",
 		"magic-string": "^0.30.15",
-		"picocolors": "^1.1.1"
+		"picocolors": "^1.1.1",
+		"postcss": "^8.4.49",
+		"silver-fleece": "^1.2.1",
+		"zimmerframe": "^1.1.2"
 	},
 	"keywords": [
 		"create",

packages/ast-tooling/tsconfig.json

@@ -3,7 +3,7 @@ import { join, resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import prettier from 'prettier';
 import { describe, expect, test } from 'vitest';
-import { parseCss, serializeCss } from '@sveltejs/ast-tooling';
+import { parseCss, serializeCss } from '../../tooling/index.ts';
 
 const baseDir = resolve(fileURLToPath(import.meta.url), '..');
 const categoryDirectories = getDirectoryNames(baseDir);

packages/ast-tooling/utils.ts

@@ -3,7 +3,7 @@ import { join, resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import prettier from 'prettier';
 import { describe, expect, test } from 'vitest';
-import { parseHtml, serializeHtml } from '@sveltejs/ast-tooling';
+import { parseHtml, serializeHtml } from '../../tooling/index.ts';
 
 const baseDir = resolve(fileURLToPath(import.meta.url), '..');
 const categoryDirectories = getDirectoryNames(baseDir);

packages/ast-tooling/vitest.config.ts

@@ -3,7 +3,7 @@ import { join, resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import prettier from 'prettier';
 import { describe, expect, test } from 'vitest';
-import { parseScript, serializeScript } from '@sveltejs/ast-tooling';
+import { parseScript, serializeScript } from '../../tooling/index.ts';
 
 const baseDir = resolve(fileURLToPath(import.meta.url), '..');
 const categoryDirectories = getDirectoryNames(baseDir);

packages/core/index.ts

@@ -1,7 +1,12 @@
 import { expect, test } from 'vitest';
 import dedent from 'dedent';
-import { guessIndentString, guessQuoteStyle } from '../utils.ts';
-import { parseScript, serializeScript, type AstTypes } from '../index.ts';
+import {
+	parseScript,
+	serializeScript,
+	guessIndentString,
+	guessQuoteStyle,
+	type AstTypes
+} from '../tooling/index.ts';
 
 test('guessIndentString - one tab', () => {
 	const code = dedent`

packages/core/package.json

@@ -1,11 +1,4 @@
-import {
-	Declaration,
-	Rule,
-	AtRule,
-	Comment,
-	type CssAst,
-	type CssChildNode
-} from '@sveltejs/ast-tooling';
+import { Declaration, Rule, AtRule, Comment, type CssAst, type CssChildNode } from '../index.ts';
 
 export type { CssAst };
 

packages/core/tests/css/index.ts

@@ -5,7 +5,7 @@ import {
 	HtmlElement,
 	HtmlElementType,
 	parseHtml
-} from '@sveltejs/ast-tooling';
+} from '../index.ts';
 import { addFromString } from '../js/common.ts';
 
 export { HtmlElement, HtmlElementType };

packages/core/tests/html/index.ts

@@ -1,3 +1,5 @@
+import * as Walker from 'zimmerframe';
+import type { TsEstree } from './js/ts-estree.ts';
 import { Document, Element, type ChildNode } from 'domhandler';
 import { ElementType, parseDocument } from 'htmlparser2';
 import serializeDom from 'dom-serializer';
@@ -11,21 +13,10 @@ import {
 	type ChildNode as CssChildNode
 } from 'postcss';
 import * as fleece from 'silver-fleece';
-import * as Walker from 'zimmerframe';
-import type { TsEstree } from './ts-estree.ts';
-import { guessIndentString, guessQuoteStyle } from './utils.ts';
 import { print as esrapPrint } from 'esrap';
 import * as acorn from 'acorn';
 import { tsPlugin } from '@sveltejs/acorn-typescript';
 
-/**
- * Most of the AST tooling is pretty big in bundle size and bundling takes forever.
- * Nevertheless bundling of these tools seems smart, as they add many dependencies to each install.
- * In order to avoid long bundling during development, all of the AST tools have been extracted
- * into this separate package and are bundled only here. This package has been marked as external
- * and will not be bundled into all other projects / bundles.
- */
-
 export {
 	// html
 	Document as HtmlDocument,
@@ -179,3 +170,73 @@ export function serializeJson(originalInput: string, data: unknown): string {
 
 	return fleece.stringify(data, { spaces });
 }
+
+// Sourced from `golden-fleece`
+// https://github.com/Rich-Harris/golden-fleece/blob/f2446f331640f325e13609ed99b74b6a45e755c2/src/patch.ts#L302
+export function guessIndentString(str: string | undefined): string {
+	if (!str) return '\t';
+
+	const lines = str.split('\n');
+
+	let tabs = 0;
+	let spaces = 0;
+	let minSpaces = 8;
+
+	lines.forEach((line) => {
+		const match = /^(?: +|\t+)/.exec(line);
+		if (!match) return;
+
+		const whitespace = match[0];
+		if (whitespace.length === line.length) return;
+
+		if (whitespace[0] === '\t') {
+			tabs += 1;
+		} else {
+			spaces += 1;
+			if (whitespace.length > 1 && whitespace.length < minSpaces) {
+				minSpaces = whitespace.length;
+			}
+		}
+	});
+
+	if (spaces > tabs) {
+		let result = '';
+		while (minSpaces--) result += ' ';
+		return result;
+	} else {
+		return '\t';
+	}
+}
+
+export function guessQuoteStyle(ast: TsEstree.Node): 'single' | 'double' | undefined {
+	let singleCount = 0;
+	let doubleCount = 0;
+
+	Walker.walk(ast, null, {
+		Literal(node) {
+			if (node.raw && node.raw.length >= 2) {
+				// we have at least two characters in the raw string that could represent both quotes
+				const quotes = [node.raw[0], node.raw[node.raw.length - 1]];
+				for (const quote of quotes) {
+					switch (quote) {
+						case "'":
+							singleCount++;
+							break;
+						case '"':
+							doubleCount++;
+							break;
+						default:
+							break;
+					}
+				}
+			}
+		}
+	});
+
+	if (singleCount === 0 && doubleCount === 0) {
+		// new file or file without any quotes
+		return undefined;
+	}
+
+	return singleCount > doubleCount ? 'single' : 'double';
+}

packages/core/tests/js/index.ts

@@ -1,5 +1,5 @@
 import { areNodesEqual } from './common.ts';
-import type { AstTypes } from '@sveltejs/ast-tooling';
+import type { AstTypes } from '../index.ts';
 
 export function createEmpty(): AstTypes.ArrayExpression {
 	const arrayExpression: AstTypes.ArrayExpression = {

packages/ast-tooling/tests/utils.ts renamed to packages/core/tests/utils.ts

@@ -1,10 +1,4 @@
-import {
-	type AstTypes,
-	Walker,
-	parseScript,
-	serializeScript,
-	stripAst
-} from '@sveltejs/ast-tooling';
+import { type AstTypes, Walker, parseScript, serializeScript, stripAst } from '../index.ts';
 import decircular from 'decircular';
 import dedent from 'dedent';
 

packages/core/tooling/css/index.ts

@@ -1,4 +1,4 @@
-import type { AstTypes } from '@sveltejs/ast-tooling';
+import type { AstTypes } from '../index.ts';
 
 export type ExportDefaultReturn<T> = {
 	astNode: AstTypes.ExportDefaultDeclaration;

packages/core/tooling/html/index.ts

@@ -1,4 +1,4 @@
-import type { AstTypes } from '@sveltejs/ast-tooling';
+import type { AstTypes } from '../index.ts';
 
 export function call(name: string, args: string[]): AstTypes.CallExpression {
 	const callExpression: AstTypes.CallExpression = {

packages/ast-tooling/index.ts renamed to packages/core/tooling/index.ts

@@ -1,4 +1,4 @@
-import { Walker, type AstTypes } from '@sveltejs/ast-tooling';
+import { Walker, type AstTypes } from '../index.ts';
 import { areNodesEqual } from './common.ts';
 
 export function addEmpty(ast: AstTypes.Program, importFrom: string): void {

packages/core/tooling/js/array.ts

@@ -6,4 +6,4 @@ export * as imports from './imports.ts';
 export * as variables from './variables.ts';
 export * as exports from './exports.ts';
 export * as kit from './kit.ts';
-export type { AstTypes } from '@sveltejs/ast-tooling';
+export type { AstTypes } from '../index.ts';

packages/core/tooling/js/common.ts

@@ -1,4 +1,4 @@
-import { Walker, type AstTypes } from '@sveltejs/ast-tooling';
+import { Walker, type AstTypes } from '../index.ts';
 import { common, functions, imports, variables, exports } from '../js/index.ts';
 
 export function addGlobalAppInterface(

packages/core/tooling/js/exports.ts

@@ -1,4 +1,4 @@
-import type { AstTypes } from '@sveltejs/ast-tooling';
+import type { AstTypes } from '../index.ts';
 
 export function property<T extends AstTypes.Expression | AstTypes.Identifier>(
 	ast: AstTypes.ObjectExpression,

packages/core/tooling/js/function.ts

@@ -1,4 +1,4 @@
-import type { AstTypes } from '@sveltejs/ast-tooling';
+import type { AstTypes } from '../index.ts';
 
 export function declaration(
 	ast: AstTypes.Program | AstTypes.Declaration,