Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onComplete Event Saturation #49

Open
alex12de opened this issue Jan 6, 2021 · 1 comment
Open

onComplete Event Saturation #49

alex12de opened this issue Jan 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@alex12de
Copy link

alex12de commented Jan 6, 2021

When the user fills all the inputs and the onComplete fires if the user keeps pressing a number in the keyboard the onComplete events keep firing again and again.

I think that the deseable result is that the onComplete function only can be fired once when the last input is empty and the user press a key.

Maybe the solution is add a prop to do something when the input is complete maybe clear all the fields or stop this behaviour, or both options in one prop.
@suweya suweya added the enhancement New feature or request label Jan 16, 2021
DarkCode01 added a commit to DarkCode01/react-verification-code-input that referenced this issue Jan 26, 2021
@DarkCode01
feat: fire onComplete handle once when the fields are filled (suweya#49)
ee7c3c5
@DarkCode01
Copy link

i created a PR with the solution #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suweya @DarkCode01 @alex12de