Merge pull request #174 from supertokens/fix/webauthn-review-fixes

fix: webauthn review fixes

Author: tamassoltesz

src/main/java/io/supertokens/pluginInterface/webauthn/WebAuthNStorage.java

@@ -19,15 +19,19 @@
 import io.supertokens.pluginInterface.authRecipe.AuthRecipeStorage;
 import io.supertokens.pluginInterface.exceptions.StorageQueryException;
 import io.supertokens.pluginInterface.multitenancy.TenantIdentifier;
+import io.supertokens.pluginInterface.multitenancy.exceptions.TenantOrAppNotFoundException;
 import io.supertokens.pluginInterface.webauthn.exceptions.*;
 
 import java.util.List;
 
 public interface WebAuthNStorage extends AuthRecipeStorage {
 
-    WebAuthNStoredCredential saveCredentials(TenantIdentifier tenantIdentifier, WebAuthNStoredCredential credential) throws StorageQueryException;
+    WebAuthNStoredCredential saveCredentials(TenantIdentifier tenantIdentifier, WebAuthNStoredCredential credential)
+            throws StorageQueryException, DuplicateCredentialException, UserIdNotFoundException,
+            TenantOrAppNotFoundException;
 
-    WebAuthNOptions saveGeneratedOptions(TenantIdentifier tenantIdentifier, WebAuthNOptions optionsToSave) throws StorageQueryException;
+    WebAuthNOptions saveGeneratedOptions(TenantIdentifier tenantIdentifier, WebAuthNOptions optionsToSave)
+            throws StorageQueryException, DuplicateOptionsIdException, TenantOrAppNotFoundException;
 
     WebAuthNOptions loadOptionsById(TenantIdentifier tenantIdentifier, String optionsId) throws  StorageQueryException;
 

src/main/java/io/supertokens/pluginInterface/webauthn/exceptions/DuplicateCredentialException.java

@@ -0,0 +1,22 @@
+/*
+ *    Copyright (c) 2025, VRAI Labs and/or its affiliates. All rights reserved.
+ *
+ *    This software is licensed under the Apache License, Version 2.0 (the
+ *    "License") as published by the Apache Software Foundation.
+ *
+ *    You may not use this file except in compliance with the License. You may
+ *    obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ *    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ *    License for the specific language governing permissions and limitations
+ *    under the License.
+ */
+
+package io.supertokens.pluginInterface.webauthn.exceptions;
+
+public class DuplicateCredentialException extends Exception {
+    public DuplicateCredentialException() {}
+
+}

src/main/java/io/supertokens/pluginInterface/webauthn/exceptions/DuplicateOptionsIdException.java

@@ -0,0 +1,22 @@
+/*
+ *    Copyright (c) 2025, VRAI Labs and/or its affiliates. All rights reserved.
+ *
+ *    This software is licensed under the Apache License, Version 2.0 (the
+ *    "License") as published by the Apache Software Foundation.
+ *
+ *    You may not use this file except in compliance with the License. You may
+ *    obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ *    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ *    License for the specific language governing permissions and limitations
+ *    under the License.
+ */
+
+package io.supertokens.pluginInterface.webauthn.exceptions;
+
+public class DuplicateOptionsIdException extends Exception {
+    public DuplicateOptionsIdException() {
+    }
+}

src/main/java/io/supertokens/pluginInterface/webauthn/slqStorage/WebAuthNSQLStorage.java

@@ -32,9 +32,6 @@
 
 public interface WebAuthNSQLStorage extends WebAuthNStorage, SQLStorage {
 
-    WebAuthNStoredCredential saveCredentials_Transaction(TenantIdentifier tenantIdentifier, TransactionConnection con,
-                                                         WebAuthNStoredCredential credential) throws StorageQueryException;
-
     WebAuthNOptions loadOptionsById_Transaction(TenantIdentifier tenantIdentifier,  TransactionConnection con, String optionsId) throws  StorageQueryException;
 
     WebAuthNStoredCredential loadCredentialById_Transaction(TenantIdentifier tenantIdentifier, TransactionConnection con, String credentialId) throws StorageQueryException;