fix: self-review fixes

Author: tamassoltesz

src/main/java/io/supertokens/authRecipe/AuthRecipe.java

@@ -1051,7 +1051,7 @@ public static AuthRecipeUserInfo[] getUsersByAccountInfo(TenantIdentifier tenant
                 null);
     }
 
-    // TODO: revisit this when writing tests
+
     public static AuthRecipeUserInfo[] getUsersByAccountInfo(TenantIdentifier tenantIdentifier,
                                                              Storage storage,
                                                              boolean doUnionOfAccountInfo, String email,

src/main/java/io/supertokens/inmemorydb/queries/GeneralQueries.java

@@ -1364,7 +1364,6 @@ public static AuthRecipeUserInfo getPrimaryUserByWebauthNCredentialId(Start star
                                                                           TenantIdentifier tenantIdentifier,
                                                                           String credentialId)
             throws StorageQueryException, SQLException, StorageTransactionLogicException {
-        // TODO: revisit this. Seems like we are loading the same data multiple times
         AuthRecipeUserInfo webauthnUser = start.startTransaction(con -> {
             try {
                 Connection sqlCon = (Connection) con.getConnection();

src/main/java/io/supertokens/webauthn/WebAuthN.java

@@ -298,7 +298,7 @@ public static WebAuthNSignInUpResult signUp(Storage storage, TenantIdentifier te
                         AuthRecipeUserInfo userInfo = webAuthNStorage.signUpWithCredentialsRegister_Transaction(
                                 tenantIdentifier, con, recipeUserId, generatedOptions.userEmail,
                                 generatedOptions.relyingPartyId, credentialToSave);
-                        userInfo.setExternalUserId(null); //TODO revisit this
+                        userInfo.setExternalUserId(null);
 
                         return new WebAuthNSignInUpResult(credentialToSave, userInfo, generatedOptions);
                     } catch (DuplicateUserIdException duplicateUserIdException) {
@@ -487,7 +487,7 @@ private static WebAuthNOptions saveGeneratedOptions(TenantIdentifier tenantIdent
 
     public static String generateRecoverAccountToken(Main main, Storage storage, TenantIdentifier tenantIdentifier, String email)
             throws NoSuchAlgorithmException, InvalidKeySpecException, TenantOrAppNotFoundException,
-            StorageQueryException {
+            StorageQueryException, WebAuthNEmailNotFoundException {
         // find the recipe user with the email
         AuthRecipeUserInfo[] users = AuthRecipe.getUsersByAccountInfo(tenantIdentifier, storage, true, email, null,
                 null, null, null);
@@ -538,7 +538,7 @@ tenantIdentifier, new AccountRecoveryTokenInfo(userId,
     }
 
     public static AccountRecoveryTokenInfo consumeRecoverAccountToken(Main main, TenantIdentifier tenantIdentifier, Storage storage, String token)
-            throws StorageQueryException, NoSuchAlgorithmException {
+            throws StorageQueryException, NoSuchAlgorithmException, InvalidTokenException {
         WebAuthNSQLStorage webauthnStorage = StorageUtils.getWebAuthNStorage(storage);
 
         String hashedToken = Utils.hashSHA256(token);

src/main/java/io/supertokens/webauthn/exception/InvalidTokenException.java

@@ -16,5 +16,5 @@
 
 package io.supertokens.webauthn.exception;
 
-public class InvalidTokenException extends RuntimeException {
+public class InvalidTokenException extends Exception {
 }

src/main/java/io/supertokens/webauthn/exception/WebAuthNEmailNotFoundException.java

@@ -16,5 +16,5 @@
 
 package io.supertokens.webauthn.exception;
 
-public class WebAuthNEmailNotFoundException extends RuntimeException {
+public class WebAuthNEmailNotFoundException extends Exception {
 }