Skip to content

Bump requeue timeout #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bump requeue timeout #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions percona/controller/pgbackup/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ func (r *PGBackupReconciler) SetupWithManager(mgr manager.Manager) error {
Complete(r))
}

const (
requeueTimeout = time.Second * 15
)

// +kubebuilder:rbac:groups=pgv2.percona.com,resources=perconapgbackups,verbs=create;get;list;watch;update;delete;patch
// +kubebuilder:rbac:groups=pgv2.percona.com,resources=perconapgbackups/status,verbs=create;patch;update
// +kubebuilder:rbac:groups=pgv2.percona.com,resources=perconapgclusters,verbs=get;list;create;update;patch;watch
Expand Down Expand Up @@ -82,7 +86,7 @@ func (r *PGBackupReconciler) Reconcile(ctx context.Context, request reconcile.Re
if _, err := runFinalizers(ctx, r.Client, pgBackup); err != nil {
return reconcile.Result{}, errors.Wrap(err, "failed to run finalizers")
}
return reconcile.Result{RequeueAfter: time.Second * 5}, nil
return reconcile.Result{RequeueAfter: requeueTimeout}, nil
}

if pgBackup.Status.State != v2.BackupFailed && pgBackup.Status.State != v2.BackupSucceeded {
Expand All @@ -101,7 +105,7 @@ func (r *PGBackupReconciler) Reconcile(ctx context.Context, request reconcile.Re

if pgCluster.Spec.Pause != nil && *pgCluster.Spec.Pause {
log.Info("Can't start backup. PostgresCluster is paused", "pg-backup", pgBackup.Name, "cluster", pgCluster.Name)
return reconcile.Result{RequeueAfter: time.Second * 5}, nil
return reconcile.Result{RequeueAfter: requeueTimeout}, nil
}

// start backup only if backup job doesn't exist
Expand All @@ -117,7 +121,7 @@ func (r *PGBackupReconciler) Reconcile(ctx context.Context, request reconcile.Re
}
if runningBackup != "" && runningBackup != pgBackup.Name {
log.Info("Can't start backup. Previous backup is still in progress", "pg-backup", pgBackup.Name, "cluster", pgCluster.Name)
return reconcile.Result{RequeueAfter: time.Second * 5}, nil
return reconcile.Result{RequeueAfter: requeueTimeout}, nil
}
if err := startBackup(ctx, r.Client, pgBackup); err != nil {
return reconcile.Result{}, errors.Wrap(err, "failed to start backup")
Expand Down Expand Up @@ -172,7 +176,7 @@ func (r *PGBackupReconciler) Reconcile(ctx context.Context, request reconcile.Re
if errors.Is(err, ErrBackupJobNotFound) {
log.Info("Waiting for backup to start")

return reconcile.Result{RequeueAfter: time.Second * 5}, nil
return reconcile.Result{RequeueAfter: requeueTimeout}, nil
}
return reconcile.Result{}, errors.Wrap(err, "find backup job")
}
Expand Down Expand Up @@ -228,7 +232,7 @@ func (r *PGBackupReconciler) Reconcile(ctx context.Context, request reconcile.Re
log.Info("Backup succeeded")
default:
log.Info("Waiting for backup to complete")
return reconcile.Result{RequeueAfter: time.Second * 5}, nil
return reconcile.Result{RequeueAfter: requeueTimeout}, nil
}

pgCluster := &v2.PerconaPGCluster{}
Expand All @@ -247,7 +251,7 @@ func (r *PGBackupReconciler) Reconcile(ctx context.Context, request reconcile.Re
}
if !done {
log.Info("Waiting for crunchy reconciler to finish")
return reconcile.Result{RequeueAfter: time.Second * 5}, nil
return reconcile.Result{RequeueAfter: requeueTimeout}, nil
}

if err := retry.RetryOnConflict(retry.DefaultBackoff, func() error {
Expand Down Expand Up @@ -614,7 +618,7 @@ func finishBackup(ctx context.Context, c client.Client, pgBackup *v2.PerconaPGBa
// If we delete the job labels without waiting for the reconcile to finish, the Crunchy reconciler will
// receive the pgcluster with the "naming.PGBackRestBackup" annotation, but will not find the manual backup job.
// It will attempt to create a new job with the same name, failing and resulting in a scary error in the logs.
return &reconcile.Result{RequeueAfter: time.Second * 5}, nil
return &reconcile.Result{RequeueAfter: requeueTimeout}, nil
}

// Remove PGBackRest labels to prevent the job from being
Expand Down Expand Up @@ -653,7 +657,7 @@ func finishBackup(ctx context.Context, c client.Client, pgBackup *v2.PerconaPGBa
return nil, errors.Wrapf(err, "delete %s annotation", pNaming.AnnotationBackupInProgress)
}
if !deleted {
return &reconcile.Result{RequeueAfter: time.Second * 5}, nil
return &reconcile.Result{RequeueAfter: requeueTimeout}, nil
}

if checkBackupJob(job) != v2.BackupSucceeded {
Expand Down
Loading