Skip to content

Commit 1862686

Browse files
authored
Merge pull request #11 from superfly/gorbak/db-version-error-logging
Log error when insert_db_version fails
2 parents 44c2120 + 1d7fabf commit 1862686

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

core/rs/core/src/changes_vtab_write.rs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,14 @@ unsafe fn merge_insert(
704704

705705
// Update the received db_version whether the change won or not.
706706
if res.is_ok() && !insert_site_id.is_empty() {
707-
insert_db_version((*tab).pExtData, insert_site_id, insert_db_vrsn)?;
707+
if let Err(rc) = insert_db_version((*tab).pExtData, insert_site_id, insert_db_vrsn) {
708+
let err = CString::new(format!(
709+
"Unable to insert db version {} for site id {:?}",
710+
insert_db_vrsn, insert_site_id
711+
))?;
712+
*errmsg = err.into_raw();
713+
return Err(rc);
714+
}
708715
}
709716

710717
res

0 commit comments

Comments
 (0)