feat: expand deprecation warning to cover Node.js <= 18

- Change logic from checking exactly Node.js 18 to checking versions <= 18
- Update warning message to reflect 'Node.js 18 and below are deprecated'
- Extract version parsing with proper error handling for null/malformed versions
- Add tests for Node.js 16, 17, and 14 to verify warning appears
- Improve robustness by adding null check for process.version

BREAKING CHANGE: Warning now appears for Node.js 16 and 17 in addition to 18

Author: grdsdev

src/index.ts

@@ -40,19 +40,29 @@ export const createClient = <
   return new SupabaseClient<Database, SchemaName, Schema>(supabaseUrl, supabaseKey, options)
 }
 
-// Check for Node.js 18 deprecation
+// Check for Node.js <= 18 deprecation
 function shouldShowDeprecationWarning(): boolean {
-  return (
-    typeof window === 'undefined' &&
-    typeof process !== 'undefined' &&
-    process.version !== undefined &&
-    /^v18\./.test(process.version)
-  )
+  if (
+    typeof window !== 'undefined' ||
+    typeof process === 'undefined' ||
+    process.version === undefined ||
+    process.version === null
+  ) {
+    return false
+  }
+
+  const versionMatch = process.version.match(/^v(\d+)\./)
+  if (!versionMatch) {
+    return false
+  }
+
+  const majorVersion = parseInt(versionMatch[1], 10)
+  return majorVersion <= 18
 }
 
 if (shouldShowDeprecationWarning()) {
   console.warn(
-    `⚠️  Node.js 18 is deprecated and will no longer be supported in future versions of @supabase/supabase-js. ` +
+    `⚠️  Node.js 18 and below are deprecated and will no longer be supported in future versions of @supabase/supabase-js. ` +
       `Please upgrade to Node.js 20 or later. ` +
       `For more information, visit: https://github.com/orgs/supabase/discussions/37217`
   )

test/unit/deprecation-warning.test.ts

@@ -6,7 +6,7 @@ const originalConsoleWarn = console.warn
 // Make this a module to fix TypeScript error
 export {}
 
-describe('Node.js 18 Deprecation Warning', () => {
+describe('Node.js <= 18 Deprecation Warning', () => {
   let mockConsoleWarn: jest.SpyInstance
 
   beforeEach(() => {
@@ -42,7 +42,7 @@ describe('Node.js 18 Deprecation Warning', () => {
       require('../../src/index')
 
       expect(mockConsoleWarn).toHaveBeenCalledWith(
-        expect.stringContaining('⚠️  Node.js 18 is deprecated')
+        expect.stringContaining('⚠️  Node.js 18 and below are deprecated')
       )
       expect(mockConsoleWarn).toHaveBeenCalledWith(
         expect.stringContaining('Please upgrade to Node.js 20 or later')
@@ -100,7 +100,7 @@ describe('Node.js 18 Deprecation Warning', () => {
       expect(mockConsoleWarn).not.toHaveBeenCalled()
     })
 
-    test('should NOT show warning for Node.js 16.20.0', () => {
+    test('should show warning for Node.js 16.20.0', () => {
       delete (global as any).window
       global.process = {
         ...originalProcess,
@@ -109,7 +109,31 @@ describe('Node.js 18 Deprecation Warning', () => {
 
       require('../../src/index')
 
-      expect(mockConsoleWarn).not.toHaveBeenCalled()
+      expect(mockConsoleWarn).toHaveBeenCalled()
+    })
+
+    test('should show warning for Node.js 17.9.1', () => {
+      delete (global as any).window
+      global.process = {
+        ...originalProcess,
+        version: 'v17.9.1',
+      } as NodeJS.Process
+
+      require('../../src/index')
+
+      expect(mockConsoleWarn).toHaveBeenCalled()
+    })
+
+    test('should show warning for Node.js 14.21.3', () => {
+      delete (global as any).window
+      global.process = {
+        ...originalProcess,
+        version: 'v14.21.3',
+      } as NodeJS.Process
+
+      require('../../src/index')
+
+      expect(mockConsoleWarn).toHaveBeenCalled()
     })
 
     test('should NOT show warning when window is defined (browser environment)', () => {
@@ -133,8 +157,7 @@ describe('Node.js 18 Deprecation Warning', () => {
       const shouldShow =
         typeof mockWindow === 'undefined' &&
         typeof mockProcess !== 'undefined' &&
-        (mockProcess as any)?.version !== undefined &&
-        /^v18\./.test((mockProcess as any)?.version || '')
+        (mockProcess as any)?.version !== undefined
 
       expect(shouldShow).toBe(false)
       expect(mockConsoleWarn).not.toHaveBeenCalled()
@@ -152,7 +175,7 @@ describe('Node.js 18 Deprecation Warning', () => {
       expect(mockConsoleWarn).not.toHaveBeenCalled()
     })
 
-    test('should NOT show warning for version string "18" without "v" prefix', () => {
+    test('should NOT show warning for version string "18" without "v" prefix (malformed)', () => {
       delete (global as any).window
       global.process = {
         ...originalProcess,
@@ -164,7 +187,7 @@ describe('Node.js 18 Deprecation Warning', () => {
       expect(mockConsoleWarn).not.toHaveBeenCalled()
     })
 
-    test('should NOT show warning for version containing "18" but not starting with "v18."', () => {
+    test('should show warning for version v1.18.0 (major version 1)', () => {
       delete (global as any).window
       global.process = {
         ...originalProcess,
@@ -173,7 +196,7 @@ describe('Node.js 18 Deprecation Warning', () => {
 
       require('../../src/index')
 
-      expect(mockConsoleWarn).not.toHaveBeenCalled()
+      expect(mockConsoleWarn).toHaveBeenCalled()
     })
   })
 
@@ -207,7 +230,7 @@ describe('Node.js 18 Deprecation Warning', () => {
       expect(mockConsoleWarn).toHaveBeenCalledTimes(1)
 
       const warningMessage = mockConsoleWarn.mock.calls[0][0]
-      expect(warningMessage).toContain('⚠️  Node.js 18 is deprecated')
+      expect(warningMessage).toContain('⚠️  Node.js 18 and below are deprecated')
       expect(warningMessage).toContain('will no longer be supported in future versions')
       expect(warningMessage).toContain('@supabase/supabase-js')
       expect(warningMessage).toContain('Please upgrade to Node.js 20 or later')