Time Trigger for batch upload

[wischi-chr]

First, thank you for this amazing app.

It would be nice to also have an additional time trigger for batch uploading to prevent batches that aren't full from lying around for too long. Maybe let the user select the time interval?

IMHO the upload time trigger doesn't have to be too accurate, so maybe attach so some events that already wake the app (better battery life?)

[sunstep]

Hi, thank you for the suggestion.

This is an amazing idea. Here is a proposal of how I would implement it:

I will create a new settings page (because this is a setting you might not adjust often) and put the ability to adjust it there.
Then at each wake up event of the phone, the phone will check if the expiration date of the batch has passed or not. If it passed, it will try to upload it, if it fails it will just try at the next wake up event.

The best thing is that no timer is needed, because we can take the timestamp of the first point in the batch and check based on that in the wake up event, that way it's a cheap operation and doesn't bother the phone any further with running timers while it's asleep.

Honestly, I haven't really worked with wake up events yet in the app, but I know I should because it would save a lot of battery, so this suggestion might be the start of that.

Thanks again for the suggestion, this is on my todo list now!

[sunstep]

Implemented in 0.19.1: https://github.com/sunstep/dawarich-android/releases/tag/v0.19.1-beta.1

Please review so it can come out of beta. Either wait for Google to approve the release (which might take a few days) or install the APK from the release. The setting is accessible in the tracker page when sliding past the batching setting.

Thank you for suggesting this.