Skip to content

Commit e4611dd

Browse files
daxian-dbwmirichmo
authored andcommitted
fix broken links in 'maintainers/README.m' and update 'building/linux.md' (PowerShell#1938)
1 parent 3d69bb7 commit e4611dd

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

docs/building/linux.md

+2-7
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,9 @@ which require manual dependency resolution.
3838
Installing the toolchain is as easy as running `Start-PSBootstrap` in PowerShell.
3939
Of course, this requires a self-hosted copy of PowerShell on Linux.
4040

41-
Fortunately, this is as easy as downloading and installing the package.
42-
Unfortunately, while the repository is still private, the package cannot be downloaded as simply as with `wget`.
43-
41+
Fortunately, this is as easy as [downloading and installing the package](../installation/linux.md).
4442
The `./tools/download.sh` script will also install the PowerShell package.
4543

46-
> You can alternatively download by using a browser, upload it to your
47-
> box via some other method, and manually install it.
48-
4944
In Bash:
5045

5146
```sh
@@ -69,7 +64,7 @@ The `Start-PSBootstrap` function does the following:
6964
- Adds the LLVM package feed
7065
- Installs our dependencies combined with the dependencies of the .NET CLI toolchain via `apt-get`
7166
- Uninstalls any prior versions of .NET CLI
72-
- Downloads and installs the latest .NET CLI 1.0.0-preview2 SDK to `~/.dotnet`
67+
- Downloads and installs the latest .NET CLI 1.0.0-preview3 SDK to `~/.dotnet`
7368

7469
If you want to use `dotnet` outside of `Start-PSBuild`, add `~/.dotnet` to your `PATH` environment variable.
7570

docs/maintainers/README.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Repository Maintainers are trusted stewards of the PowerShell repository responsible for maintaining consistency and quality of PowerShell code.
44
One of their primary responsibilities is merging pull requests after all requirements have been fulfilled.
55

6-
They have [write access](https://help.github.com/articles/permission-levels-for-an-organization-repository/) to the PowerShell repositories which gives them the power to:
6+
They have [write access](https://help.github.com/articles/repository-permission-levels-for-an-organization/) to the PowerShell repositories which gives them the power to:
77

88
1. `git push` to the official PowerShell repository
99
2. Merge pull requests
@@ -13,7 +13,7 @@ They have [write access](https://help.github.com/articles/permission-levels-for-
1313
- [Current Repository Maintainers](#current-repository-maintainers)
1414
- [Repository Maintainer Responsibilities](#repository-maintainer-responsibilities)
1515
- [Issue Management Process](#issue-management-process)
16-
- [Pull Request Workflow](#pull-management-process)
16+
- [Pull Request Workflow](#pull-request-workflow)
1717
- [Abandoned Pull Requests](#abandoned-pull-requests)
1818
- [Becoming a Repository Maintainer](#becoming-a-repository-maintainer)
1919

@@ -22,7 +22,7 @@ They have [write access](https://help.github.com/articles/permission-levels-for-
2222
* Sergei Vorobev ([vors](https://github.com/vors))
2323
* Jason Shirk ([lzybkr](https://github.com/lzybkr))
2424
* Dongbo Wang ([daxian-dbw](https://github.com/daxian-dbw))
25-
* Travis Plunk ([TravisEz123](https://github.com/TravisEz123))
25+
* Travis Plunk ([TravisEz13](https://github.com/TravisEz13))
2626
* Mike Richmond ([mirichmo](https://github.com/mirichmo))
2727
* Andy Schwartzmeyer ([andschwa](https://github.com/andschwa))
2828

@@ -34,11 +34,11 @@ If you are a Repository Maintainer, you:
3434

3535
1. **MUST** ensure that each contributor has signed a valid Contributor License Agreement (CLA)
3636
1. **MUST** verify compliance with any third party code license terms (e.g., requiring attribution, etc.) if the contribution contains third party code.
37-
1. **MUST** make sure that [any change requiring approval from the PowerShell Committee](#changes-that-require-an-rfc) has gone through the proper [RFC][RFC-repo] or approval process
37+
1. **MUST** make sure that [any change requiring approval from the PowerShell Committee](../community/governance.md#changes-that-require-an-rfc) has gone through the proper [RFC][RFC-repo] or approval process
3838
1. **MUST** validate that code reviews have been conducted before merging a pull request when no code is written
3939
1. **MUST** validate that tests and documentation have been written before merging a pull request that contains new functionality
4040
1. **SHOULD** add [the correct labels][issue-management] to issues and pull requests
41-
1. **SHOULD** make sure the correct [Area Experts](#area-experts) are assigned to relevant pull requests and issues.
41+
1. **SHOULD** make sure the correct [Area Experts](../community/governance.md#area-experts) are assigned to relevant pull requests and issues.
4242
This includes adding extra reviewers when it makes sense
4343
(e.g. a pull request that adds remoting capabilities might require a security expert)
4444
1. **SHOULD** validate that the names and email addresses in the git commits reasonably match identity of the person submitting the pull request
@@ -96,7 +96,7 @@ In these cases:
9696

9797
## Becoming a Repository Maintainer
9898

99-
Repository Maintainers currently consist entirely of Microsoft employees
99+
Repository Maintainers currently consist entirely of Microsoft employees.
100100
It is expected that over time, regular trusted contributors to the PowerShell repository will be made Repository Maintainers.
101101
Eligibility is heavily dependent on the level of contribution and expertise: individuals who contribute in meaningful ways to the project will be recognized accordingly.
102102

0 commit comments

Comments
 (0)