You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/maintainers/README.md
+6-6
Original file line number
Diff line number
Diff line change
@@ -3,7 +3,7 @@
3
3
Repository Maintainers are trusted stewards of the PowerShell repository responsible for maintaining consistency and quality of PowerShell code.
4
4
One of their primary responsibilities is merging pull requests after all requirements have been fulfilled.
5
5
6
-
They have [write access](https://help.github.com/articles/permission-levels-for-an-organization-repository/) to the PowerShell repositories which gives them the power to:
6
+
They have [write access](https://help.github.com/articles/repository-permission-levels-for-an-organization/) to the PowerShell repositories which gives them the power to:
7
7
8
8
1.`git push` to the official PowerShell repository
9
9
2. Merge pull requests
@@ -13,7 +13,7 @@ They have [write access](https://help.github.com/articles/permission-levels-for-
* Mike Richmond ([mirichmo](https://github.com/mirichmo))
27
27
* Andy Schwartzmeyer ([andschwa](https://github.com/andschwa))
28
28
@@ -34,11 +34,11 @@ If you are a Repository Maintainer, you:
34
34
35
35
1.**MUST** ensure that each contributor has signed a valid Contributor License Agreement (CLA)
36
36
1.**MUST** verify compliance with any third party code license terms (e.g., requiring attribution, etc.) if the contribution contains third party code.
37
-
1.**MUST** make sure that [any change requiring approval from the PowerShell Committee](#changes-that-require-an-rfc) has gone through the proper [RFC][RFC-repo] or approval process
37
+
1.**MUST** make sure that [any change requiring approval from the PowerShell Committee](../community/governance.md#changes-that-require-an-rfc) has gone through the proper [RFC][RFC-repo] or approval process
38
38
1.**MUST** validate that code reviews have been conducted before merging a pull request when no code is written
39
39
1.**MUST** validate that tests and documentation have been written before merging a pull request that contains new functionality
40
40
1.**SHOULD** add [the correct labels][issue-management] to issues and pull requests
41
-
1.**SHOULD** make sure the correct [Area Experts](#area-experts) are assigned to relevant pull requests and issues.
41
+
1.**SHOULD** make sure the correct [Area Experts](../community/governance.md#area-experts) are assigned to relevant pull requests and issues.
42
42
This includes adding extra reviewers when it makes sense
43
43
(e.g. a pull request that adds remoting capabilities might require a security expert)
44
44
1.**SHOULD** validate that the names and email addresses in the git commits reasonably match identity of the person submitting the pull request
@@ -96,7 +96,7 @@ In these cases:
96
96
97
97
## Becoming a Repository Maintainer
98
98
99
-
Repository Maintainers currently consist entirely of Microsoft employees
99
+
Repository Maintainers currently consist entirely of Microsoft employees.
100
100
It is expected that over time, regular trusted contributors to the PowerShell repository will be made Repository Maintainers.
101
101
Eligibility is heavily dependent on the level of contribution and expertise: individuals who contribute in meaningful ways to the project will be recognized accordingly.
0 commit comments