Move lint to own CI task

Author: alexander-schranz

.env.dist

@@ -13,7 +13,7 @@ jobs:
         runs-on: ubuntu-latest
 
         env:
-            DATABASE_URL: mysql://root:[email protected]:3306/sulu_test?serverVersion=5.7
+            DATABASE_URL: mysql://root:[email protected]:3306/sulu_test?serverVersion=8.0
 
         strategy:
             fail-fast: false
@@ -96,11 +96,33 @@ jobs:
               run: composer initialize
               env: ${{ matrix.env }}
 
-            - name: Lint code
-              if: ${{ matrix.lint }}
-              run: composer lint
-              env: ${{ matrix.env }}
-
             - name: Execute test cases
               run: time composer test -- --config ${{ matrix.phpunit-config || 'phpunit.xml.dist' }}
               env: ${{ matrix.env }}
+
+    lint:
+        name: "PHP Lint"
+        runs-on: ubuntu-latest
+
+        env:
+            DATABASE_URL: mysql://root:[email protected]:3306/sulu_test?serverVersion=8.0
+
+        steps:
+            - name: Checkout project
+              uses: actions/checkout@v2
+
+            - name: Install and configure PHP
+              uses: shivammathur/setup-php@v2
+              with:
+                  php-version: 8.3
+                  extensions: 'ctype, iconv, mysql, imagick'
+                  tools: 'composer:v2'
+                  coverage: none
+
+            - name: Install composer dependencies
+              uses: ramsey/composer-install@v2
+              with:
+                  dependency-versions: highest
+
+            - name: Lint code
+              run: composer lint

.github/workflows/test-application.yaml

@@ -62,7 +62,10 @@
             "@php-cs"
         ],
         "phpunit": "vendor/bin/phpunit",
-        "phpstan": "vendor/bin/phpstan analyze -c ./phpstan.neon . -l 5",
+        "phpstan": [
+            "Tests/Application/console cache:warmup --env dev",
+            "vendor/bin/phpstan analyze -c ./phpstan.neon . -l 5"
+        ],
         "php-cs": "vendor/bin/php-cs-fixer fix --verbose --diff --dry-run",
         "php-cs-fix": "vendor/bin/php-cs-fixer fix"
     }

composer.json

@@ -7,7 +7,7 @@ includes:
 parameters:
     paths:
         - .
-    excludes_analyse:
+    excludePaths:
         - %currentWorkingDirectory%/DependencyInjection/Configuration.php
         - %currentWorkingDirectory%/EventSubscriber/AutoLoginSubscriber.php
         - %currentWorkingDirectory%/Middleware/EventMiddleware.php