rubocop: reran auto_gen_config

Author: ndushay

.rubocop_todo.yml

@@ -1,12 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-04-08 15:57:26 -0500 using RuboCop version 0.58.2.
+# on 2020-06-09 17:52:24 -0700 using RuboCop version 0.58.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 12
+# Offense count: 11
 # Cop supports --auto-correct.
 # Configuration parameters: Include, TreatCommentsAsGroupSeparators.
 # Include: **/*.gemfile, **/Gemfile, **/gems.rb
@@ -20,12 +20,11 @@ Lint/AmbiguousOperator:
     - 'app/models/hydrus/collection.rb'
     - 'app/models/hydrus/solr_queryable.rb'
 
-# Offense count: 4
+# Offense count: 3
 Lint/AmbiguousRegexpLiteral:
   Exclude:
     - 'devel/get_datastreams.rb'
     - 'spec/features/collection_create_spec.rb'
-    - 'spec/support/helpers.rb'
 
 # Offense count: 1
 # Configuration parameters: AllowSafeAssignment.
@@ -107,7 +106,7 @@ Lint/UnusedMethodArgument:
     - 'devel/dashboard_experiment.rb'
     - 'spec/helpers/application_helper_spec.rb'
 
-# Offense count: 29
+# Offense count: 28
 Lint/UselessAssignment:
   Exclude:
     - 'app/models/hydrus/collection.rb'
@@ -121,7 +120,6 @@ Lint/UselessAssignment:
     - 'spec/features/collection_edit_spec.rb'
     - 'spec/features/item_create_spec.rb'
     - 'spec/features/item_edit_spec.rb'
-    - 'spec/features/models/item_spec.rb'
     - 'spec/helpers/application_helper_spec.rb'
     - 'spec/models/hydrus/solr_queryable_spec.rb'
     - 'spec/support/helpers.rb'
@@ -132,15 +130,15 @@ Lint/Void:
   Exclude:
     - 'spec/features/item_create_spec.rb'
 
-# Offense count: 43
+# Offense count: 44
 Metrics/AbcSize:
   Max: 119
 
-# Offense count: 11
+# Offense count: 10
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 163
+  Max: 129
 
 # Offense count: 9
 # Configuration parameters: CountComments.
@@ -165,13 +163,12 @@ Metrics/ModuleLength:
 Metrics/PerceivedComplexity:
   Max: 24
 
-# Offense count: 7
+# Offense count: 6
 Naming/AccessorMethodName:
   Exclude:
     - 'app/models/hydrus/eventable.rb'
     - 'app/models/hydrus/generic_object.rb'
     - 'app/models/hydrus/object_file.rb'
-    - 'app/models/hydrus/workflow_ds_extension.rb'
 
 # Offense count: 18
 # Configuration parameters: EnforcedStyle.
@@ -181,7 +178,7 @@ Naming/HeredocDelimiterCase:
     - 'spec/models/hydrus/item_spec.rb'
     - 'spec/models/hydrus/related_item_spec.rb'
 
-# Offense count: 29
+# Offense count: 28
 # Configuration parameters: Blacklist.
 # Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
@@ -214,7 +211,7 @@ Naming/MethodName:
   Exclude:
     - 'app/models/hydrus/admin_policy_object.rb'
 
-# Offense count: 39
+# Offense count: 38
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # NamePrefixBlacklist: is_, has_, have_
@@ -233,7 +230,6 @@ Naming/PredicateName:
     - 'app/models/hydrus/generic_object_stuff.rb'
     - 'app/models/hydrus/item.rb'
     - 'app/models/hydrus/object_file.rb'
-    - 'app/models/hydrus/processable.rb'
     - 'app/models/hydrus/user_workflowable.rb'
     - 'app/models/user.rb'
 
@@ -291,14 +287,12 @@ Performance/StartWith:
   Exclude:
     - 'app/models/hydrus/item.rb'
 
-# Offense count: 5
+# Offense count: 3
 # Cop supports --auto-correct.
 Performance/StringReplacement:
   Exclude:
-    - 'app/helpers/application_helper.rb'
     - 'app/models/hydrus/remediation_runner.rb'
     - 'app/models/hydrus/responsible.rb'
-    - 'lib/tasks/fixtures.rake'
 
 # Offense count: 37
 # Cop supports --auto-correct.
@@ -326,21 +320,20 @@ Style/BarePercentLiterals:
 Style/BlockDelimiters:
   Enabled: false
 
-# Offense count: 11
+# Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: braces, no_braces, context_dependent
 Style/BracesAroundHashParameters:
   Exclude:
     - 'devel/dashboard_experiment.rb'
     - 'lib/tasks/hydrus.rake'
-    - 'spec/controllers/hydrus_items_controller_spec.rb'
     - 'spec/features/collection_create_spec.rb'
     - 'spec/features/item_create_spec.rb'
     - 'spec/lib/is_druid_validator_spec.rb'
     - 'spec/models/hydrus/item_spec.rb'
 
-# Offense count: 31
+# Offense count: 29
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -355,7 +348,7 @@ Style/ClassCheck:
   Exclude:
     - 'app/models/hydrus/generic_object_stuff.rb'
 
-# Offense count: 4
+# Offense count: 3
 Style/ClassVars:
   Exclude:
     - 'app/controllers/hydrus_solr_controller.rb'
@@ -405,7 +398,7 @@ Style/DefWithParentheses:
     - 'app/models/hy_time.rb'
     - 'devel/list_all_hydrus_objects.rb'
 
-# Offense count: 70
+# Offense count: 69
 Style/Documentation:
   Enabled: false
 
@@ -450,7 +443,7 @@ Style/ExpandPathArguments:
     - 'script/rails'
     - 'spec/spec_helper.rb'
 
-# Offense count: 180
+# Offense count: 183
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: when_needed, always, never
@@ -464,7 +457,7 @@ Style/GlobalVars:
     - 'devel/experiment.rb'
     - 'spec/support/rubydora_transactions_monkeypatch.rb'
 
-# Offense count: 23
+# Offense count: 22
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
@@ -473,7 +466,6 @@ Style/GuardClause:
     - 'app/helpers/application_helper.rb'
     - 'app/models/hydra/datastream/rights_metadata.rb'
     - 'app/models/hydrus/accessible.rb'
-    - 'app/models/hydrus/collection.rb'
     - 'app/models/hydrus/contentable.rb'
     - 'app/models/hydrus/generic_ds.rb'
     - 'app/models/hydrus/item.rb'
@@ -493,7 +485,7 @@ Style/IfInsideElse:
     - 'app/models/hydrus/item.rb'
     - 'devel/create_test_item.rb'
 
-# Offense count: 22
+# Offense count: 21
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Exclude:
@@ -531,7 +523,7 @@ Style/LineEndConcatenation:
   Exclude:
     - 'spec/models/hydrus/item_spec.rb'
 
-# Offense count: 84
+# Offense count: 71
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
 Style/MethodCallWithoutArgsParentheses:
@@ -642,7 +634,7 @@ Style/ParenthesesAroundCondition:
     - 'app/models/hydrus/item.rb'
     - 'app/models/hydrus/object_file.rb'
 
-# Offense count: 126
+# Offense count: 124
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -657,7 +649,7 @@ Style/PercentQLiterals:
     - 'spec/models/hydrus/accessible_spec.rb'
     - 'spec/models/hydrus/item_spec.rb'
 
-# Offense count: 22
+# Offense count: 21
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: short, verbose
@@ -668,15 +660,14 @@ Style/PreferredHashMethods:
     - 'app/helpers/hydrus_form_helper.rb'
     - 'devel/create_test_item.rb'
 
-# Offense count: 3
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: compact, exploded
 Style/RaiseArgs:
   Exclude:
     - 'app/controllers/datastreams_controller.rb'
     - 'app/controllers/events_controller.rb'
-    - 'app/controllers/hydrus_items_controller.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -696,7 +687,7 @@ Style/RedundantSelf:
     - 'app/models/hydrus/item.rb'
     - 'app/models/hydrus/user_workflowable.rb'
 
-# Offense count: 10
+# Offense count: 8
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
@@ -706,11 +697,9 @@ Style/RegexpLiteral:
     - 'app/models/hydrus/generic_object_stuff.rb'
     - 'app/models/hydrus/solr_queryable.rb'
     - 'spec/controllers/hydrus_collections_controller_spec.rb'
-    - 'spec/controllers/hydrus_items_controller_spec.rb'
     - 'spec/helpers/hydrus_form_helper_spec.rb'
     - 'spec/models/hydrus/item_spec.rb'
     - 'spec/models/hydrus/object_file_spec.rb'
-    - 'spec/support/helpers.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -749,7 +738,7 @@ Style/StringLiteralsInInterpolation:
   Exclude:
     - 'app/helpers/hydrus_form_helper.rb'
 
-# Offense count: 63
+# Offense count: 64
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
@@ -784,14 +773,14 @@ Style/TrailingCommaInArguments:
     - 'spec/features/item_create_spec.rb'
     - 'spec/features/item_edit_spec.rb'
 
-# Offense count: 60
+# Offense count: 59
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
 Style/TrailingCommaInArrayLiteral:
   Enabled: false
 
-# Offense count: 85
+# Offense count: 84
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
@@ -854,7 +843,7 @@ Style/WordArray:
 Style/ZeroLengthPredicate:
   Enabled: false
 
-# Offense count: 940
+# Offense count: 1013
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength: