Merge pull request #1059 from sul-dlss/alternate-orcid-format

deal with another alternate orcid format for contributors

Author: justinlittman

app/services/orcid_builder.rb

@@ -48,6 +48,6 @@ def orcidid(contributor)
     return identifier.uri if identifier.uri
     return identifier.value if identifier.value.start_with?('https://orcid.org/')
 
-    URI.join(identifier.source.uri, identifier.value).to_s
+    URI.join('https://orcid.org/', identifier.value).to_s
   end
 end

spec/indexers/descriptive_metadata_indexer_spec.rb

@@ -124,7 +124,7 @@
           ],
           identifier: [
             {
-              value: 'https://orcid.org/0000-0001-5321-289X',
+              value: '0000-0001-5321-289X',
               type: 'ORCID',
               source: {
                 code: 'orcid'