✨Forbidden user can request an invitation

[AntoLC]

Feature Request

If you are not invited to a doc but try to access it, you get a 404 (not found).
We would like to change this behavior to send back a 403 (not allowed).
If we have a 403, we can provide a button to request an invitation from the owner / admin.
If the user has already requested an invitation the button should not be displayed anymore, a message to explain instead.

[HaroWana]

I'd like to work on this feature, would that be ok?

If so, I do have a couple questions first:

• How shall we notify the document owner of the document access request? My first guess would be through email?
• If we notify through email, should we add a button link to the email to give access or simply give enough user info so the document owner can manually add the requester?
• Being new to this project, is there anything you think I should particularly pay attention to while implementing this feature?

Thank you.

[virgile-dev]

Hey @HaroWana

• We'd notify by email yeah
• A button would be great, once clicked for the action to be executed we need to check if he is authenticated and request if not and display the document with the sharing modal open so the user can see the new member was effectively added
• Please checkout the contributing policy before hand

Here are the mockups that we had for this feature
(Keep

[HaroWana]

Hey @HaroWana

• We'd notify by email yeah
• A button would be great, once clicked for the action to be executed we need to check if he is authenticated and request if not and display the document with the sharing modal open so the user can see the new member was effectively added
• Please checkout the contributing policy before hand

Here are the mockups that we had for this feature
(Keep

Hi @virgile-dev !

Thank you for your reply!
I shall get on it right away.
Does the notification email require design or should I just keep it generic.

[virgile-dev]

Emails have an html template here is an example.

I guess here we'd need to send 2 emails :

• 1 for ask for access (when a user clicks on ask for access), this should be sent to the document owner(s) and administrator(s)
• 1 when the access is granted (we can just reuse the email we already have for when someone invites you on a document).

Here the copy for the ask for access email:

---

Subject:

{user.name} {user.lastname} asked for access on {document.title}

Content:

<h1>{user.name} {user.lastname} requested access to your document</h1>

{user.name} {user.lastname} ({user.email}) requested access on the following document: <a href="{document.link}>{document.title}</a>

<btn>Open</btn>

Docs, your new essential tool for organizing, sharing and collaborating on your documents as a team.

Brought to you by La Suite Numérique

[HaroWana]

I just noticed that a pull request addressing this issue was submitted yesterday. (#1081)

I'm almost done with the development of the feature on my side, only the tests are missing, so I'm not sure what to do now.
Our approach to solving this does differ, so if you'd like to consult my code here is my branch: https://github.com/HaroWana/docs/tree/document_access_request

[virgile-dev]

Hey @HaroWana ! So sorry. This is on me. I forgot to mention to Antho you were planning to contribute on this. Last few weeks have been crazy with the last events (Hack Days, Viva Tech, OW2Con) before the summer. This is not the contributing experience we want to offer. I'd love to jump in a call to apologize and see if we can compare approaches with @AntoLC and see if we can onboard you properly on another issue. What do you say?