chore: fix shellcheck styles, add shellcheckrc

we add the shellcheckrc to ignore useless cat: https://www.shellcheck.net/wiki/SC2002
since that is a purely stylistic choice that does not
affect correctness and is easy to read/understand

Author: mds1

.shellcheckrc

@@ -0,0 +1 @@
+disable=SC2002

indexer/ui/prisma.sh

@@ -18,8 +18,8 @@ function check_prisma() {
     echo "Checking Prisma Schema..."
     cp "$PRISMA_FILE" "$TEMP_FILE"
     npx prisma db pull --url "$DATABASE_URL" --schema "$TEMP_FILE"
-    diff "$PRISMA_FILE" "$TEMP_FILE" > /dev/null
-    if [ $? -eq 0 ]; then
+
+    if diff "$PRISMA_FILE" "$TEMP_FILE" > /dev/null; then
         echo "Prisma Schema is up-to-date."
         rm "$TEMP_FILE"
     else

op-challenger/scripts/alphabet/charlie.sh

@@ -2,8 +2,8 @@
 set -euo pipefail
 
 SOURCE_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
-CHALLENGER_DIR=$(echo "${SOURCE_DIR%/*/*}")
-MONOREPO_DIR=$(echo "${SOURCE_DIR%/*/*/*}")
+CHALLENGER_DIR=$("${SOURCE_DIR%/*/*}")
+MONOREPO_DIR=$("${SOURCE_DIR%/*/*/*}")
 
 # Check that the fault game address file exists
 FAULT_GAME_ADDR_FILE="$CHALLENGER_DIR/.fault-game-address"

op-challenger/scripts/alphabet/init_game.sh

@@ -3,8 +3,8 @@
 set -euo pipefail
 
 SOURCE_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
-CHALLENGER_DIR=$(echo "${SOURCE_DIR%/*/*}")
-MONOREPO_DIR=$(echo "${SOURCE_DIR%/*/*/*}")
+CHALLENGER_DIR="${SOURCE_DIR%/*/*}"
+MONOREPO_DIR="${SOURCE_DIR%/*/*/*}"
 
 cd "$CHALLENGER_DIR"
 make

op-challenger/scripts/alphabet/mallory.sh

@@ -2,8 +2,8 @@
 set -euo pipefail
 
 SOURCE_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
-CHALLENGER_DIR=$(echo "${SOURCE_DIR%/*/*}")
-MONOREPO_DIR=$(echo "${SOURCE_DIR%/*/*/*}")
+CHALLENGER_DIR=$("${SOURCE_DIR%/*/*}")
+MONOREPO_DIR=$("${SOURCE_DIR%/*/*/*}")
 
 # Check that the fault game address file exists
 FAULT_GAME_ADDR_FILE="$CHALLENGER_DIR/.fault-game-address"

op-challenger/scripts/visualize.sh

@@ -6,7 +6,7 @@ RPC="${1:?Must specify RPC address}"
 FAULT_GAME_ADDRESS="${2:?Must specify game address}"
 
 DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-DIR=$(echo "${DIR%/*/*}")
+DIR="${DIR%/*/*}"
 cd "$DIR"/packages/contracts-bedrock
 
 forge script scripts/FaultDisputeGameViz.s.sol \

packages/contracts-bedrock/scripts/generate-l2-genesis.sh

@@ -31,7 +31,7 @@ cleanup() {
 wait_l2_outfile() {
   i=1
   while [ $i -le "$2" ]; do
-    i=$(($i + 1))
+    i=$((i + 1))
 
     if [ ! -f "$OUTFILE_L2" ]; then
       sleep "$1"

packages/contracts-bedrock/scripts/slither.sh

@@ -57,7 +57,7 @@ fi
 # Findings to keep are output to the slither-report.json output file.
 # Checking in a json file is cleaner than adding slither-disable comments throughout the codebase.
 # See slither.config.json for slither settings and to disable specific detectors.
-if [[ ! -z "$TRIAGE_MODE" ]]; then
+if [[ -n "$TRIAGE_MODE" ]]; then
   echo "Running slither in triage mode"
   SLITHER_OUTPUT=$(slither . --triage-mode --json $SLITHER_REPORT || true)