Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add other types of downstream plugins? #60

Open
2 tasks
Mouvedia opened this issue Nov 6, 2024 · 4 comments
Open
2 tasks

Should we add other types of downstream plugins? #60

Mouvedia opened this issue Nov 6, 2024 · 4 comments

Comments

@Mouvedia
Copy link
Member

Mouvedia commented Nov 6, 2024

e.g. stylelint-webpack-plugin, vite-plugin-stylelint, esbuild-plugin-stylelint, etc.


  • stylelint-webpack-plugin
  • nx-stylelint
@romainmenke
Copy link
Member

These are packages that run Stylelint for you, integrated into some other tool or task runner, right?

If these are testable and add meaningful coverage, then sure :)
Always good to have more insights before releasing.

@Mouvedia
Copy link
Member Author

Mouvedia commented Nov 6, 2024

nx is not a bundler but maybe nx-stylelint could be considered?

@romainmenke
Copy link
Member

romainmenke commented Nov 6, 2024

Same answer I guess :)

The goal of the project (as I understood it) is to make rolling out releases safer and more controlled.

We try to attain that goal by testing downstream dependents so that unexpected side-effects of changes can surface before a release.

I don't think we need to test every or even many downstream dependents.
That is both unrealistic and unsustainable.

By testing a few downstream dependents, those that are simple and easy to test, we gain a lot of assurances before a release. But the returns diminish sharply with each extra package we test.

If something can be trivially added to the existing list and adds some meaningful test coverage, then that is always nice.

If something is complex then I think we might want to avoid adding it here.

@Mouvedia Mouvedia changed the title Should we add bundler plugins? Should we add other types of downstream plugins? Nov 6, 2024
@Mouvedia
Copy link
Member Author

Mouvedia commented Nov 6, 2024

But the returns diminish sharply with each extra package we test.

Then let's add the ones that have tests for now.
i.e. stylelint-webpack-plugin (for rspack and webpack) and nx-stylelint


off-topic

I am kind of surprised that we don't have an unplugin-stylelint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants