tox

Author: stringertheory

clean_links/clean.py

@@ -12,14 +12,14 @@ def query_string(url: str, rules: list) -> str:
     split = urlsplit(url)
     params = parse_qs(split.query)
 
-    delete_keys = {None, ""}
+    delete_keys = {""}
     for rule in rules:
         for key in params:
             if re.match("^" + rule + "$", key, flags=re.IGNORECASE):
                 delete_keys.add(key)
 
     for delete_key in delete_keys:
-        params.pop(delete_key, "")  # type: ignore[arg-type]
+        params.pop(delete_key, None)
 
     params_string = urlencode(params, doseq=True)
 

clean_links/unshorten.py

@@ -1,4 +1,5 @@
 import logging
+from typing import Union
 
 import requests
 from urllib3.exceptions import InsecureRequestWarning
@@ -28,7 +29,7 @@
 }
 
 
-def get_last_url_from_exception(exc: Exception) -> str | None:
+def get_last_url_from_exception(exc: Exception) -> Union[str, None]:
     result = None
 
     try:

tox.ini

@@ -16,4 +16,4 @@ allowlist_externals = poetry
 commands =
     poetry install -v
     pytest --doctest-modules tests --cov --cov-config=pyproject.toml --cov-report=xml
-    mypy
+    mypy --disable-error-code attr-defined