[ST] Change the way how we are deleting KafkaNodePools and Kafka in tests #12191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests Signed-off-by: Lukas Kral <[email protected]>
Member
Author
|
/gha run pipeline=regression,regression-fg,upgrade |
|
⏳ System test verification started: link The following 16 job(s) will be executed:
Tests will start after successful build completion. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12191 +/- ##
=========================================
Coverage 74.77% 74.78%
- Complexity 6623 6629 +6
=========================================
Files 377 377
Lines 25349 25360 +11
Branches 3398 3402 +4
=========================================
+ Hits 18955 18965 +10
Misses 5008 5008
- Partials 1386 1387 +1 🚀 New features to boost your workflow:
|
|
❌ System test verification failed: link |
|
🎉 System test verification passed: link |
Member
Author
|
/gha run pipeline=regression,regression-fg,upgrade |
|
⏳ System test verification started: link The following 16 job(s) will be executed:
Tests will start after successful build completion. |
|
🎉 System test verification passed: link |
Member
Author
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/gha run pipeline=regression,regression-fg,upgrade |
|
⏳ System test verification started: link The following 16 job(s) will be executed:
Tests will start after successful build completion. |
|
🎉 System test verification passed: link |
Frawless
approved these changes
Dec 4, 2025
Signed-off-by: Lukas Kral <[email protected]>
Member
Author
|
/gha run pipeline=regression |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
|
🎉 System test verification passed: link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The PR should fix issues with deletion of KNP and PVCs in tests - because of race condition and deletion order of Kafka and KNP resources, the check for deletion of the PVCs can fail - as the Kafka resource is deleted before KNP and Pods (with PVCs) are removed. Adding deletion of KNP before Kafka seems to fix this issue, so this PR adds this deletion of KNPs (connected to the particular Kafka resource) into the deletion method of Kafka.
This way is the only solution without any other hacks in our STs or Test Frame.
Checklist