3636// - `impl_into_encodable_field_for_seq!`: Implements conversions to `EncodableField` for a
3737// sequence, adapting the sequence for inclusion in serialized structures.
3838//
39- // ## Notes on Serialization
40- //
41- // Types are designed to interoperate with the `serde-sv2` framework, using lifetimes
42- // (`'a`) for compatibility with external lifetimes and ensuring the types can be converted into
43- // various serialized forms with or without `serde` support.
44- //
4539// ## Build Options
4640//
4741// - `prop_test`: Enables property-based testing compatibility by implementing `TryFrom` for `Vec`
@@ -60,7 +54,7 @@ use crate::{
6054} ;
6155use core:: marker:: PhantomData ;
6256
63- // TODO add test for that and implement it also with serde!!!!
57+ // TODO add test for that
6458impl < ' a , const SIZE : usize , const HEADERSIZE : usize , const MAXSIZE : usize >
6559 Seq0255 < ' a , super :: inner:: Inner < ' a , false , SIZE , HEADERSIZE , MAXSIZE > >
6660{
@@ -74,7 +68,7 @@ impl<'a, const SIZE: usize, const HEADERSIZE: usize, const MAXSIZE: usize>
7468 }
7569}
7670
77- // TODO add test for that and implement it also with serde!!!!
71+ // TODO add test for that
7872impl < ' a , const SIZE : usize > Seq0255 < ' a , super :: inner:: Inner < ' a , true , SIZE , 0 , 0 > > {
7973 /// Converts the inner types to owned vector, and collects.
8074pub fn to_vec ( & self ) -> Vec < Vec < u8 > > {
@@ -86,7 +80,7 @@ impl<'a, const SIZE: usize> Seq0255<'a, super::inner::Inner<'a, true, SIZE, 0, 0
8680 self . 0 . iter ( ) . map ( |x| x. inner_as_ref ( ) ) . collect ( )
8781 }
8882}
89- // TODO add test for that and implement it also with serde!!!!
83+ // TODO add test for that
9084impl < ' a , const SIZE : usize , const HEADERSIZE : usize , const MAXSIZE : usize >
9185 Seq064K < ' a , super :: inner:: Inner < ' a , false , SIZE , HEADERSIZE , MAXSIZE > >
9286{
@@ -101,7 +95,7 @@ impl<'a, const SIZE: usize, const HEADERSIZE: usize, const MAXSIZE: usize>
10195 }
10296}
10397
104- // TODO add test for that and implement it also with serde!!!!
98+ // TODO add test for that
10599impl < ' a , const SIZE : usize > Seq064K < ' a , super :: inner:: Inner < ' a , true , SIZE , 0 , 0 > > {
106100 /// Converts the inner types to owned vector, and collects.
107101pub fn to_vec ( & self ) -> Vec < Vec < u8 > > {
@@ -118,8 +112,7 @@ impl<'a, const SIZE: usize> Seq064K<'a, super::inner::Inner<'a, true, SIZE, 0, 0
118112use std:: io:: Read ;
119113
120114/// [`Seq0255`] represents a sequence with a maximum length of 255 elements.
121- /// This structure uses a generic type `T` and a lifetime parameter `'a`
122- /// to ensure compatibility with `serde-sv2`.
115+ /// This structure uses a generic type `T` and a lifetime parameter `'a`.
123116#[ repr( C ) ]
124117#[ derive( Debug , Clone , Eq , PartialEq ) ]
125118pub struct Seq0255 < ' a , T > ( pub Vec < T > , PhantomData < & ' a T > ) ;
@@ -163,8 +156,7 @@ impl<'a, T: GetSize> GetSize for Seq0255<'a, T> {
163156}
164157
165158/// [`Seq064K`] represents a sequence with a maximum length of 65535 elements.
166- /// This structure uses a generic type `T` and a lifetime parameter `'a`
167- /// to ensure compatibility with `serde-sv2`.
159+ /// This structure uses a generic type `T` and a lifetime parameter `'a`.
168160#[ derive( Debug , Clone , Eq , PartialEq ) ]
169161pub struct Seq064K < ' a , T > ( pub ( crate ) Vec < T > , PhantomData < & ' a T > ) ;
170162
@@ -455,12 +447,12 @@ impl<'a, const ISFIXED: bool, const SIZE: usize, const HEADERSIZE: usize, const
455447 }
456448}
457449
458- /// The liftime is here only for type compatibility with serde-sv2
450+ /// The lifetime 'a is defined.
459451#[ repr( C ) ]
460452#[ derive( Debug , Clone , Eq , PartialEq ) ]
461453pub struct Sv2Option < ' a , T > ( pub Vec < T > , PhantomData < & ' a T > ) ;
462454
463- // TODO add test for that and implement it also with serde!!!!
455+ // TODO add test for that
464456impl < ' a , const SIZE : usize > Sv2Option < ' a , super :: inner:: Inner < ' a , true , SIZE , 0 , 0 > > {
465457 /// Gets the owned first element of the sequence, if present
466458pub fn to_option ( & self ) -> Option < Vec < u8 > > {
0 commit comments