remove with_serde feature flag from framing-sv2

Author: Shourya742

protocols/v2/framing-sv2/Cargo.toml

@@ -25,7 +25,6 @@ rand = "0.8.3"
 secp256k1 = { version = "0.28.2", default-features = false, features =["alloc","rand","rand-std"] }
 
 [features]
-with_serde = ["binary_sv2/with_serde", "serde", "buffer_sv2?/with_serde"]
 with_buffer_pool = ["binary_sv2/with_buffer_pool", "buffer_sv2"]
 
 [package.metadata.docs.rs]

protocols/v2/framing-sv2/README.md

@@ -57,14 +57,10 @@ cargo add framing_sv2
 This crate can be built with the following feature flags:
 
 - `with_buffer_pool`: Enables buffer pooling for more efficient memory management.
-- `with_serde`: builds [`binary_sv2`](https://crates.io/crates/binary_sv2) and
-  [`buffer_sv2`](https://crates.io/crates/buffer_sv2) crates with `serde`-based encoding and
-  decoding. Note that this feature flag is only used for the Message Generator, and deprecated
-  for any other kind of usage. It will likely be fully deprecated in the future.
 
 ### Examples
 
 This crate provides an example demonstrating how to serialize and deserialize Sv2 message frames:
 
 1. **[Sv2 Frame](https://github.com/stratum-mining/stratum/blob/main/protocols/v2/framing-sv2/examples/sv2_frame.rs)**:
-   Constructs, serializes, and deserialize a regular Sv2 message frame (`Sv2Frame`).
+   Constructs, serializes, and deserialize a regular Sv2 message frame (`Sv2Frame`).

protocols/v2/framing-sv2/examples/sv2_frame.rs

@@ -14,36 +14,22 @@
 // ## Run
 //
 // ```
-// cargo run --example sv2_frame --features with_serde
+// cargo run --example sv2_frame
 // ```
 
-#[cfg(feature = "with_serde")]
-use binary_sv2::{GetSize, Serialize};
-#[cfg(feature = "with_serde")]
+use binary_sv2::{binary_codec_sv2, Serialize};
 use framing_sv2::framing::Sv2Frame;
 
 // Example message type (e.g., SetupConnection)
-#[cfg(feature = "with_serde")]
 const MSG_TYPE: u8 = 1;
 // Example extension type (e.g., a standard Sv2 message)
-#[cfg(feature = "with_serde")]
 const EXT_TYPE: u16 = 0x0001;
 
-#[cfg(feature = "with_serde")]
 #[derive(Serialize, Debug)]
-struct CustomMessage {
+pub struct CustomMessage {
     pub data: u32,
 }
 
-// Implemented to help determine the size of the message when framing.
-#[cfg(feature = "with_serde")]
-impl GetSize for CustomMessage {
-    fn get_size(&self) -> usize {
-        4 // `data` is `u32`, which is 4 bytes
-    }
-}
-
-#[cfg(feature = "with_serde")]
 fn main() {
     // Create the message payload
     let message = CustomMessage { data: 42 };
@@ -67,11 +53,7 @@ fn main() {
     // Deserialize the frame from bytes back into an Sv2Frame
     let mut deserialized_frame = Sv2Frame::<CustomMessage, Vec<u8>>::from_bytes(serialized_frame)
         .expect("Failed to deserialize frame");
+
     assert_eq!(deserialized_frame.encoded_length(), 10); // 6 header bytes + 4 payload bytes
     assert_eq!(deserialized_frame.payload(), [42, 0, 0, 0]);
 }
-
-#[cfg(not(feature = "with_serde"))]
-fn main() {
-    eprintln!("Serde feature not enabled. Skipping example.");
-}

protocols/v2/framing-sv2/src/framing.rs

@@ -82,15 +82,8 @@ impl<T: Serialize + GetSize, B: AsMut<[u8]> + AsRef<[u8]>> Sv2Frame<T, B> {
             dst.swap_with_slice(serialized.as_mut());
             Ok(())
         } else if let Some(payload) = self.payload {
-            #[cfg(not(feature = "with_serde"))]
             to_writer(self.header, dst).map_err(Error::BinarySv2Error)?;
-            #[cfg(not(feature = "with_serde"))]
             to_writer(payload, &mut dst[Header::SIZE..]).map_err(Error::BinarySv2Error)?;
-            #[cfg(feature = "with_serde")]
-            to_writer(&self.header, dst.as_mut()).map_err(Error::BinarySv2Error)?;
-            #[cfg(feature = "with_serde")]
-            to_writer(&payload, &mut dst.as_mut()[Header::SIZE..])
-                .map_err(Error::BinarySv2Error)?;
             Ok(())
         } else {
             // Sv2Frame always has a payload or a serialized payload

protocols/v2/framing-sv2/src/header.rs

@@ -20,11 +20,8 @@
 //!   header itself.
 
 use crate::Error;
-#[cfg(not(feature = "with_serde"))]
 use alloc::vec::Vec;
-#[cfg(not(feature = "with_serde"))]
-use binary_sv2::binary_codec_sv2;
-use binary_sv2::{Deserialize, Serialize, U24};
+use binary_sv2::{binary_codec_sv2, Deserialize, Serialize, U24};
 use const_sv2::{AEAD_MAC_LEN, SV2_FRAME_CHUNK_SIZE};
 use core::convert::TryInto;
 

protocols/v2/framing-sv2/src/lib.rs

@@ -40,10 +40,6 @@
 //! This crate can be built with the following features:
 //!
 //! - `with_buffer_pool`: Enables buffer pooling for more efficient memory management.
-//! - `with_serde`: builds [`binary_sv2`] and [`buffer_sv2`](https://crates.io/crates/buffer_sv2)
-//!   crates with `serde`-based encoding and decoding. Note that this feature flag is only used for
-//!   the Message Generator, and deprecated for any other kind of usage. It will likely be fully
-//!   deprecated in the future.
 //!
 //! ## Examples
 //!