Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use addressZero and hashZero from viem instead #387

Open
linear bot opened this issue Jan 20, 2025 · 0 comments · May be fixed by #415
Open

Use addressZero and hashZero from viem instead #387

linear bot opened this issue Jan 20, 2025 · 0 comments · May be fixed by #415
Labels
enhancement New feature or request

Comments

@linear
Copy link

linear bot commented Jan 20, 2025

Remove AddressZero and HashZero from constants. We should be consistent and use zeroAddress and zeroHash from viem.

Also doesn't seem like HashZero is used at all, maybe we can just remove it?
@linear linear bot added enhancement New feature or request Improvement and removed Improvement labels Jan 20, 2025
@DracoLi DracoLi changed the title chore: use addressZero and hashZero from viem instead Use addressZero and hashZero from viem instead Jan 20, 2025
@holazz holazz linked a pull request Feb 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: use zeroAddress instead of AddressZero & remove HashZero holazz/sdk
0 participants