Skip to content

Inconsistent argument naming in set_licensing_config method #124

@bonnie57

Description

@bonnie57

Description:
The method currently mixes camelCase and snake_case argument naming conventions. For example, expectMinimumGroupRewardShare is used instead of expect_minimum_group_reward_share.

This inconsistency caused the expect_minimum_group_reward_share issue remain unfixed in the current implementation.

Impact:

  • Breaks Python best practices, which recommend consistent use of snake_case for arguments.
  • Prevents proper resolution of the expect_minimum_group_reward_share issue.
  • Causes confusion and reduces API usability and maintainability.

Expected Behavior:

  • All licensing_config properties should consistently use snake_case.
  • set_licensing_config should be updated to use expect_minimum_group_reward_share.
  • Fix the scale expect_minimum_group_reward_share issue to ensure proper functionality.
  • Update documentation and tests to reflect the corrected naming convention.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions